organizationMembersList.spec.tsx 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654
  1. import {AuthProviderFixture} from 'sentry-fixture/authProvider';
  2. import {MemberFixture} from 'sentry-fixture/member';
  3. import {MembersFixture} from 'sentry-fixture/members';
  4. import {OrganizationFixture} from 'sentry-fixture/organization';
  5. import {RouterFixture} from 'sentry-fixture/routerFixture';
  6. import {TeamFixture} from 'sentry-fixture/team';
  7. import {UserFixture} from 'sentry-fixture/user';
  8. import {
  9. render,
  10. renderGlobalModal,
  11. screen,
  12. userEvent,
  13. waitFor,
  14. within,
  15. } from 'sentry-test/reactTestingLibrary';
  16. import selectEvent from 'sentry-test/selectEvent';
  17. import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicator';
  18. import ConfigStore from 'sentry/stores/configStore';
  19. import ModalStore from 'sentry/stores/modalStore';
  20. import OrganizationsStore from 'sentry/stores/organizationsStore';
  21. import {trackAnalytics} from 'sentry/utils/analytics';
  22. import OrganizationMembersList from 'sentry/views/settings/organizationMembers/organizationMembersList';
  23. jest.mock('sentry/utils/analytics');
  24. jest.mock('sentry/actionCreators/indicator');
  25. const roles = [
  26. {
  27. id: 'admin',
  28. name: 'Admin',
  29. desc: 'This is the admin role',
  30. isAllowed: true,
  31. },
  32. {
  33. id: 'member',
  34. name: 'Member',
  35. desc: 'This is the member role',
  36. isAllowed: true,
  37. },
  38. {
  39. id: 'owner',
  40. name: 'Owner',
  41. desc: 'This is the owner role',
  42. isAllowed: true,
  43. },
  44. ];
  45. describe('OrganizationMembersList', function () {
  46. const members = MembersFixture();
  47. const team = TeamFixture({slug: 'team'});
  48. const member = MemberFixture({
  49. id: '5',
  50. email: 'member@sentry.io',
  51. teams: [team.slug],
  52. teamRoles: [
  53. {
  54. teamSlug: team.slug,
  55. role: null,
  56. },
  57. ],
  58. flags: {
  59. 'sso:linked': true,
  60. 'idp:provisioned': false,
  61. 'idp:role-restricted': false,
  62. 'member-limit:restricted': false,
  63. 'partnership:restricted': false,
  64. 'sso:invalid': false,
  65. },
  66. });
  67. const currentUser = members[1]!;
  68. currentUser.user = UserFixture({
  69. ...currentUser,
  70. flags: {newsletter_consent_prompt: true},
  71. });
  72. const organization = OrganizationFixture({
  73. access: ['member:admin', 'org:admin', 'member:write'],
  74. status: {
  75. id: 'active',
  76. name: 'active',
  77. },
  78. });
  79. const router = RouterFixture();
  80. beforeEach(function () {
  81. ConfigStore.set('user', currentUser.user!);
  82. MockApiClient.clearMockResponses();
  83. MockApiClient.addMockResponse({
  84. url: '/organizations/org-slug/members/me/',
  85. method: 'GET',
  86. body: {roles},
  87. });
  88. MockApiClient.addMockResponse({
  89. url: '/organizations/org-slug/members/',
  90. method: 'GET',
  91. body: [...MembersFixture(), member],
  92. });
  93. MockApiClient.addMockResponse({
  94. url: `/organizations/org-slug/members/${member.id}/`,
  95. body: member,
  96. });
  97. MockApiClient.addMockResponse({
  98. url: '/organizations/org-slug/access-requests/',
  99. method: 'GET',
  100. body: [
  101. {
  102. id: 'pending-id',
  103. member: {
  104. id: 'pending-member-id',
  105. email: '',
  106. name: '',
  107. role: '',
  108. roleName: '',
  109. user: {
  110. id: '',
  111. name: 'sentry@test.com',
  112. },
  113. },
  114. team: TeamFixture(),
  115. },
  116. ],
  117. });
  118. MockApiClient.addMockResponse({
  119. url: '/organizations/org-slug/auth-provider/',
  120. method: 'GET',
  121. body: {
  122. ...AuthProviderFixture(),
  123. require_link: true,
  124. },
  125. });
  126. MockApiClient.addMockResponse({
  127. url: '/organizations/org-slug/teams/',
  128. method: 'GET',
  129. body: [TeamFixture(), team],
  130. });
  131. MockApiClient.addMockResponse({
  132. url: '/organizations/org-slug/invite-requests/',
  133. method: 'GET',
  134. body: [],
  135. });
  136. MockApiClient.addMockResponse({
  137. url: '/organizations/org-slug/missing-members/',
  138. method: 'GET',
  139. body: [],
  140. });
  141. MockApiClient.addMockResponse({
  142. url: '/organizations/org-slug/prompts-activity/',
  143. method: 'GET',
  144. body: {
  145. dismissed_ts: undefined,
  146. snoozed_ts: undefined,
  147. },
  148. });
  149. OrganizationsStore.load([organization]);
  150. ModalStore.init();
  151. });
  152. it('can remove a member', async function () {
  153. const deleteMock = MockApiClient.addMockResponse({
  154. url: `/organizations/org-slug/members/${members[0]!.id}/`,
  155. method: 'DELETE',
  156. });
  157. render(<OrganizationMembersList />, {organization, router});
  158. renderGlobalModal({router});
  159. // The organization member row
  160. expect(await screen.findByTestId(members[0]!.email)).toBeInTheDocument();
  161. await userEvent.click(
  162. within(screen.getByTestId(members[0]!.email)).getByRole('button', {name: 'Remove'})
  163. );
  164. await userEvent.click(await screen.findByRole('button', {name: 'Confirm'}));
  165. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  166. expect(deleteMock).toHaveBeenCalled();
  167. expect(router.push).not.toHaveBeenCalled();
  168. expect(OrganizationsStore.getAll()).toEqual([organization]);
  169. });
  170. it('displays error message when failing to remove member', async function () {
  171. const deleteMock = MockApiClient.addMockResponse({
  172. url: `/organizations/org-slug/members/${members[0]!.id}/`,
  173. method: 'DELETE',
  174. statusCode: 500,
  175. });
  176. render(<OrganizationMembersList />, {organization, router});
  177. renderGlobalModal({router});
  178. // The organization member row
  179. expect(await screen.findByTestId(members[0]!.email)).toBeInTheDocument();
  180. await userEvent.click(
  181. within(screen.getByTestId(members[0]!.email)).getByRole('button', {name: 'Remove'})
  182. );
  183. await userEvent.click(await screen.findByRole('button', {name: 'Confirm'}));
  184. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  185. expect(deleteMock).toHaveBeenCalled();
  186. expect(router.push).not.toHaveBeenCalled();
  187. expect(OrganizationsStore.getAll()).toEqual([organization]);
  188. });
  189. it('can leave org', async function () {
  190. const deleteMock = MockApiClient.addMockResponse({
  191. url: `/organizations/org-slug/members/${members[1]!.id}/`,
  192. method: 'DELETE',
  193. });
  194. render(<OrganizationMembersList />, {organization, router});
  195. renderGlobalModal({router});
  196. await userEvent.click(await screen.findByRole('button', {name: 'Leave'}));
  197. await userEvent.click(await screen.findByRole('button', {name: 'Confirm'}));
  198. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  199. expect(deleteMock).toHaveBeenCalled();
  200. expect(router.push).toHaveBeenCalledTimes(1);
  201. expect(router.push).toHaveBeenCalledWith({pathname: '/organizations/new/'});
  202. });
  203. it('can redirect to remaining org after leaving', async function () {
  204. const deleteMock = MockApiClient.addMockResponse({
  205. url: `/organizations/org-slug/members/${members[1]!.id}/`,
  206. method: 'DELETE',
  207. });
  208. const secondOrg = OrganizationFixture({
  209. slug: 'org-two',
  210. status: {
  211. id: 'active',
  212. name: 'active',
  213. },
  214. });
  215. OrganizationsStore.addOrReplace(secondOrg);
  216. render(<OrganizationMembersList />, {organization, router});
  217. renderGlobalModal({router});
  218. await userEvent.click(await screen.findByRole('button', {name: 'Leave'}));
  219. await userEvent.click(screen.getByTestId('confirm-button'));
  220. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  221. expect(deleteMock).toHaveBeenCalled();
  222. expect(router.push).toHaveBeenCalledTimes(1);
  223. expect(router.push).toHaveBeenCalledWith({
  224. pathname: '/organizations/org-two/issues/',
  225. });
  226. expect(OrganizationsStore.getAll()).toEqual([secondOrg]);
  227. });
  228. it('displays error message when failing to leave org', async function () {
  229. const deleteMock = MockApiClient.addMockResponse({
  230. url: `/organizations/org-slug/members/${members[1]!.id}/`,
  231. method: 'DELETE',
  232. statusCode: 500,
  233. });
  234. render(<OrganizationMembersList />, {organization, router});
  235. renderGlobalModal({router});
  236. await userEvent.click(await screen.findByRole('button', {name: 'Leave'}));
  237. await userEvent.click(await screen.findByRole('button', {name: 'Confirm'}));
  238. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  239. expect(deleteMock).toHaveBeenCalled();
  240. expect(router.push).not.toHaveBeenCalled();
  241. expect(OrganizationsStore.getAll()).toEqual([organization]);
  242. });
  243. it('can re-send SSO link to member', async function () {
  244. const inviteMock = MockApiClient.addMockResponse({
  245. url: `/organizations/org-slug/members/${members[0]!.id}/`,
  246. method: 'PUT',
  247. body: {
  248. id: '1234',
  249. },
  250. });
  251. render(<OrganizationMembersList />, {organization});
  252. expect(inviteMock).not.toHaveBeenCalled();
  253. await userEvent.click(await screen.findByRole('button', {name: 'Resend SSO link'}));
  254. expect(inviteMock).toHaveBeenCalled();
  255. });
  256. it('can re-send invite to member', async function () {
  257. const inviteMock = MockApiClient.addMockResponse({
  258. url: `/organizations/org-slug/members/${members[1]!.id}/`,
  259. method: 'PUT',
  260. body: {
  261. id: '1234',
  262. },
  263. });
  264. render(<OrganizationMembersList />, {organization});
  265. expect(inviteMock).not.toHaveBeenCalled();
  266. await userEvent.click(await screen.findByRole('button', {name: 'Resend invite'}));
  267. expect(inviteMock).toHaveBeenCalled();
  268. });
  269. it('can search organization members', async function () {
  270. const filterRouter = RouterFixture();
  271. const searchMock = MockApiClient.addMockResponse({
  272. url: '/organizations/org-slug/members/',
  273. body: [],
  274. });
  275. const {rerender} = render(<OrganizationMembersList />, {
  276. router: filterRouter,
  277. });
  278. await userEvent.type(await screen.findByPlaceholderText('Search Members'), 'member');
  279. filterRouter.location.query = {query: 'member'};
  280. rerender(<OrganizationMembersList />);
  281. expect(searchMock).toHaveBeenLastCalledWith(
  282. '/organizations/org-slug/members/',
  283. expect.objectContaining({
  284. method: 'GET',
  285. query: {
  286. query: 'member',
  287. },
  288. })
  289. );
  290. await userEvent.keyboard('{enter}');
  291. await waitFor(() => {
  292. expect(filterRouter.push).toHaveBeenCalledTimes(1);
  293. });
  294. });
  295. it('can filter members', async function () {
  296. const searchMock = MockApiClient.addMockResponse({
  297. url: '/organizations/org-slug/members/',
  298. body: [],
  299. });
  300. const filterRouter = RouterFixture();
  301. const {rerender} = render(<OrganizationMembersList />, {
  302. router: filterRouter,
  303. });
  304. await userEvent.click(await screen.findByRole('button', {name: 'Filter'}));
  305. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  306. filterRouter.location.query = {query: 'role:member'};
  307. rerender(<OrganizationMembersList />);
  308. expect(searchMock).toHaveBeenLastCalledWith(
  309. '/organizations/org-slug/members/',
  310. expect.objectContaining({
  311. method: 'GET',
  312. query: {query: 'role:member'},
  313. })
  314. );
  315. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  316. for (const [filter, label] of [
  317. ['isInvited', 'Invited'],
  318. ['has2fa', '2FA'],
  319. ['ssoLinked', 'SSO Linked'],
  320. ]) {
  321. const filterSection = screen.getByRole('listbox', {name: label});
  322. await userEvent.click(
  323. within(filterSection).getByRole('option', {
  324. name: 'True',
  325. })
  326. );
  327. filterRouter.location.query = {query: `${filter}:true`};
  328. rerender(<OrganizationMembersList />);
  329. expect(searchMock).toHaveBeenLastCalledWith(
  330. '/organizations/org-slug/members/',
  331. expect.objectContaining({
  332. method: 'GET',
  333. query: {query: `${filter}:true`},
  334. })
  335. );
  336. await userEvent.click(
  337. within(filterSection).getByRole('option', {
  338. name: 'False',
  339. })
  340. );
  341. filterRouter.location.query = {query: `${filter}:false`};
  342. rerender(<OrganizationMembersList />);
  343. expect(searchMock).toHaveBeenLastCalledWith(
  344. '/organizations/org-slug/members/',
  345. expect.objectContaining({
  346. method: 'GET',
  347. query: {query: `${filter}:false`},
  348. })
  349. );
  350. await userEvent.click(
  351. within(filterSection).getByRole('option', {
  352. name: 'All',
  353. })
  354. );
  355. }
  356. });
  357. describe('OrganizationInviteRequests', function () {
  358. const inviteRequest = MemberFixture({
  359. id: '123',
  360. user: null,
  361. inviteStatus: 'requested_to_be_invited',
  362. inviterName: UserFixture().name,
  363. role: 'member',
  364. teams: [],
  365. });
  366. const joinRequest = MemberFixture({
  367. id: '456',
  368. user: null,
  369. email: 'test@gmail.com',
  370. inviteStatus: 'requested_to_join',
  371. role: 'member',
  372. teams: [],
  373. });
  374. it('disable buttons for no access', async function () {
  375. const org = OrganizationFixture({
  376. status: {
  377. id: 'active',
  378. name: 'active',
  379. },
  380. });
  381. MockApiClient.addMockResponse({
  382. url: '/organizations/org-slug/invite-requests/',
  383. method: 'GET',
  384. body: [inviteRequest],
  385. });
  386. MockApiClient.addMockResponse({
  387. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  388. method: 'PUT',
  389. });
  390. render(<OrganizationMembersList />, {organization: org});
  391. expect(await screen.findByText('Pending Members')).toBeInTheDocument();
  392. expect(screen.getByRole('button', {name: 'Approve'})).toBeDisabled();
  393. });
  394. it('can approve invite request and update', async function () {
  395. const org = OrganizationFixture({
  396. access: ['member:admin', 'org:admin', 'member:write'],
  397. status: {
  398. id: 'active',
  399. name: 'active',
  400. },
  401. });
  402. MockApiClient.addMockResponse({
  403. url: '/organizations/org-slug/invite-requests/',
  404. method: 'GET',
  405. body: [inviteRequest],
  406. });
  407. MockApiClient.addMockResponse({
  408. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  409. method: 'PUT',
  410. });
  411. render(<OrganizationMembersList />, {organization, router});
  412. expect(await screen.findByText('Pending Members')).toBeInTheDocument();
  413. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  414. renderGlobalModal({router});
  415. await userEvent.click(screen.getByTestId('confirm-button'));
  416. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  417. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.approved', {
  418. invite_status: inviteRequest.inviteStatus,
  419. member_id: parseInt(inviteRequest.id, 10),
  420. organization: org,
  421. });
  422. });
  423. it('can deny invite request and remove', async function () {
  424. const org = OrganizationFixture({
  425. access: ['member:admin', 'org:admin', 'member:write'],
  426. status: {
  427. id: 'active',
  428. name: 'active',
  429. },
  430. });
  431. MockApiClient.addMockResponse({
  432. url: '/organizations/org-slug/invite-requests/',
  433. method: 'GET',
  434. body: [joinRequest],
  435. });
  436. MockApiClient.addMockResponse({
  437. url: `/organizations/org-slug/invite-requests/${joinRequest.id}/`,
  438. method: 'DELETE',
  439. });
  440. render(<OrganizationMembersList />, {organization});
  441. expect(await screen.findByText('Pending Members')).toBeInTheDocument();
  442. await userEvent.click(screen.getByRole('button', {name: 'Deny'}));
  443. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  444. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.denied', {
  445. invite_status: joinRequest.inviteStatus,
  446. member_id: parseInt(joinRequest.id, 10),
  447. organization: org,
  448. });
  449. });
  450. it('can update invite requests', async function () {
  451. const org = OrganizationFixture({
  452. access: ['member:admin', 'org:admin', 'member:write'],
  453. status: {
  454. id: 'active',
  455. name: 'active',
  456. },
  457. });
  458. MockApiClient.addMockResponse({
  459. url: '/organizations/org-slug/invite-requests/',
  460. method: 'GET',
  461. body: [inviteRequest],
  462. });
  463. const updateWithApprove = MockApiClient.addMockResponse({
  464. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  465. method: 'PUT',
  466. });
  467. render(<OrganizationMembersList />, {organization: org, router});
  468. expect(await screen.findByText('Pending Members')).toBeInTheDocument();
  469. await selectEvent.select(screen.getByRole('textbox', {name: 'Role: Member'}), [
  470. 'Admin',
  471. ]);
  472. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  473. renderGlobalModal({router});
  474. await userEvent.click(screen.getByTestId('confirm-button'));
  475. expect(updateWithApprove).toHaveBeenCalledWith(
  476. `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  477. expect.objectContaining({data: expect.objectContaining({role: 'admin'})})
  478. );
  479. });
  480. });
  481. describe('Org Access Requests', function () {
  482. it('can invite member', async function () {
  483. const inviteOrg = OrganizationFixture({
  484. features: ['invite-members'],
  485. access: ['member:admin', 'org:admin', 'member:write'],
  486. status: {
  487. id: 'active',
  488. name: 'active',
  489. },
  490. });
  491. render(<OrganizationMembersList />, {organization: inviteOrg, router});
  492. renderGlobalModal({router});
  493. await userEvent.click(await screen.findByRole('button', {name: 'Invite Members'}));
  494. expect(screen.getByRole('dialog')).toBeInTheDocument();
  495. });
  496. it('can not invite members without the invite-members feature', async function () {
  497. const org = OrganizationFixture({
  498. features: [],
  499. access: ['member:admin', 'org:admin', 'member:write'],
  500. status: {
  501. id: 'active',
  502. name: 'active',
  503. },
  504. });
  505. render(<OrganizationMembersList />, {organization: org, router});
  506. renderGlobalModal({router});
  507. expect(await screen.findByRole('button', {name: 'Invite Members'})).toBeDisabled();
  508. });
  509. it('cannot invite members if SSO is required', async function () {
  510. const org = OrganizationFixture({
  511. features: ['invite-members'],
  512. access: [],
  513. status: {
  514. id: 'active',
  515. name: 'active',
  516. },
  517. requiresSso: true,
  518. });
  519. render(<OrganizationMembersList />, {organization: org, router});
  520. renderGlobalModal({router});
  521. await userEvent.click(screen.getByRole('button', {name: 'Invite Members'}));
  522. expect(screen.queryByRole('dialog')).not.toBeInTheDocument();
  523. });
  524. it('can invite without permissions', async function () {
  525. const org = OrganizationFixture({
  526. features: ['invite-members'],
  527. access: [],
  528. status: {
  529. id: 'active',
  530. name: 'active',
  531. },
  532. });
  533. render(<OrganizationMembersList />, {organization: org, router});
  534. renderGlobalModal({router});
  535. await userEvent.click(await screen.findByRole('button', {name: 'Invite Members'}));
  536. expect(screen.getByRole('dialog')).toBeInTheDocument();
  537. });
  538. it('renders member list', async function () {
  539. MockApiClient.addMockResponse({
  540. url: '/organizations/org-slug/members/',
  541. method: 'GET',
  542. body: [member],
  543. });
  544. MockApiClient.addMockResponse({
  545. url: '/organizations/org-slug/prompts-activity/',
  546. method: 'GET',
  547. body: {},
  548. });
  549. render(<OrganizationMembersList />, {organization, router});
  550. renderGlobalModal({router});
  551. expect(await screen.findByText('Members')).toBeInTheDocument();
  552. expect(screen.getByText(member.name)).toBeInTheDocument();
  553. });
  554. });
  555. });