issueViewsHeader.tsx 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456
  1. import {useContext, useEffect, useMemo, useState} from 'react';
  2. import styled from '@emotion/styled';
  3. import type {Node} from '@react-types/shared';
  4. import {addSuccessMessage} from 'sentry/actionCreators/indicator';
  5. import {Button} from 'sentry/components/button';
  6. import ButtonBar from 'sentry/components/buttonBar';
  7. import {
  8. DraggableTabList,
  9. TEMPORARY_TAB_KEY,
  10. } from 'sentry/components/draggableTabs/draggableTabList';
  11. import type {DraggableTabListItemProps} from 'sentry/components/draggableTabs/item';
  12. import GlobalEventProcessingAlert from 'sentry/components/globalEventProcessingAlert';
  13. import * as Layout from 'sentry/components/layouts/thirds';
  14. import {normalizeDateTimeParams} from 'sentry/components/organizations/pageFilters/parse';
  15. import {PageHeadingQuestionTooltip} from 'sentry/components/pageHeadingQuestionTooltip';
  16. import {IconMegaphone, IconPause, IconPlay} from 'sentry/icons';
  17. import {t} from 'sentry/locale';
  18. import {space} from 'sentry/styles/space';
  19. import type {InjectedRouter} from 'sentry/types/legacyReactRouter';
  20. import {trackAnalytics} from 'sentry/utils/analytics';
  21. import normalizeUrl from 'sentry/utils/url/normalizeUrl';
  22. import {useFeedbackForm} from 'sentry/utils/useFeedbackForm';
  23. import {useHotkeys} from 'sentry/utils/useHotkeys';
  24. import {useLocation} from 'sentry/utils/useLocation';
  25. import {useNavigate} from 'sentry/utils/useNavigate';
  26. import useOrganization from 'sentry/utils/useOrganization';
  27. import usePageFilters from 'sentry/utils/usePageFilters';
  28. import useProjects from 'sentry/utils/useProjects';
  29. import {useUser} from 'sentry/utils/useUser';
  30. import {
  31. generateTempViewId,
  32. type IssueView,
  33. type IssueViewParams,
  34. IssueViews,
  35. IssueViewsContext,
  36. } from 'sentry/views/issueList/issueViews/issueViews';
  37. import {IssueViewTab} from 'sentry/views/issueList/issueViews/issueViewTab';
  38. import {useFetchGroupSearchViews} from 'sentry/views/issueList/queries/useFetchGroupSearchViews';
  39. import {NewTabContext} from 'sentry/views/issueList/utils/newTabContext';
  40. import {IssueSortOptions} from './utils';
  41. type IssueViewsIssueListHeaderProps = {
  42. onRealtimeChange: (realtime: boolean) => void;
  43. realtimeActive: boolean;
  44. router: InjectedRouter;
  45. selectedProjectIds: number[];
  46. };
  47. type IssueViewsIssueListHeaderTabsContentProps = {
  48. router: InjectedRouter;
  49. };
  50. function IssueViewsIssueListHeader({
  51. selectedProjectIds,
  52. realtimeActive,
  53. onRealtimeChange,
  54. router,
  55. }: IssueViewsIssueListHeaderProps) {
  56. const organization = useOrganization();
  57. const {projects} = useProjects();
  58. const selectedProjects = projects.filter(({id}) =>
  59. selectedProjectIds.includes(Number(id))
  60. );
  61. const {newViewActive} = useContext(NewTabContext);
  62. const {data: groupSearchViews} = useFetchGroupSearchViews({
  63. orgSlug: organization.slug,
  64. });
  65. const realtimeTitle = realtimeActive
  66. ? t('Pause real-time updates')
  67. : t('Enable real-time updates');
  68. const openForm = useFeedbackForm();
  69. const hasNewLayout = organization.features.includes('issue-stream-table-layout');
  70. return (
  71. <Layout.Header
  72. noActionWrap
  73. // No viewId in the URL query means that a temp view is selected, which has a dashed border
  74. borderStyle={
  75. groupSearchViews && !router?.location.query.viewId ? 'dashed' : 'solid'
  76. }
  77. >
  78. <Layout.HeaderContent>
  79. <Layout.Title>
  80. {t('Issues')}
  81. <PageHeadingQuestionTooltip
  82. docsUrl="https://docs.sentry.io/product/issues/"
  83. title={t(
  84. 'Detailed views of errors and performance problems in your application grouped by events with a similar set of characteristics.'
  85. )}
  86. />
  87. </Layout.Title>
  88. </Layout.HeaderContent>
  89. <Layout.HeaderActions>
  90. <ButtonBar gap={1}>
  91. {openForm && hasNewLayout && (
  92. <Button
  93. size="sm"
  94. aria-label="issue-stream-feedback"
  95. icon={<IconMegaphone />}
  96. onClick={() =>
  97. openForm({
  98. messagePlaceholder: t(
  99. 'How can we make the issue stream better for you?'
  100. ),
  101. tags: {
  102. ['feedback.source']: 'new_issue_stream_layout',
  103. ['feedback.owner']: 'issues',
  104. },
  105. })
  106. }
  107. >
  108. {t('Give Feedback')}
  109. </Button>
  110. )}
  111. {!newViewActive && (
  112. <Button
  113. size="sm"
  114. data-test-id="real-time"
  115. title={realtimeTitle}
  116. aria-label={realtimeTitle}
  117. icon={realtimeActive ? <IconPause /> : <IconPlay />}
  118. onClick={() => onRealtimeChange(!realtimeActive)}
  119. />
  120. )}
  121. </ButtonBar>
  122. </Layout.HeaderActions>
  123. <StyledGlobalEventProcessingAlert projects={selectedProjects} />
  124. {groupSearchViews ? (
  125. <StyledIssueViews
  126. router={router}
  127. initialViews={groupSearchViews.map(
  128. (
  129. {id, name, query: viewQuery, querySort: viewQuerySort},
  130. index
  131. ): IssueView => {
  132. const tabId = id ?? `default${index.toString()}`;
  133. return {
  134. id: tabId,
  135. key: tabId,
  136. label: name,
  137. query: viewQuery,
  138. querySort: viewQuerySort,
  139. isCommitted: true,
  140. };
  141. }
  142. )}
  143. >
  144. <IssueViewsIssueListHeaderTabsContent router={router} />
  145. </StyledIssueViews>
  146. ) : (
  147. <div style={{height: 33}} />
  148. )}
  149. </Layout.Header>
  150. );
  151. }
  152. function IssueViewsIssueListHeaderTabsContent({
  153. router,
  154. }: IssueViewsIssueListHeaderTabsContentProps) {
  155. const organization = useOrganization();
  156. const navigate = useNavigate();
  157. const location = useLocation();
  158. const pageFilters = usePageFilters();
  159. const user = useUser();
  160. const {newViewActive, setNewViewActive} = useContext(NewTabContext);
  161. const {tabListState, state, dispatch} = useContext(IssueViewsContext);
  162. const {views, tempView} = state;
  163. const [editingTabKey, setEditingTabKey] = useState<string | null>(null);
  164. // TODO(msun): Use the location from useLocation instead of props router in the future
  165. const {cursor: _cursor, page: _page, ...queryParams} = router?.location.query;
  166. const {query, sort, viewId, project, environment} = queryParams;
  167. const queryParamsWithPageFilters = useMemo(() => {
  168. return {
  169. ...queryParams,
  170. project: project ?? pageFilters.selection.projects,
  171. environment: environment ?? pageFilters.selection.environments,
  172. ...normalizeDateTimeParams(pageFilters.selection.datetime),
  173. };
  174. }, [
  175. environment,
  176. pageFilters.selection.datetime,
  177. pageFilters.selection.environments,
  178. pageFilters.selection.projects,
  179. project,
  180. queryParams,
  181. ]);
  182. // This useEffect is here temporarily to start saving user's most recently used page filters
  183. // to their views. This will be removed once the frontend is updated to use a view's page filters
  184. useEffect(() => {
  185. dispatch({type: 'SYNC_VIEWS_TO_BACKEND'});
  186. trackAnalytics('issue_views.page_filters_logged', {
  187. user_id: user.id,
  188. organization,
  189. });
  190. // eslint-disable-next-line react-hooks/exhaustive-deps
  191. }, [pageFilters.selection]);
  192. // This insane useEffect ensures that the correct tab is selected when the url updates
  193. useEffect(() => {
  194. // If no query, sort, or viewId is present, set the first tab as the selected tab, update query accordingly
  195. if (!query && !sort && !viewId) {
  196. navigate(
  197. normalizeUrl({
  198. ...location,
  199. query: {
  200. ...queryParamsWithPageFilters,
  201. query: views[0]!.query,
  202. sort: views[0]!.querySort,
  203. viewId: views[0]!.id,
  204. },
  205. }),
  206. {replace: true}
  207. );
  208. tabListState?.setSelectedKey(views[0]!.key);
  209. return;
  210. }
  211. // if a viewId is present, check the frontend is aware of a view with that id.
  212. if (viewId) {
  213. const selectedView = views.find(tab => tab.id === viewId);
  214. if (selectedView) {
  215. // If the frontend is aware of a view with that id, check if the query/sort is different
  216. // from the view's original query/sort.
  217. const {query: originalQuery, querySort: originalSort} = selectedView;
  218. const issueSortOption = Object.values(IssueSortOptions).includes(sort)
  219. ? sort
  220. : IssueSortOptions.DATE;
  221. const newUnsavedChanges: IssueViewParams | undefined =
  222. query === originalQuery && sort === originalSort
  223. ? undefined
  224. : {
  225. query,
  226. querySort: issueSortOption,
  227. };
  228. if (
  229. (newUnsavedChanges && !selectedView.unsavedChanges) ||
  230. selectedView.unsavedChanges?.query !== newUnsavedChanges?.query ||
  231. selectedView.unsavedChanges?.querySort !== newUnsavedChanges?.querySort
  232. ) {
  233. // If there were no unsaved changes before, or the existing unsaved changes
  234. // don't match the new query and/or sort, update the unsaved changes
  235. dispatch({
  236. type: 'UPDATE_UNSAVED_CHANGES',
  237. unsavedChanges: newUnsavedChanges,
  238. });
  239. } else if (!newUnsavedChanges && selectedView.unsavedChanges) {
  240. // If the query/sort are the same as the original query/sort, remove any unsaved changes
  241. dispatch({type: 'UPDATE_UNSAVED_CHANGES', unsavedChanges: undefined});
  242. }
  243. if (!tabListState?.selectionManager.isSelected(selectedView.key)) {
  244. navigate(
  245. normalizeUrl({
  246. ...location,
  247. query: {
  248. ...queryParamsWithPageFilters,
  249. query: newUnsavedChanges?.query ?? selectedView.query,
  250. sort: newUnsavedChanges?.querySort ?? selectedView.querySort,
  251. viewId: selectedView.id,
  252. },
  253. }),
  254. {replace: true}
  255. );
  256. tabListState?.setSelectedKey(selectedView.key);
  257. }
  258. } else {
  259. // if a viewId does not exist, remove it from the query
  260. tabListState?.setSelectedKey(TEMPORARY_TAB_KEY);
  261. navigate(
  262. normalizeUrl({
  263. ...location,
  264. query: {
  265. ...queryParamsWithPageFilters,
  266. viewId: undefined,
  267. },
  268. }),
  269. {replace: true}
  270. );
  271. trackAnalytics('issue_views.shared_view_opened', {
  272. organization,
  273. query,
  274. });
  275. }
  276. return;
  277. }
  278. if (query) {
  279. if (!tabListState?.selectionManager.isSelected(TEMPORARY_TAB_KEY)) {
  280. dispatch({type: 'SET_TEMP_VIEW', query, sort});
  281. navigate(
  282. normalizeUrl({
  283. ...location,
  284. query: {
  285. ...queryParamsWithPageFilters,
  286. viewId: undefined,
  287. },
  288. }),
  289. {replace: true}
  290. );
  291. tabListState?.setSelectedKey(TEMPORARY_TAB_KEY);
  292. return;
  293. }
  294. }
  295. }, [
  296. navigate,
  297. organization.slug,
  298. query,
  299. sort,
  300. viewId,
  301. tabListState,
  302. location,
  303. queryParamsWithPageFilters,
  304. views,
  305. organization,
  306. dispatch,
  307. ]);
  308. // This useEffect ensures the "new view" page is displayed/hidden correctly
  309. useEffect(() => {
  310. if (viewId?.startsWith('_')) {
  311. if (views.find(tab => tab.id === viewId)?.isCommitted) {
  312. return;
  313. }
  314. // If the user types in query manually while the new view flow is showing,
  315. // then replace the add view flow with the issue stream with the query loaded,
  316. // and persist the query
  317. if (newViewActive && query !== '') {
  318. setNewViewActive(false);
  319. dispatch({
  320. type: 'UPDATE_UNSAVED_CHANGES',
  321. unsavedChanges: {query, querySort: sort ?? IssueSortOptions.DATE},
  322. isCommitted: true,
  323. syncViews: true,
  324. });
  325. trackAnalytics('issue_views.add_view.custom_query_saved', {
  326. organization,
  327. query,
  328. });
  329. } else {
  330. setNewViewActive(true);
  331. }
  332. } else {
  333. setNewViewActive(false);
  334. }
  335. // eslint-disable-next-line react-hooks/exhaustive-deps
  336. }, [viewId, query]);
  337. useHotkeys(
  338. [
  339. {
  340. match: ['command+s', 'ctrl+s'],
  341. includeInputs: true,
  342. callback: () => {
  343. if (views.find(tab => tab.key === tabListState?.selectedKey)?.unsavedChanges) {
  344. dispatch({type: 'SAVE_CHANGES', syncViews: true});
  345. addSuccessMessage(t('Changes saved to view'));
  346. }
  347. },
  348. },
  349. ],
  350. [dispatch, tabListState?.selectedKey, views]
  351. );
  352. const handleCreateNewView = () => {
  353. const tempId = generateTempViewId();
  354. dispatch({type: 'CREATE_NEW_VIEW', tempId});
  355. tabListState?.setSelectedKey(tempId);
  356. navigate({
  357. ...location,
  358. query: {
  359. ...queryParams,
  360. query: '',
  361. viewId: tempId,
  362. },
  363. });
  364. };
  365. const allTabs = tempView ? [...views, tempView] : views;
  366. const initialTabKey =
  367. viewId && views.find(tab => tab.id === viewId)
  368. ? views.find(tab => tab.id === viewId)!.key
  369. : query
  370. ? TEMPORARY_TAB_KEY
  371. : views[0]!.key;
  372. return (
  373. <DraggableTabList
  374. onReorder={(newOrder: Array<Node<DraggableTabListItemProps>>) =>
  375. dispatch({
  376. type: 'REORDER_TABS',
  377. newKeyOrder: newOrder.map(node => node.key.toString()),
  378. })
  379. }
  380. onReorderComplete={() => dispatch({type: 'SYNC_VIEWS_TO_BACKEND'})}
  381. defaultSelectedKey={initialTabKey}
  382. onAddView={handleCreateNewView}
  383. orientation="horizontal"
  384. editingTabKey={editingTabKey ?? undefined}
  385. hideBorder
  386. >
  387. {allTabs.map(view => (
  388. <DraggableTabList.Item
  389. textValue={view.label}
  390. key={view.key}
  391. to={normalizeUrl({
  392. query: {
  393. ...queryParams,
  394. query: view.unsavedChanges?.query ?? view.query,
  395. sort: view.unsavedChanges?.querySort ?? view.querySort,
  396. viewId: view.id !== TEMPORARY_TAB_KEY ? view.id : undefined,
  397. },
  398. pathname: `/organizations/${organization.slug}/issues/`,
  399. })}
  400. disabled={view.key === editingTabKey}
  401. >
  402. <IssueViewTab
  403. key={view.key}
  404. view={view}
  405. initialTabKey={initialTabKey}
  406. router={router}
  407. editingTabKey={editingTabKey}
  408. setEditingTabKey={setEditingTabKey}
  409. />
  410. </DraggableTabList.Item>
  411. ))}
  412. </DraggableTabList>
  413. );
  414. }
  415. export default IssueViewsIssueListHeader;
  416. const StyledIssueViews = styled(IssueViews)`
  417. grid-column: 1 / -1;
  418. `;
  419. const StyledGlobalEventProcessingAlert = styled(GlobalEventProcessingAlert)`
  420. grid-column: 1/-1;
  421. margin-top: ${space(1)};
  422. margin-bottom: ${space(1)};
  423. @media (min-width: ${p => p.theme.breakpoints.medium}) {
  424. margin-top: ${space(2)};
  425. margin-bottom: 0;
  426. }
  427. `;