groupEvents.spec.tsx 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410
  1. import {GroupFixture} from 'sentry-fixture/group';
  2. import {LocationFixture} from 'sentry-fixture/locationFixture';
  3. import {OrganizationFixture} from 'sentry-fixture/organization';
  4. import {RouterFixture} from 'sentry-fixture/routerFixture';
  5. import {
  6. render,
  7. screen,
  8. userEvent,
  9. waitFor,
  10. waitForElementToBeRemoved,
  11. } from 'sentry-test/reactTestingLibrary';
  12. import {type Group, IssueCategory} from 'sentry/types/group';
  13. import type {Organization} from 'sentry/types/organization';
  14. import GroupEvents from 'sentry/views/issueDetails/groupEvents';
  15. describe('groupEvents', () => {
  16. const requests: {[requestName: string]: jest.Mock} = {};
  17. let group!: Group;
  18. let organization: Organization;
  19. let router: ReturnType<typeof RouterFixture>;
  20. beforeEach(() => {
  21. group = GroupFixture();
  22. organization = OrganizationFixture({features: ['event-attachments']});
  23. router = RouterFixture({
  24. params: {orgId: 'org-slug', groupId: group.id},
  25. location: LocationFixture({
  26. pathname: '/organizations/org-slug/issues/123/events/',
  27. action: 'REPLACE',
  28. key: 'okjkey',
  29. query: {
  30. query: '',
  31. },
  32. }),
  33. });
  34. requests.discover = MockApiClient.addMockResponse({
  35. url: '/organizations/org-slug/events/',
  36. headers: {
  37. Link: `<https://sentry.io/api/0/issues/1/events/?limit=50&cursor=0:0:1>; rel="previous"; results="true"; cursor="0:0:1", <https://sentry.io/api/0/issues/1/events/?limit=50&cursor=0:200:0>; rel="next"; results="true"; cursor="0:200:0"`,
  38. },
  39. body: {
  40. data: [
  41. {
  42. timestamp: '2022-09-11T15:01:10+00:00',
  43. transaction: '/api',
  44. release: 'backend@1.2.3',
  45. 'transaction.duration': 1803,
  46. environment: 'prod',
  47. 'user.display': 'sentry@sentry.sentry',
  48. id: 'id123',
  49. trace: 'trace123',
  50. 'project.name': 'project123',
  51. },
  52. ],
  53. meta: {
  54. fields: {
  55. timestamp: 'date',
  56. transaction: 'string',
  57. release: 'string',
  58. 'transaction.duration': 'duration',
  59. environment: 'string',
  60. 'user.display': 'string',
  61. id: 'string',
  62. trace: 'string',
  63. 'project.name': 'string',
  64. },
  65. units: {
  66. timestamp: null,
  67. transaction: null,
  68. release: null,
  69. 'transaction.duration': 'millisecond',
  70. environment: null,
  71. 'user.display': null,
  72. id: null,
  73. trace: null,
  74. 'project.name': null,
  75. },
  76. isMetricsData: false,
  77. tips: {query: null, columns: null},
  78. },
  79. },
  80. });
  81. requests.attachments = MockApiClient.addMockResponse({
  82. url: '/api/0/issues/1/attachments/?per_page=50&types=event.minidump&event_id=id123',
  83. body: [],
  84. });
  85. requests.recentSearches = MockApiClient.addMockResponse({
  86. method: 'POST',
  87. url: '/organizations/org-slug/recent-searches/',
  88. body: [],
  89. });
  90. requests.latestEvent = MockApiClient.addMockResponse({
  91. method: 'GET',
  92. url: '/issues/1/events/latest/',
  93. body: {},
  94. });
  95. requests.tags = MockApiClient.addMockResponse({
  96. method: 'GET',
  97. url: '/organizations/org-slug/issues/1/tags/',
  98. body: [],
  99. });
  100. MockApiClient.addMockResponse({
  101. url: `/organizations/org-slug/issues/${group.id}/`,
  102. body: group,
  103. });
  104. });
  105. afterEach(() => {
  106. MockApiClient.clearMockResponses();
  107. jest.clearAllMocks();
  108. });
  109. it('fetches and renders a table of events', async () => {
  110. render(<GroupEvents />, {router, organization});
  111. expect(await screen.findByText('id123')).toBeInTheDocument();
  112. // Transaction
  113. expect(screen.getByText('/api')).toBeInTheDocument();
  114. // Environment
  115. expect(screen.getByText('prod')).toBeInTheDocument();
  116. // Release
  117. expect(screen.getByText('1.2.3')).toBeInTheDocument();
  118. // User email
  119. expect(screen.getByText('sentry@sentry.sentry')).toBeInTheDocument();
  120. });
  121. it('pushes new query parameter when searching', async () => {
  122. render(<GroupEvents />, {organization, router});
  123. const input = await screen.findByPlaceholderText('Search events\u2026');
  124. await userEvent.click(input);
  125. await userEvent.keyboard('foo');
  126. await userEvent.keyboard('{enter}');
  127. await waitFor(() => {
  128. expect(router.push).toHaveBeenCalledWith(
  129. expect.objectContaining({
  130. query: {query: 'foo'},
  131. })
  132. );
  133. });
  134. });
  135. it('displays event filters and tags', async () => {
  136. MockApiClient.addMockResponse({
  137. url: '/organizations/org-slug/issues/1/tags/',
  138. body: [{key: 'custom_tag', name: 'custom_tag', totalValues: 1}],
  139. });
  140. render(<GroupEvents />, {organization, router});
  141. const input = await screen.findByPlaceholderText('Search events\u2026');
  142. await userEvent.click(input);
  143. expect(
  144. await screen.findByRole('button', {name: 'Event Filters'})
  145. ).toBeInTheDocument();
  146. expect(screen.getByRole('button', {name: 'Event Tags'})).toBeInTheDocument();
  147. // Should show custom_tag fetched from group tags
  148. expect(screen.getByRole('option', {name: 'custom_tag'})).toBeInTheDocument();
  149. // Should hardcoded event filters
  150. expect(screen.getByRole('option', {name: 'event.type'})).toBeInTheDocument();
  151. });
  152. it('handles environment filtering', async () => {
  153. router.location.query.environment = ['prod', 'staging'];
  154. render(<GroupEvents />, {router, organization});
  155. await waitFor(() => {
  156. expect(requests.discover).toHaveBeenCalledWith(
  157. '/organizations/org-slug/events/',
  158. expect.objectContaining({
  159. query: expect.objectContaining({environment: ['prod', 'staging']}),
  160. })
  161. );
  162. });
  163. expect(await screen.findByText('Transaction')).toBeInTheDocument();
  164. });
  165. it('renders events table for performance issue', async () => {
  166. group.issueCategory = IssueCategory.PERFORMANCE;
  167. router.location.query.environment = ['prod', 'staging'];
  168. render(<GroupEvents />, {router, organization});
  169. await waitFor(() => {
  170. expect(requests.discover).toHaveBeenCalledWith(
  171. '/organizations/org-slug/events/',
  172. expect.objectContaining({
  173. query: expect.objectContaining({
  174. query: 'performance.issue_ids:1 event.type:transaction ',
  175. }),
  176. })
  177. );
  178. });
  179. expect(await screen.findByText('Transaction')).toBeInTheDocument();
  180. });
  181. it('renders event and trace link correctly', async () => {
  182. group.issueCategory = IssueCategory.PERFORMANCE;
  183. router.location.query.environment = ['prod', 'staging'];
  184. render(<GroupEvents />, {router, organization});
  185. const eventIdATag = (await screen.findByText('id123')).closest('a');
  186. expect(eventIdATag).toHaveAttribute(
  187. 'href',
  188. '/organizations/org-slug/issues/1/events/id123/'
  189. );
  190. });
  191. it('does not make attachments request, async when feature not enabled', async () => {
  192. router.location.query.environment = ['prod', 'staging'];
  193. render(<GroupEvents />, {router, organization: {...organization, features: []}});
  194. await waitForElementToBeRemoved(() => screen.queryByTestId('loading-indicator'));
  195. const attachmentsColumn = screen.queryByText('Attachments');
  196. expect(attachmentsColumn).not.toBeInTheDocument();
  197. expect(requests.attachments).not.toHaveBeenCalled();
  198. });
  199. it('does not display attachments column with no attachments', async () => {
  200. router.location.query.environment = ['prod', 'staging'];
  201. render(<GroupEvents />, {router, organization});
  202. await waitForElementToBeRemoved(() => screen.queryByTestId('loading-indicator'));
  203. const attachmentsColumn = screen.queryByText('Attachments');
  204. expect(attachmentsColumn).not.toBeInTheDocument();
  205. expect(requests.attachments).toHaveBeenCalled();
  206. });
  207. it('does not display minidump column with no minidumps', async () => {
  208. router.location.query.environment = ['prod', 'staging'];
  209. render(<GroupEvents />, {router, organization});
  210. await waitForElementToBeRemoved(() => screen.queryByTestId('loading-indicator'));
  211. const minidumpColumn = screen.queryByText('Minidump');
  212. expect(minidumpColumn).not.toBeInTheDocument();
  213. });
  214. it('displays minidumps', async () => {
  215. requests.attachments = MockApiClient.addMockResponse({
  216. url: '/api/0/issues/1/attachments/?per_page=50&types=event.minidump&event_id=id123',
  217. body: [
  218. {
  219. id: 'id123',
  220. name: 'dc42a8b9-fc22-4de1-8a29-45b3006496d8.dmp',
  221. headers: {
  222. 'Content-Type': 'application/octet-stream',
  223. },
  224. mimetype: 'application/octet-stream',
  225. size: 1294340,
  226. sha1: '742127552a1191f71fcf6ba7bc5afa0a837350e2',
  227. dateCreated: '2022-09-28T09:04:38.659307Z',
  228. type: 'event.minidump',
  229. event_id: 'd54cb9246ee241ffbdb39bf7a9fafbb7',
  230. },
  231. ],
  232. });
  233. render(<GroupEvents />, {router, organization});
  234. const minidumpColumn = await screen.findByText('Minidump');
  235. expect(minidumpColumn).toBeInTheDocument();
  236. });
  237. it('does not display attachments but displays minidump', async () => {
  238. requests.attachments = MockApiClient.addMockResponse({
  239. url: '/api/0/issues/1/attachments/?per_page=50&types=event.minidump&event_id=id123',
  240. body: [
  241. {
  242. id: 'id123',
  243. name: 'dc42a8b9-fc22-4de1-8a29-45b3006496d8.dmp',
  244. headers: {
  245. 'Content-Type': 'application/octet-stream',
  246. },
  247. mimetype: 'application/octet-stream',
  248. size: 1294340,
  249. sha1: '742127552a1191f71fcf6ba7bc5afa0a837350e2',
  250. dateCreated: '2022-09-28T09:04:38.659307Z',
  251. type: 'event.minidump',
  252. event_id: 'd54cb9246ee241ffbdb39bf7a9fafbb7',
  253. },
  254. ],
  255. });
  256. router.location.query.environment = ['prod', 'staging'];
  257. render(<GroupEvents />, {router, organization});
  258. await waitForElementToBeRemoved(() => screen.queryByTestId('loading-indicator'));
  259. const minidumpColumn = await screen.findByText('Minidump');
  260. expect(minidumpColumn).toBeInTheDocument();
  261. const attachmentsColumn = screen.queryByText('Attachments');
  262. expect(attachmentsColumn).not.toBeInTheDocument();
  263. expect(requests.attachments).toHaveBeenCalled();
  264. });
  265. it('renders events table for error', async () => {
  266. router.location.query.environment = ['prod', 'staging'];
  267. render(<GroupEvents />, {router, organization});
  268. await waitFor(() => {
  269. expect(requests.discover).toHaveBeenCalledWith(
  270. '/organizations/org-slug/events/',
  271. expect.objectContaining({
  272. query: expect.objectContaining({
  273. query: 'issue.id:1 ',
  274. field: expect.not.arrayContaining(['attachments', 'minidump']),
  275. }),
  276. })
  277. );
  278. });
  279. await waitFor(() => {
  280. expect(screen.getByText('Transaction')).toBeInTheDocument();
  281. });
  282. });
  283. it('removes sort if unsupported by the events table', async () => {
  284. router.location.query = {
  285. ...router.location.query,
  286. environment: ['prod', 'staging'],
  287. sort: 'user',
  288. };
  289. render(<GroupEvents />, {router, organization});
  290. await waitFor(() => {
  291. expect(requests.discover).toHaveBeenCalledWith(
  292. '/organizations/org-slug/events/',
  293. expect.objectContaining({query: expect.not.objectContaining({sort: 'user'})})
  294. );
  295. });
  296. await waitFor(() => {
  297. expect(screen.getByText('Transaction')).toBeInTheDocument();
  298. });
  299. });
  300. it('only request for a single projectId', async () => {
  301. router.location.query = {
  302. ...router.location.query,
  303. environment: ['prod', 'staging'],
  304. sort: 'user',
  305. project: [group.project.id, '456'],
  306. };
  307. render(<GroupEvents />, {router, organization});
  308. await waitFor(() => {
  309. expect(requests.discover).toHaveBeenCalledWith(
  310. '/organizations/org-slug/events/',
  311. expect.objectContaining({
  312. query: expect.objectContaining({project: [group.project.id]}),
  313. })
  314. );
  315. });
  316. await waitFor(() => {
  317. expect(screen.getByText('Transaction')).toBeInTheDocument();
  318. });
  319. });
  320. it('shows discover query error message', async () => {
  321. requests.discover = MockApiClient.addMockResponse({
  322. url: '/organizations/org-slug/events/',
  323. statusCode: 500,
  324. body: {
  325. detail: 'Internal Error',
  326. errorId: '69ab396e73704cdba9342ff8dcd59795',
  327. },
  328. });
  329. router.location.query.environment = ['prod', 'staging'];
  330. render(<GroupEvents />, {router, organization});
  331. await waitForElementToBeRemoved(() => screen.queryByTestId('loading-indicator'));
  332. expect(screen.getByTestId('loading-error')).toHaveTextContent('Internal Error');
  333. });
  334. it('requests for backend columns if backend project', async () => {
  335. group.project.platform = 'node-express';
  336. router.location.query.environment = ['prod', 'staging'];
  337. render(<GroupEvents />, {router, organization});
  338. await waitForElementToBeRemoved(() => screen.queryByTestId('loading-indicator'));
  339. await waitFor(() => {
  340. expect(requests.discover).toHaveBeenCalledWith(
  341. '/organizations/org-slug/events/',
  342. expect.objectContaining({
  343. query: expect.objectContaining({
  344. field: expect.arrayContaining(['url', 'runtime']),
  345. }),
  346. })
  347. );
  348. });
  349. expect(requests.discover).toHaveBeenCalledWith(
  350. '/organizations/org-slug/events/',
  351. expect.objectContaining({
  352. query: expect.objectContaining({
  353. field: expect.not.arrayContaining(['browser']),
  354. }),
  355. })
  356. );
  357. });
  358. });