123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839 |
- import {GroupFixture} from 'sentry-fixture/group';
- import {OrganizationFixture} from 'sentry-fixture/organization';
- import {ProjectFixture} from 'sentry-fixture/project';
- import {ReleaseFixture} from 'sentry-fixture/release';
- import {RepositoryFixture} from 'sentry-fixture/repository';
- import {TeamFixture} from 'sentry-fixture/team';
- import {UserFixture} from 'sentry-fixture/user';
- import {initializeOrg} from 'sentry-test/initializeOrg';
- import {
- act,
- render,
- renderGlobalModal,
- screen,
- userEvent,
- waitFor,
- } from 'sentry-test/reactTestingLibrary';
- import ConfigStore from 'sentry/stores/configStore';
- import GroupStore from 'sentry/stores/groupStore';
- import OrganizationStore from 'sentry/stores/organizationStore';
- import ProjectsStore from 'sentry/stores/projectsStore';
- import TeamStore from 'sentry/stores/teamStore';
- import type {Group} from 'sentry/types/group';
- import {GroupActivityType, PriorityLevel} from 'sentry/types/group';
- import type {Organization} from 'sentry/types/organization';
- import type {Project} from 'sentry/types/project';
- import GroupActivity from 'sentry/views/issueDetails/groupActivity';
- describe('GroupActivity', function () {
- let project!: Project;
- const dateCreated = '2021-10-01T15:31:38.950115Z';
- beforeEach(function () {
- project = ProjectFixture();
- ProjectsStore.loadInitialData([project]);
- ConfigStore.init();
- ConfigStore.set('user', UserFixture({id: '123'}));
- GroupStore.init();
- });
- afterEach(() => {
- MockApiClient.clearMockResponses();
- jest.clearAllMocks();
- });
- function createWrapper({
- activity,
- organization: additionalOrg,
- }: {
- activity?: Group['activity'];
- organization?: Organization;
- } = {}) {
- const group = GroupFixture({
- id: '1337',
- activity: activity ?? [
- {
- type: GroupActivityType.NOTE,
- id: 'note-1',
- data: {text: 'Test Note'},
- dateCreated: '2020-01-01T00:00:00',
- user: UserFixture(),
- project,
- },
- ],
- project,
- });
- const {organization, routerProps, router} = initializeOrg({
- organization: additionalOrg,
- });
- GroupStore.add([group]);
- TeamStore.loadInitialData([TeamFixture({id: '999', slug: 'no-team'})]);
- OrganizationStore.onUpdate(organization, {replace: true});
- return render(
- <GroupActivity
- {...routerProps}
- params={{orgId: 'org-slug', groupId: group.id}}
- group={group}
- />,
- {router, organization}
- );
- }
- it('renders a NoteInput', function () {
- createWrapper();
- expect(screen.getByTestId('activity-note-body')).toBeInTheDocument();
- });
- it('renders a marked reviewed activity', function () {
- const user = UserFixture({name: 'Samwise'});
- createWrapper({
- activity: [
- {
- type: GroupActivityType.MARK_REVIEWED,
- id: 'reviewed-1',
- dateCreated: '',
- project: ProjectFixture(),
- data: {},
- user,
- },
- ],
- });
- expect(screen.getByText('marked this issue as reviewed')).toBeInTheDocument();
- expect(screen.getByText(user.name)).toBeInTheDocument();
- });
- it('renders a pr activity', function () {
- const user = UserFixture({name: 'Test User'});
- const repository = RepositoryFixture();
- createWrapper({
- activity: [
- {
- dateCreated: '',
- project: ProjectFixture(),
- type: GroupActivityType.SET_RESOLVED_IN_PULL_REQUEST,
- id: 'pr-1',
- data: {
- pullRequest: {
- externalUrl: '',
- id: '',
- title: '',
- repository,
- },
- },
- user,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Test User has created a PR for this issue:'
- );
- });
- it('renders a assigned to self activity', function () {
- const user = UserFixture({id: '123', name: 'Mark'});
- createWrapper({
- activity: [
- {
- data: {
- assignee: user.id,
- assigneeEmail: user.email,
- assigneeType: 'user',
- user,
- },
- user,
- dateCreated: '2021-10-01T15:31:38.950115Z',
- id: '117',
- project: ProjectFixture(),
- type: GroupActivityType.ASSIGNED,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- /Mark assigned this issue to themselves/
- );
- });
- it('renders an assigned via codeowners activity', function () {
- createWrapper({
- activity: [
- {
- data: {
- assignee: '123',
- assigneeEmail: 'anotheruser@sentry.io',
- assigneeType: 'user',
- integration: 'codeowners',
- rule: 'path:something/*.py #workflow',
- user: UserFixture(),
- },
- project: ProjectFixture(),
- dateCreated: '2021-10-01T15:31:38.950115Z',
- id: '117',
- type: GroupActivityType.ASSIGNED,
- user: null,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- /Sentry auto-assigned this issue to anotheruser@sentry.io/
- );
- });
- it('renders an assigned via slack activity', function () {
- const user = UserFixture({id: '301', name: 'Mark'});
- createWrapper({
- activity: [
- {
- data: {
- assignee: '123',
- assigneeEmail: 'anotheruser@sentry.io',
- assigneeType: 'user',
- integration: 'slack',
- user: UserFixture(),
- },
- project: ProjectFixture(),
- dateCreated: '2021-10-01T15:31:38.950115Z',
- id: '117',
- type: GroupActivityType.ASSIGNED,
- user,
- },
- ],
- });
- const item = screen.getAllByTestId('activity-item').at(-1);
- expect(item).toHaveTextContent(/Mark assigned this issue to anotheruser@sentry.io/);
- expect(item).toHaveTextContent(/Assigned via Slack/);
- });
- it('renders an assigned via suspect commit activity', function () {
- createWrapper({
- activity: [
- {
- data: {
- assignee: '123',
- assigneeEmail: 'anotheruser@sentry.io',
- assigneeType: 'user',
- integration: 'suspectCommitter',
- user: UserFixture(),
- },
- project: ProjectFixture(),
- dateCreated: '1999-10-01T15:31:38.950115Z',
- id: '117',
- type: GroupActivityType.ASSIGNED,
- user: null,
- },
- ],
- });
- const activity = screen.getAllByTestId('activity-item').at(-1);
- expect(activity).toHaveTextContent(
- /Sentry auto-assigned this issue to anotheruser@sentry.io/
- );
- expect(activity).toHaveTextContent(/Assigned via Suspect Commit/);
- });
- it('does not render undefined when integration is not recognized', function () {
- createWrapper({
- activity: [
- // @ts-ignore-next-line -> committing type crimes on `integration`
- {
- data: {
- assignee: '123',
- assigneeEmail: 'anotheruser@sentry.io',
- assigneeType: 'user',
- integration: 'lottery',
- user: UserFixture(),
- },
- project: ProjectFixture(),
- dateCreated: '1999-10-01T15:31:38.950115Z',
- id: '117',
- type: GroupActivityType.ASSIGNED,
- user: null,
- },
- ],
- });
- const activity = screen.getAllByTestId('activity-item').at(-1);
- expect(activity).toHaveTextContent(
- /Sentry assigned this issue to anotheruser@sentry.io/
- );
- expect(activity).not.toHaveTextContent(/Assigned via Suspect Commit/);
- });
- it('resolved in commit with no releases', function () {
- createWrapper({
- activity: [
- {
- type: GroupActivityType.SET_RESOLVED_IN_COMMIT,
- id: '123',
- project: ProjectFixture(),
- dateCreated: '',
- data: {
- commit: {
- dateCreated: '',
- message: '',
- id: 'komal-commit',
- repository: RepositoryFixture(),
- releases: [],
- },
- },
- user: UserFixture(),
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Foo Bar marked this issue as resolved in komal-commit'
- );
- });
- it('resolved in commit with one release', function () {
- createWrapper({
- activity: [
- {
- type: GroupActivityType.SET_RESOLVED_IN_COMMIT,
- id: '123',
- project: ProjectFixture(),
- dateCreated: '',
- data: {
- commit: {
- id: 'komal-commit',
- dateCreated: '',
- message: '',
- repository: RepositoryFixture(),
- releases: [
- ReleaseFixture({
- dateCreated: '2022-05-01',
- dateReleased: '2022-05-02',
- version: 'random',
- }),
- ],
- },
- },
- user: UserFixture(),
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Foo Bar marked this issue as resolved in komal-commit This commit was released in random'
- );
- });
- it('resolved in commit with multiple releases', function () {
- createWrapper({
- activity: [
- {
- type: GroupActivityType.SET_RESOLVED_IN_COMMIT,
- id: '123',
- project: ProjectFixture(),
- dateCreated: '',
- data: {
- commit: {
- id: 'komal-commit',
- dateCreated: '',
- message: '',
- repository: RepositoryFixture(),
- releases: [
- ReleaseFixture({
- dateCreated: '2022-05-01',
- dateReleased: '2022-05-02',
- version: 'random',
- }),
- ReleaseFixture({
- dateCreated: '2022-06-01',
- dateReleased: '2022-06-02',
- version: 'newest',
- }),
- ReleaseFixture({
- dateCreated: '2021-08-03',
- dateReleased: '2021-08-03',
- version: 'oldest-release',
- }),
- ReleaseFixture({
- dateCreated: '2022-04-21',
- dateReleased: '2022-04-21',
- version: 'randomTwo',
- }),
- ],
- },
- },
- user: UserFixture(),
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Foo Bar marked this issue as resolved in komal-commit This commit was released in oldest-release and 3 others'
- );
- });
- it('requests assignees that are not in the team store', async function () {
- const team = TeamFixture({id: '123', name: 'workflow'});
- const teamRequest = MockApiClient.addMockResponse({
- url: `/organizations/org-slug/teams/`,
- body: [team],
- });
- createWrapper({
- activity: [
- {
- id: '123',
- user: null,
- type: GroupActivityType.ASSIGNED,
- project: ProjectFixture(),
- data: {
- assignee: team.id,
- assigneeType: 'team',
- user: UserFixture(),
- },
- dateCreated: '2021-10-28T13:40:10.634821Z',
- },
- ],
- });
- await waitFor(() => expect(teamRequest).toHaveBeenCalledTimes(1));
- expect(
- await screen.findByText(`assigned this issue to #${team.slug}`)
- ).toBeInTheDocument();
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- /Sentry assigned this issue to #team-slug/
- );
- });
- describe('Delete', function () {
- let deleteMock;
- beforeEach(function () {
- deleteMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/issues/1337/comments/note-1/',
- method: 'DELETE',
- });
- ConfigStore.set('user', UserFixture({id: '123', isSuperuser: true}));
- });
- it('should do nothing if not present in GroupStore', async function () {
- createWrapper();
- renderGlobalModal();
- act(() => {
- // Remove note from group activity
- GroupStore.removeActivity('1337', 'note-1');
- });
- await userEvent.click(screen.getByRole('button', {name: 'Comment Actions'}));
- await userEvent.click(screen.getByRole('menuitemradio', {name: 'Remove'}));
- expect(
- screen.getByText('Are you sure you wish to delete this comment?')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('button', {name: 'Confirm'}));
- expect(deleteMock).not.toHaveBeenCalled();
- });
- it('should remove remove the item from the GroupStore make a DELETE API request', async function () {
- createWrapper();
- renderGlobalModal();
- await userEvent.click(screen.getByRole('button', {name: 'Comment Actions'}));
- await userEvent.click(screen.getByRole('menuitemradio', {name: 'Remove'}));
- expect(
- screen.getByText('Are you sure you wish to delete this comment?')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('button', {name: 'Confirm'}));
- expect(deleteMock).toHaveBeenCalledTimes(1);
- });
- });
- it('renders archived until escalating', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_IGNORED,
- project: ProjectFixture(),
- data: {
- ignoreUntilEscalating: true,
- },
- user: UserFixture(),
- dateCreated,
- },
- ],
- organization: OrganizationFixture(),
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Foo Bar archived this issue until it escalates'
- );
- });
- it('renders escalating with forecast and plural events', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_UNRESOLVED,
- project: ProjectFixture(),
- data: {
- forecast: 200,
- },
- user: null,
- dateCreated,
- },
- {
- id: '124',
- type: GroupActivityType.SET_ESCALATING,
- project: ProjectFixture(),
- data: {
- forecast: 400,
- },
- user: null,
- dateCreated: '2021-10-05T15:31:38.950115Z',
- },
- ],
- organization: OrganizationFixture(),
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry flagged this issue as escalating because over 400 events happened in an hour'
- );
- expect(screen.getAllByTestId('activity-item').at(-2)).toHaveTextContent(
- 'Sentry flagged this issue as escalating because over 200 events happened in an hour'
- );
- });
- it('renders escalating with forecast and singular event', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_UNRESOLVED,
- project: ProjectFixture(),
- data: {
- forecast: 1,
- },
- user: null,
- dateCreated,
- },
- ],
- organization: OrganizationFixture(),
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry flagged this issue as escalating because over 1 event happened in an hour'
- );
- });
- it('renders issue unresvoled via jira', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_UNRESOLVED,
- project: ProjectFixture(),
- data: {
- integration_id: '1',
- provider_key: 'jira',
- provider: 'Jira',
- },
- user: null,
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry marked this issue as unresolved via Jira'
- );
- });
- it('renders issue resolved via jira', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_RESOLVED,
- project: ProjectFixture(),
- data: {
- integration_id: '1',
- provider_key: 'jira',
- provider: 'Jira',
- },
- user: null,
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry marked this issue as resolved via Jira'
- );
- });
- it('renders escalating since it happened x times in time window', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_ESCALATING,
- project: ProjectFixture(),
- data: {
- expired_snooze: {
- count: 400,
- window: 1,
- until: null,
- user_count: null,
- user_window: null,
- },
- },
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry flagged this issue as escalating because 400 events happened in 1 minute'
- );
- });
- it('renders escalating since x users were affected in time window', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_ESCALATING,
- project: ProjectFixture(),
- data: {
- expired_snooze: {
- user_count: 1,
- user_window: 1,
- until: null,
- count: null,
- window: null,
- },
- },
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry flagged this issue as escalating because 1 user was affected in 1 minute'
- );
- });
- it('renders escalating since until date passed', function () {
- const date = new Date('2018-10-30');
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_ESCALATING,
- project: ProjectFixture(),
- data: {
- expired_snooze: {
- until: date,
- user_count: null,
- user_window: null,
- count: null,
- window: null,
- },
- },
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry flagged this issue as escalating because Oct 30, 2018 12:00 AM passed'
- );
- });
- it('renders archived forever', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_IGNORED,
- project: ProjectFixture(),
- data: {},
- user: UserFixture(),
- dateCreated,
- },
- ],
- organization: OrganizationFixture(),
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Foo Bar archived this issue forever'
- );
- });
- it('renders resolved in release with semver information', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_RESOLVED_IN_RELEASE,
- project: ProjectFixture(),
- data: {
- version: 'frontend@1.0.0',
- },
- user: UserFixture(),
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Foo Bar marked this issue as resolved in 1.0.0 (semver)'
- );
- });
- it('renders resolved in next release with semver information', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_RESOLVED_IN_RELEASE,
- project: ProjectFixture(),
- data: {
- current_release_version: 'frontend@1.0.0',
- },
- user: UserFixture(),
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Foo Bar marked this issue as resolved in releases greater than 1.0.0 (semver)'
- );
- });
- describe('regression', function () {
- it('renders basic regression', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_REGRESSION,
- project: ProjectFixture(),
- data: {},
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry marked this issue as a regression'
- );
- });
- it('renders regression with version', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_REGRESSION,
- project: ProjectFixture(),
- data: {
- version: 'frontend@1.0.0',
- },
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry marked this issue as a regression in 1.0.0'
- );
- });
- it('renders regression with semver description', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_REGRESSION,
- project: ProjectFixture(),
- data: {
- version: 'frontend@2.0.0',
- resolved_in_version: 'frontend@1.0.0',
- follows_semver: true,
- },
- dateCreated,
- },
- ],
- });
- const activity = screen.getAllByTestId('activity-item').at(-1);
- expect(activity).toHaveTextContent(
- 'Sentry marked this issue as a regression in 2.0.0'
- );
- expect(activity).toHaveTextContent(
- '2.0.0 is greater than or equal to 1.0.0 compared via semver'
- );
- });
- it('renders regression with non-semver description', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_REGRESSION,
- project: ProjectFixture(),
- data: {
- version: 'frontend@abc1',
- resolved_in_version: 'frontend@abc2',
- follows_semver: false,
- },
- dateCreated,
- },
- ],
- });
- const activity = screen.getAllByTestId('activity-item').at(-1);
- expect(activity).toHaveTextContent(
- 'Sentry marked this issue as a regression in abc1'
- );
- expect(activity).toHaveTextContent(
- 'abc1 is greater than or equal to abc2 compared via release date'
- );
- });
- it('renders a set priority activity for escalating issues', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_PRIORITY,
- project: ProjectFixture(),
- data: {
- priority: PriorityLevel.HIGH,
- reason: 'escalating',
- },
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry updated the priority value of this issue to be high after it escalated'
- );
- });
- it('renders a set priority activity for ongoing issues', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.SET_PRIORITY,
- project: ProjectFixture(),
- data: {
- priority: PriorityLevel.LOW,
- reason: 'ongoing',
- },
- dateCreated,
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'Sentry updated the priority value of this issue to be low after it was marked as ongoing'
- );
- });
- it('renders a deleted attachment activity', function () {
- createWrapper({
- activity: [
- {
- id: '123',
- type: GroupActivityType.DELETED_ATTACHMENT,
- project: ProjectFixture(),
- data: {},
- dateCreated,
- user: UserFixture(),
- },
- ],
- });
- expect(screen.getAllByTestId('activity-item').at(-1)).toHaveTextContent(
- 'deleted an attachment'
- );
- });
- });
- });
|