detail.spec.tsx 78 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437
  1. import {DashboardFixture} from 'sentry-fixture/dashboard';
  2. import {LocationFixture} from 'sentry-fixture/locationFixture';
  3. import {OrganizationFixture} from 'sentry-fixture/organization';
  4. import {ProjectFixture} from 'sentry-fixture/project';
  5. import {ReleaseFixture} from 'sentry-fixture/release';
  6. import {RouteComponentPropsFixture} from 'sentry-fixture/routeComponentPropsFixture';
  7. import {TeamFixture} from 'sentry-fixture/team';
  8. import {UserFixture} from 'sentry-fixture/user';
  9. import {WidgetFixture} from 'sentry-fixture/widget';
  10. import {initializeOrg} from 'sentry-test/initializeOrg';
  11. import {
  12. act,
  13. render,
  14. screen,
  15. userEvent,
  16. waitFor,
  17. within,
  18. } from 'sentry-test/reactTestingLibrary';
  19. import * as dashboardActions from 'sentry/actionCreators/dashboards';
  20. import * as modals from 'sentry/actionCreators/modal';
  21. import ConfigStore from 'sentry/stores/configStore';
  22. import PageFiltersStore from 'sentry/stores/pageFiltersStore';
  23. import ProjectsStore from 'sentry/stores/projectsStore';
  24. import TeamStore from 'sentry/stores/teamStore';
  25. import CreateDashboard from 'sentry/views/dashboards/create';
  26. import DashboardDetail, {
  27. handleUpdateDashboardSplit,
  28. } from 'sentry/views/dashboards/detail';
  29. import EditAccessSelector from 'sentry/views/dashboards/editAccessSelector';
  30. import * as types from 'sentry/views/dashboards/types';
  31. import {DashboardState} from 'sentry/views/dashboards/types';
  32. import ViewEditDashboard from 'sentry/views/dashboards/view';
  33. import useWidgetBuilderState from 'sentry/views/dashboards/widgetBuilder/hooks/useWidgetBuilderState';
  34. import {OrganizationContext} from 'sentry/views/organizationContext';
  35. jest.mock('sentry/views/dashboards/widgetBuilder/hooks/useWidgetBuilderState');
  36. describe('Dashboards > Detail', function () {
  37. const organization = OrganizationFixture({
  38. features: ['global-views', 'dashboards-basic', 'dashboards-edit', 'discover-query'],
  39. });
  40. const projects = [ProjectFixture()];
  41. describe('prebuilt dashboards', function () {
  42. let initialData!: ReturnType<typeof initializeOrg>;
  43. beforeEach(function () {
  44. act(() => ProjectsStore.loadInitialData(projects));
  45. initialData = initializeOrg({organization});
  46. MockApiClient.addMockResponse({
  47. url: '/organizations/org-slug/tags/',
  48. body: [],
  49. });
  50. MockApiClient.addMockResponse({
  51. url: '/organizations/org-slug/projects/',
  52. body: [ProjectFixture()],
  53. });
  54. MockApiClient.addMockResponse({
  55. url: '/organizations/org-slug/dashboards/',
  56. body: [
  57. DashboardFixture([], {id: 'default-overview', title: 'Default'}),
  58. DashboardFixture([], {id: '1', title: 'Custom Errors'}),
  59. ],
  60. });
  61. MockApiClient.addMockResponse({
  62. url: '/organizations/org-slug/dashboards/default-overview/',
  63. body: DashboardFixture([], {id: 'default-overview', title: 'Default'}),
  64. });
  65. MockApiClient.addMockResponse({
  66. url: '/organizations/org-slug/dashboards/1/visit/',
  67. method: 'POST',
  68. body: [],
  69. statusCode: 200,
  70. });
  71. MockApiClient.addMockResponse({
  72. url: '/organizations/org-slug/users/',
  73. method: 'GET',
  74. body: [],
  75. });
  76. MockApiClient.addMockResponse({
  77. url: '/organizations/org-slug/sdk-updates/',
  78. body: [],
  79. });
  80. MockApiClient.addMockResponse({
  81. url: '/organizations/org-slug/prompts-activity/',
  82. body: {},
  83. });
  84. MockApiClient.addMockResponse({
  85. url: '/organizations/org-slug/events/',
  86. method: 'GET',
  87. body: [],
  88. });
  89. MockApiClient.addMockResponse({
  90. url: '/organizations/org-slug/events-stats/',
  91. body: {data: []},
  92. });
  93. MockApiClient.addMockResponse({
  94. method: 'GET',
  95. url: '/organizations/org-slug/issues/',
  96. body: [],
  97. });
  98. MockApiClient.addMockResponse({
  99. url: '/organizations/org-slug/releases/',
  100. body: [],
  101. });
  102. MockApiClient.addMockResponse({
  103. url: '/organizations/org-slug/releases/stats/',
  104. body: [],
  105. });
  106. MockApiClient.addMockResponse({
  107. url: '/organizations/org-slug/metrics/meta/',
  108. body: [],
  109. });
  110. });
  111. afterEach(function () {
  112. MockApiClient.clearMockResponses();
  113. });
  114. it('assigns unique IDs to all widgets so grid keys are unique', async function () {
  115. MockApiClient.addMockResponse({
  116. url: '/organizations/org-slug/events-stats/',
  117. body: {data: []},
  118. });
  119. MockApiClient.addMockResponse({
  120. url: '/organizations/org-slug/dashboards/default-overview/',
  121. body: DashboardFixture(
  122. [
  123. WidgetFixture({
  124. queries: [
  125. {
  126. name: '',
  127. conditions: 'event.type:error',
  128. fields: ['count()'],
  129. aggregates: ['count()'],
  130. columns: [],
  131. orderby: '-count()',
  132. },
  133. ],
  134. title: 'Default Widget 1',
  135. interval: '1d',
  136. }),
  137. WidgetFixture({
  138. queries: [
  139. {
  140. name: '',
  141. conditions: 'event.type:transaction',
  142. fields: ['count()'],
  143. aggregates: ['count()'],
  144. columns: [],
  145. orderby: '-count()',
  146. },
  147. ],
  148. title: 'Default Widget 2',
  149. interval: '1d',
  150. }),
  151. ],
  152. {id: 'default-overview', title: 'Default'}
  153. ),
  154. });
  155. initialData = initializeOrg({
  156. organization: OrganizationFixture({
  157. features: ['global-views', 'dashboards-basic', 'discover-query'],
  158. }),
  159. });
  160. render(
  161. <OrganizationContext.Provider value={initialData.organization}>
  162. <ViewEditDashboard
  163. {...RouteComponentPropsFixture()}
  164. organization={initialData.organization}
  165. params={{orgId: 'org-slug', dashboardId: 'default-overview'}}
  166. router={initialData.router}
  167. location={initialData.router.location}
  168. >
  169. {null}
  170. </ViewEditDashboard>
  171. </OrganizationContext.Provider>,
  172. {router: initialData.router}
  173. );
  174. expect(await screen.findByText('Default Widget 1')).toBeInTheDocument();
  175. expect(screen.getByText('Default Widget 2')).toBeInTheDocument();
  176. });
  177. it('opens the widget viewer modal in a prebuilt dashboard using the widget id specified in the url', async () => {
  178. const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
  179. render(
  180. <CreateDashboard
  181. {...RouteComponentPropsFixture()}
  182. organization={initialData.organization}
  183. params={{templateId: 'default-template', widgetId: '2'}}
  184. router={initialData.router}
  185. location={{...initialData.router.location, pathname: '/widget/2/'}}
  186. >
  187. {null}
  188. </CreateDashboard>,
  189. {router: initialData.router, organization: initialData.organization}
  190. );
  191. await waitFor(() => {
  192. expect(openWidgetViewerModal).toHaveBeenCalledWith(
  193. expect.objectContaining({
  194. organization: initialData.organization,
  195. widget: expect.objectContaining({
  196. displayType: 'line',
  197. interval: '5m',
  198. queries: [
  199. {
  200. aggregates: ['count()'],
  201. columns: [],
  202. conditions: '!event.type:transaction',
  203. fields: ['count()'],
  204. name: 'Events',
  205. orderby: 'count()',
  206. },
  207. ],
  208. title: 'Events',
  209. widgetType: types.WidgetType.DISCOVER,
  210. }),
  211. onClose: expect.anything(),
  212. })
  213. );
  214. });
  215. });
  216. });
  217. describe('custom dashboards', function () {
  218. let initialData!: ReturnType<typeof initializeOrg>;
  219. let widgets!: ReturnType<typeof WidgetFixture>[];
  220. let mockVisit!: jest.Mock;
  221. let mockPut!: jest.Mock;
  222. beforeEach(function () {
  223. window.confirm = jest.fn();
  224. initialData = initializeOrg({
  225. organization,
  226. router: {
  227. location: LocationFixture(),
  228. },
  229. });
  230. PageFiltersStore.init();
  231. PageFiltersStore.onInitializeUrlState(
  232. {
  233. projects: [],
  234. environments: [],
  235. datetime: {start: null, end: null, period: '14d', utc: null},
  236. },
  237. new Set()
  238. );
  239. widgets = [
  240. WidgetFixture({
  241. queries: [
  242. {
  243. name: '',
  244. conditions: 'event.type:error',
  245. fields: ['count()'],
  246. columns: [],
  247. aggregates: ['count()'],
  248. orderby: '-count()',
  249. },
  250. ],
  251. title: 'Errors',
  252. interval: '1d',
  253. widgetType: types.WidgetType.DISCOVER,
  254. id: '1',
  255. }),
  256. WidgetFixture({
  257. queries: [
  258. {
  259. name: '',
  260. conditions: 'event.type:transaction',
  261. fields: ['count()'],
  262. columns: [],
  263. aggregates: ['count()'],
  264. orderby: '-count()',
  265. },
  266. ],
  267. title: 'Transactions',
  268. interval: '1d',
  269. widgetType: types.WidgetType.DISCOVER,
  270. id: '2',
  271. }),
  272. WidgetFixture({
  273. queries: [
  274. {
  275. name: '',
  276. conditions: 'event.type:transaction transaction:/api/cats',
  277. fields: ['p50()'],
  278. columns: [],
  279. aggregates: ['p50()'],
  280. orderby: '-p50()',
  281. },
  282. ],
  283. title: 'p50 of /api/cats',
  284. interval: '1d',
  285. id: '3',
  286. }),
  287. ];
  288. mockVisit = MockApiClient.addMockResponse({
  289. url: '/organizations/org-slug/dashboards/1/visit/',
  290. method: 'POST',
  291. body: [],
  292. statusCode: 200,
  293. });
  294. MockApiClient.addMockResponse({
  295. url: '/organizations/org-slug/tags/',
  296. body: [],
  297. });
  298. MockApiClient.addMockResponse({
  299. url: '/organizations/org-slug/projects/',
  300. body: [ProjectFixture()],
  301. });
  302. MockApiClient.addMockResponse({
  303. url: '/organizations/org-slug/dashboards/',
  304. body: [
  305. {
  306. ...DashboardFixture([], {
  307. id: 'default-overview',
  308. title: 'Default',
  309. }),
  310. widgetDisplay: ['area'],
  311. },
  312. {
  313. ...DashboardFixture([], {
  314. id: '1',
  315. title: 'Custom Errors',
  316. }),
  317. widgetDisplay: ['area'],
  318. },
  319. ],
  320. });
  321. MockApiClient.addMockResponse({
  322. url: '/organizations/org-slug/dashboards/1/',
  323. body: DashboardFixture(widgets, {
  324. id: '1',
  325. title: 'Custom Errors',
  326. filters: {},
  327. createdBy: UserFixture({id: '1'}),
  328. }),
  329. });
  330. mockPut = MockApiClient.addMockResponse({
  331. url: '/organizations/org-slug/dashboards/1/',
  332. method: 'PUT',
  333. body: DashboardFixture(widgets, {id: '1', title: 'Custom Errors'}),
  334. });
  335. MockApiClient.addMockResponse({
  336. url: '/organizations/org-slug/events-stats/',
  337. body: {data: []},
  338. });
  339. MockApiClient.addMockResponse({
  340. method: 'POST',
  341. url: '/organizations/org-slug/dashboards/widgets/',
  342. body: [],
  343. });
  344. MockApiClient.addMockResponse({
  345. method: 'GET',
  346. url: '/organizations/org-slug/recent-searches/',
  347. body: [],
  348. });
  349. MockApiClient.addMockResponse({
  350. method: 'GET',
  351. url: '/organizations/org-slug/issues/',
  352. body: [],
  353. });
  354. MockApiClient.addMockResponse({
  355. url: '/organizations/org-slug/events/',
  356. method: 'GET',
  357. body: [],
  358. });
  359. MockApiClient.addMockResponse({
  360. url: '/organizations/org-slug/users/',
  361. method: 'GET',
  362. body: [],
  363. });
  364. MockApiClient.addMockResponse({
  365. url: '/organizations/org-slug/releases/',
  366. body: [],
  367. });
  368. MockApiClient.addMockResponse({
  369. url: '/organizations/org-slug/releases/stats/',
  370. body: [],
  371. });
  372. MockApiClient.addMockResponse({
  373. url: '/organizations/org-slug/sdk-updates/',
  374. body: [],
  375. });
  376. MockApiClient.addMockResponse({
  377. url: '/organizations/org-slug/prompts-activity/',
  378. body: {},
  379. });
  380. MockApiClient.addMockResponse({
  381. url: '/organizations/org-slug/metrics/meta/',
  382. body: [],
  383. });
  384. MockApiClient.addMockResponse({
  385. url: '/organizations/org-slug/measurements-meta/',
  386. body: [],
  387. });
  388. });
  389. afterEach(function () {
  390. MockApiClient.clearMockResponses();
  391. jest.clearAllMocks();
  392. });
  393. it('can remove widgets', async function () {
  394. const updateMock = MockApiClient.addMockResponse({
  395. url: '/organizations/org-slug/dashboards/1/',
  396. method: 'PUT',
  397. body: DashboardFixture([widgets[0]!], {id: '1', title: 'Custom Errors'}),
  398. });
  399. render(
  400. <OrganizationContext.Provider value={initialData.organization}>
  401. <ViewEditDashboard
  402. {...RouteComponentPropsFixture()}
  403. organization={initialData.organization}
  404. params={{orgId: 'org-slug', dashboardId: '1'}}
  405. router={initialData.router}
  406. location={initialData.router.location}
  407. >
  408. {null}
  409. </ViewEditDashboard>
  410. </OrganizationContext.Provider>,
  411. {router: initialData.router}
  412. );
  413. await waitFor(() => expect(mockVisit).toHaveBeenCalledTimes(1));
  414. // Enter edit mode.
  415. await userEvent.click(screen.getByRole('button', {name: 'Edit Dashboard'}));
  416. // Remove the second and third widgets
  417. await userEvent.click(
  418. (await screen.findAllByRole('button', {name: 'Delete Widget'}))[1]!
  419. );
  420. await userEvent.click(
  421. (await screen.findAllByRole('button', {name: 'Delete Widget'}))[1]!
  422. );
  423. // Save changes
  424. await userEvent.click(screen.getByRole('button', {name: 'Save and Finish'}));
  425. expect(updateMock).toHaveBeenCalled();
  426. expect(updateMock).toHaveBeenCalledWith(
  427. '/organizations/org-slug/dashboards/1/',
  428. expect.objectContaining({
  429. data: expect.objectContaining({
  430. title: 'Custom Errors',
  431. widgets: [expect.objectContaining(widgets[0])],
  432. }),
  433. })
  434. );
  435. // Visit should not be called again on dashboard update
  436. expect(mockVisit).toHaveBeenCalledTimes(1);
  437. });
  438. it('appends dashboard-level filters to series request', async function () {
  439. MockApiClient.addMockResponse({
  440. url: '/organizations/org-slug/dashboards/1/',
  441. body: DashboardFixture(widgets, {
  442. id: '1',
  443. title: 'Custom Errors',
  444. filters: {release: ['abc@1.2.0']},
  445. }),
  446. });
  447. const mock = MockApiClient.addMockResponse({
  448. url: '/organizations/org-slug/events-stats/',
  449. body: [],
  450. });
  451. render(
  452. <OrganizationContext.Provider value={initialData.organization}>
  453. <ViewEditDashboard
  454. {...RouteComponentPropsFixture()}
  455. organization={initialData.organization}
  456. params={{orgId: 'org-slug', dashboardId: '1'}}
  457. router={initialData.router}
  458. location={initialData.router.location}
  459. >
  460. {null}
  461. </ViewEditDashboard>
  462. </OrganizationContext.Provider>,
  463. {router: initialData.router}
  464. );
  465. await waitFor(() =>
  466. expect(mock).toHaveBeenLastCalledWith(
  467. '/organizations/org-slug/events-stats/',
  468. expect.objectContaining({
  469. query: expect.objectContaining({
  470. query:
  471. '(event.type:transaction transaction:/api/cats) release:"abc@1.2.0" ',
  472. }),
  473. })
  474. )
  475. );
  476. });
  477. it('shows add widget option', async function () {
  478. render(
  479. <OrganizationContext.Provider value={initialData.organization}>
  480. <ViewEditDashboard
  481. {...RouteComponentPropsFixture()}
  482. organization={initialData.organization}
  483. params={{orgId: 'org-slug', dashboardId: '1'}}
  484. router={initialData.router}
  485. location={initialData.router.location}
  486. >
  487. {null}
  488. </ViewEditDashboard>
  489. </OrganizationContext.Provider>,
  490. {router: initialData.router}
  491. );
  492. // Enter edit mode.
  493. await userEvent.click(screen.getByRole('button', {name: 'Edit Dashboard'}));
  494. expect(await screen.findByRole('button', {name: 'Add widget'})).toBeInTheDocument();
  495. });
  496. it('shows add widget option with dataset selector flag', async function () {
  497. initialData = initializeOrg({
  498. organization: OrganizationFixture({
  499. features: [
  500. 'global-views',
  501. 'dashboards-basic',
  502. 'dashboards-edit',
  503. 'discover-query',
  504. 'custom-metrics',
  505. 'performance-discover-dataset-selector',
  506. ],
  507. }),
  508. });
  509. render(
  510. <OrganizationContext.Provider value={initialData.organization}>
  511. <ViewEditDashboard
  512. {...RouteComponentPropsFixture()}
  513. organization={initialData.organization}
  514. params={{orgId: 'org-slug', dashboardId: '1'}}
  515. router={initialData.router}
  516. location={initialData.router.location}
  517. >
  518. {null}
  519. </ViewEditDashboard>
  520. </OrganizationContext.Provider>,
  521. {router: initialData.router}
  522. );
  523. await userEvent.click(screen.getAllByText('Add Widget')[0]!);
  524. const menuOptions = await screen.findAllByTestId('menu-list-item-label');
  525. expect(menuOptions.map(e => e.textContent)).toEqual([
  526. 'Errors',
  527. 'Transactions',
  528. 'Issues',
  529. 'Releases',
  530. 'Metrics',
  531. ]);
  532. });
  533. it('shows add widget option without dataset selector flag', async function () {
  534. initialData = initializeOrg({
  535. organization: OrganizationFixture({
  536. features: [
  537. 'global-views',
  538. 'dashboards-basic',
  539. 'dashboards-edit',
  540. 'discover-query',
  541. 'custom-metrics',
  542. ],
  543. }),
  544. });
  545. render(
  546. <OrganizationContext.Provider value={initialData.organization}>
  547. <ViewEditDashboard
  548. {...RouteComponentPropsFixture()}
  549. organization={initialData.organization}
  550. params={{orgId: 'org-slug', dashboardId: '1'}}
  551. router={initialData.router}
  552. location={initialData.router.location}
  553. >
  554. {null}
  555. </ViewEditDashboard>
  556. </OrganizationContext.Provider>,
  557. {router: initialData.router}
  558. );
  559. await userEvent.click(screen.getAllByText('Add Widget')[0]!);
  560. const menuOptions = await screen.findAllByTestId('menu-list-item-label');
  561. expect(menuOptions.map(e => e.textContent)).toEqual([
  562. 'Errors and Transactions',
  563. 'Issues',
  564. 'Releases',
  565. 'Metrics',
  566. ]);
  567. });
  568. it('shows top level release filter', async function () {
  569. const mockReleases = MockApiClient.addMockResponse({
  570. url: '/organizations/org-slug/releases/',
  571. body: [ReleaseFixture()],
  572. });
  573. initialData = initializeOrg({
  574. organization: OrganizationFixture({
  575. features: [
  576. 'global-views',
  577. 'dashboards-basic',
  578. 'dashboards-edit',
  579. 'discover-query',
  580. ],
  581. }),
  582. });
  583. render(
  584. <OrganizationContext.Provider value={initialData.organization}>
  585. <ViewEditDashboard
  586. {...RouteComponentPropsFixture()}
  587. organization={initialData.organization}
  588. params={{orgId: 'org-slug', dashboardId: '1'}}
  589. router={initialData.router}
  590. location={initialData.router.location}
  591. >
  592. {null}
  593. </ViewEditDashboard>
  594. </OrganizationContext.Provider>,
  595. {router: initialData.router}
  596. );
  597. expect(await screen.findByText('All Releases')).toBeInTheDocument();
  598. expect(mockReleases).toHaveBeenCalledTimes(2); // Called once when PageFiltersStore is initialized
  599. });
  600. it('hides add widget option', async function () {
  601. // @ts-expect-error this is assigning to readonly property...
  602. types.MAX_WIDGETS = 1;
  603. render(
  604. <OrganizationContext.Provider value={initialData.organization}>
  605. <ViewEditDashboard
  606. {...RouteComponentPropsFixture()}
  607. organization={initialData.organization}
  608. params={{orgId: 'org-slug', dashboardId: '1'}}
  609. router={initialData.router}
  610. location={initialData.router.location}
  611. >
  612. {null}
  613. </ViewEditDashboard>
  614. </OrganizationContext.Provider>,
  615. {router: initialData.router}
  616. );
  617. // Enter edit mode.
  618. await userEvent.click(await screen.findByRole('button', {name: 'Edit Dashboard'}));
  619. expect(screen.queryByRole('button', {name: 'Add widget'})).not.toBeInTheDocument();
  620. });
  621. it('renders successfully if more widgets than stored layouts', async function () {
  622. // A case where someone has async added widgets to a dashboard
  623. MockApiClient.addMockResponse({
  624. url: '/organizations/org-slug/dashboards/1/',
  625. body: DashboardFixture(
  626. [
  627. WidgetFixture({
  628. queries: [
  629. {
  630. name: '',
  631. conditions: 'event.type:error',
  632. fields: ['count()'],
  633. aggregates: ['count()'],
  634. columns: [],
  635. orderby: '-count()',
  636. },
  637. ],
  638. title: 'First Widget',
  639. interval: '1d',
  640. id: '1',
  641. layout: {x: 0, y: 0, w: 2, h: 6, minH: 0},
  642. }),
  643. WidgetFixture({
  644. queries: [
  645. {
  646. name: '',
  647. conditions: 'event.type:error',
  648. fields: ['count()'],
  649. aggregates: ['count()'],
  650. columns: [],
  651. orderby: '-count()',
  652. },
  653. ],
  654. title: 'Second Widget',
  655. interval: '1d',
  656. id: '2',
  657. }),
  658. ],
  659. {id: '1', title: 'Custom Errors'}
  660. ),
  661. });
  662. render(
  663. <ViewEditDashboard
  664. {...RouteComponentPropsFixture()}
  665. organization={initialData.organization}
  666. params={{orgId: 'org-slug', dashboardId: '1'}}
  667. router={initialData.router}
  668. location={initialData.router.location}
  669. >
  670. {null}
  671. </ViewEditDashboard>,
  672. {router: initialData.router, organization: initialData.organization}
  673. );
  674. expect(await screen.findByText('First Widget')).toBeInTheDocument();
  675. expect(await screen.findByText('Second Widget')).toBeInTheDocument();
  676. });
  677. it('does not trigger request if layout not updated', async () => {
  678. MockApiClient.addMockResponse({
  679. url: '/organizations/org-slug/dashboards/1/',
  680. body: DashboardFixture(
  681. [
  682. WidgetFixture({
  683. queries: [
  684. {
  685. name: '',
  686. conditions: 'event.type:error',
  687. fields: ['count()'],
  688. aggregates: ['count()'],
  689. columns: [],
  690. orderby: '-count()',
  691. },
  692. ],
  693. title: 'First Widget',
  694. interval: '1d',
  695. id: '1',
  696. layout: {x: 0, y: 0, w: 2, h: 6, minH: 0},
  697. }),
  698. ],
  699. {id: '1', title: 'Custom Errors'}
  700. ),
  701. });
  702. render(
  703. <ViewEditDashboard
  704. {...RouteComponentPropsFixture()}
  705. organization={initialData.organization}
  706. params={{orgId: 'org-slug', dashboardId: '1'}}
  707. router={initialData.router}
  708. location={initialData.router.location}
  709. >
  710. {null}
  711. </ViewEditDashboard>,
  712. {router: initialData.router, organization: initialData.organization}
  713. );
  714. await userEvent.click(await screen.findByText('Edit Dashboard'));
  715. await userEvent.click(await screen.findByText('Save and Finish'));
  716. expect(screen.getByText('Edit Dashboard')).toBeInTheDocument();
  717. expect(mockPut).not.toHaveBeenCalled();
  718. });
  719. it('renders the custom resize handler for a widget', async () => {
  720. MockApiClient.addMockResponse({
  721. url: '/organizations/org-slug/dashboards/1/',
  722. body: DashboardFixture(
  723. [
  724. WidgetFixture({
  725. queries: [
  726. {
  727. name: '',
  728. conditions: 'event.type:error',
  729. fields: ['count()'],
  730. aggregates: ['count()'],
  731. columns: [],
  732. orderby: '-count()',
  733. },
  734. ],
  735. title: 'First Widget',
  736. interval: '1d',
  737. id: '1',
  738. layout: {x: 0, y: 0, w: 2, h: 6, minH: 0},
  739. }),
  740. ],
  741. {id: '1', title: 'Custom Errors'}
  742. ),
  743. });
  744. render(
  745. <ViewEditDashboard
  746. {...RouteComponentPropsFixture()}
  747. organization={initialData.organization}
  748. params={{orgId: 'org-slug', dashboardId: '1'}}
  749. router={initialData.router}
  750. location={initialData.router.location}
  751. >
  752. {null}
  753. </ViewEditDashboard>,
  754. {router: initialData.router, organization: initialData.organization}
  755. );
  756. await userEvent.click(await screen.findByText('Edit Dashboard'));
  757. const widget = (await screen.findByText('First Widget')).closest(
  758. '.react-grid-item'
  759. ) as HTMLElement;
  760. const resizeHandle = within(widget).getByTestId('custom-resize-handle');
  761. expect(resizeHandle).toBeVisible();
  762. });
  763. it('does not trigger an alert when the widgets have no layout and user cancels without changes', async () => {
  764. MockApiClient.addMockResponse({
  765. url: '/organizations/org-slug/dashboards/1/',
  766. body: DashboardFixture(
  767. [
  768. WidgetFixture({
  769. queries: [
  770. {
  771. name: '',
  772. conditions: 'event.type:error',
  773. fields: ['count()'],
  774. aggregates: ['count()'],
  775. columns: [],
  776. orderby: '-count()',
  777. },
  778. ],
  779. title: 'First Widget',
  780. interval: '1d',
  781. id: '1',
  782. layout: null,
  783. }),
  784. ],
  785. {id: '1', title: 'Custom Errors'}
  786. ),
  787. });
  788. render(
  789. <ViewEditDashboard
  790. {...RouteComponentPropsFixture()}
  791. organization={initialData.organization}
  792. params={{orgId: 'org-slug', dashboardId: '1'}}
  793. router={initialData.router}
  794. location={initialData.router.location}
  795. >
  796. {null}
  797. </ViewEditDashboard>,
  798. {router: initialData.router, organization: initialData.organization}
  799. );
  800. await userEvent.click(await screen.findByText('Edit Dashboard'));
  801. await userEvent.click(await screen.findByText('Cancel'));
  802. expect(window.confirm).not.toHaveBeenCalled();
  803. });
  804. it('opens the widget viewer modal using the widget id specified in the url', async () => {
  805. const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
  806. const widget = WidgetFixture({
  807. queries: [
  808. {
  809. name: '',
  810. conditions: 'event.type:error',
  811. fields: ['count()'],
  812. aggregates: ['count()'],
  813. columns: [],
  814. orderby: '',
  815. },
  816. ],
  817. title: 'First Widget',
  818. interval: '1d',
  819. id: '1',
  820. layout: null,
  821. });
  822. MockApiClient.addMockResponse({
  823. url: '/organizations/org-slug/dashboards/1/',
  824. body: DashboardFixture([widget], {id: '1', title: 'Custom Errors'}),
  825. });
  826. render(
  827. <ViewEditDashboard
  828. {...RouteComponentPropsFixture()}
  829. organization={initialData.organization}
  830. params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
  831. router={initialData.router}
  832. location={{...initialData.router.location, pathname: '/widget/123/'}}
  833. >
  834. {null}
  835. </ViewEditDashboard>,
  836. {router: initialData.router, organization: initialData.organization}
  837. );
  838. await waitFor(() => {
  839. expect(openWidgetViewerModal).toHaveBeenCalledWith(
  840. expect.objectContaining({
  841. organization: initialData.organization,
  842. widget,
  843. onClose: expect.anything(),
  844. })
  845. );
  846. });
  847. });
  848. it('redirects user to dashboard url if widget is not found', async () => {
  849. const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
  850. MockApiClient.addMockResponse({
  851. url: '/organizations/org-slug/dashboards/1/',
  852. body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
  853. });
  854. render(
  855. <ViewEditDashboard
  856. {...RouteComponentPropsFixture()}
  857. organization={initialData.organization}
  858. params={{orgId: 'org-slug', dashboardId: '1', widgetId: 123}}
  859. router={initialData.router}
  860. location={{...initialData.router.location, pathname: '/widget/123/'}}
  861. >
  862. {null}
  863. </ViewEditDashboard>,
  864. {router: initialData.router, organization: initialData.organization}
  865. );
  866. expect(await screen.findByText('All Releases')).toBeInTheDocument();
  867. expect(openWidgetViewerModal).not.toHaveBeenCalled();
  868. expect(initialData.router.replace).toHaveBeenCalledWith(
  869. expect.objectContaining({
  870. pathname: '/organizations/org-slug/dashboard/1/',
  871. query: {},
  872. })
  873. );
  874. });
  875. it('saves a new dashboard with the page filters', async () => {
  876. const mockPOST = MockApiClient.addMockResponse({
  877. url: '/organizations/org-slug/dashboards/',
  878. method: 'POST',
  879. body: [],
  880. });
  881. render(
  882. <CreateDashboard
  883. {...RouteComponentPropsFixture()}
  884. organization={initialData.organization}
  885. params={{templateId: undefined}}
  886. router={initialData.router}
  887. location={{
  888. ...initialData.router.location,
  889. query: {
  890. ...initialData.router.location.query,
  891. statsPeriod: '7d',
  892. project: [2],
  893. environment: ['alpha', 'beta'],
  894. },
  895. }}
  896. >
  897. {null}
  898. </CreateDashboard>,
  899. {
  900. router: initialData.router,
  901. organization: initialData.organization,
  902. }
  903. );
  904. await userEvent.click(await screen.findByText('Save and Finish'));
  905. expect(mockPOST).toHaveBeenCalledWith(
  906. '/organizations/org-slug/dashboards/',
  907. expect.objectContaining({
  908. data: expect.objectContaining({
  909. projects: [2],
  910. environment: ['alpha', 'beta'],
  911. period: '7d',
  912. }),
  913. })
  914. );
  915. });
  916. it('saves a template with the page filters', async () => {
  917. const mockPOST = MockApiClient.addMockResponse({
  918. url: '/organizations/org-slug/dashboards/',
  919. method: 'POST',
  920. body: [],
  921. });
  922. render(
  923. <CreateDashboard
  924. {...RouteComponentPropsFixture()}
  925. organization={initialData.organization}
  926. params={{templateId: 'default-template'}}
  927. router={initialData.router}
  928. location={{
  929. ...initialData.router.location,
  930. query: {
  931. ...initialData.router.location.query,
  932. statsPeriod: '7d',
  933. project: [2],
  934. environment: ['alpha', 'beta'],
  935. },
  936. }}
  937. >
  938. {null}
  939. </CreateDashboard>,
  940. {
  941. router: initialData.router,
  942. organization: initialData.organization,
  943. }
  944. );
  945. await userEvent.click(await screen.findByText('Add Dashboard'));
  946. expect(mockPOST).toHaveBeenCalledWith(
  947. '/organizations/org-slug/dashboards/',
  948. expect.objectContaining({
  949. data: expect.objectContaining({
  950. projects: [2],
  951. environment: ['alpha', 'beta'],
  952. period: '7d',
  953. }),
  954. })
  955. );
  956. });
  957. it('does not render save and cancel buttons on templates', async () => {
  958. MockApiClient.addMockResponse({
  959. url: '/organizations/org-slug/releases/',
  960. body: [
  961. ReleaseFixture({
  962. shortVersion: 'sentry-android-shop@1.2.0',
  963. version: 'sentry-android-shop@1.2.0',
  964. }),
  965. ],
  966. });
  967. render(
  968. <CreateDashboard
  969. {...RouteComponentPropsFixture()}
  970. organization={initialData.organization}
  971. params={{templateId: 'default-template'}}
  972. router={initialData.router}
  973. location={initialData.router.location}
  974. >
  975. {null}
  976. </CreateDashboard>,
  977. {
  978. router: initialData.router,
  979. organization: initialData.organization,
  980. }
  981. );
  982. await userEvent.click(await screen.findByText('24H'));
  983. await userEvent.click(screen.getByText('Last 7 days'));
  984. await screen.findByText('7D');
  985. expect(screen.queryByText('Cancel')).not.toBeInTheDocument();
  986. expect(screen.queryByText('Save')).not.toBeInTheDocument();
  987. });
  988. it('opens the widget viewer with saved dashboard filters', async () => {
  989. const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
  990. MockApiClient.addMockResponse({
  991. url: '/organizations/org-slug/dashboards/1/',
  992. body: DashboardFixture(widgets, {
  993. id: '1',
  994. filters: {release: ['sentry-android-shop@1.2.0']},
  995. }),
  996. });
  997. render(
  998. <ViewEditDashboard
  999. {...RouteComponentPropsFixture()}
  1000. organization={initialData.organization}
  1001. params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
  1002. router={initialData.router}
  1003. location={{...initialData.router.location, pathname: '/widget/1/'}}
  1004. >
  1005. {null}
  1006. </ViewEditDashboard>,
  1007. {router: initialData.router, organization: initialData.organization}
  1008. );
  1009. await waitFor(() => {
  1010. expect(openWidgetViewerModal).toHaveBeenCalledWith(
  1011. expect.objectContaining({
  1012. dashboardFilters: {release: ['sentry-android-shop@1.2.0']},
  1013. })
  1014. );
  1015. });
  1016. });
  1017. it('opens the widget viewer with unsaved dashboard filters', async () => {
  1018. const openWidgetViewerModal = jest.spyOn(modals, 'openWidgetViewerModal');
  1019. MockApiClient.addMockResponse({
  1020. url: '/organizations/org-slug/dashboards/1/',
  1021. body: DashboardFixture(widgets, {
  1022. id: '1',
  1023. filters: {release: ['sentry-android-shop@1.2.0']},
  1024. }),
  1025. });
  1026. render(
  1027. <ViewEditDashboard
  1028. {...RouteComponentPropsFixture()}
  1029. organization={initialData.organization}
  1030. params={{orgId: 'org-slug', dashboardId: '1', widgetId: 1}}
  1031. router={initialData.router}
  1032. location={{
  1033. ...initialData.router.location,
  1034. pathname: '/widget/1/',
  1035. query: {release: ['unsaved-release-filter@1.2.0']},
  1036. }}
  1037. >
  1038. {null}
  1039. </ViewEditDashboard>,
  1040. {router: initialData.router, organization: initialData.organization}
  1041. );
  1042. await waitFor(() => {
  1043. expect(openWidgetViewerModal).toHaveBeenCalledWith(
  1044. expect.objectContaining({
  1045. dashboardFilters: {release: ['unsaved-release-filter@1.2.0']},
  1046. })
  1047. );
  1048. });
  1049. });
  1050. it('can save dashboard filters in existing dashboard', async () => {
  1051. MockApiClient.addMockResponse({
  1052. url: '/organizations/org-slug/releases/',
  1053. body: [
  1054. ReleaseFixture({
  1055. shortVersion: 'sentry-android-shop@1.2.0',
  1056. version: 'sentry-android-shop@1.2.0',
  1057. }),
  1058. ],
  1059. });
  1060. const testData = initializeOrg({
  1061. organization: OrganizationFixture({
  1062. features: [
  1063. 'global-views',
  1064. 'dashboards-basic',
  1065. 'dashboards-edit',
  1066. 'discover-query',
  1067. ],
  1068. }),
  1069. router: {
  1070. location: {
  1071. ...LocationFixture(),
  1072. query: {
  1073. statsPeriod: '7d',
  1074. release: ['sentry-android-shop@1.2.0'],
  1075. },
  1076. },
  1077. },
  1078. });
  1079. render(
  1080. <ViewEditDashboard
  1081. {...RouteComponentPropsFixture()}
  1082. organization={testData.organization}
  1083. params={{orgId: 'org-slug', dashboardId: '1'}}
  1084. router={testData.router}
  1085. location={testData.router.location}
  1086. >
  1087. {null}
  1088. </ViewEditDashboard>,
  1089. {router: testData.router, organization: testData.organization}
  1090. );
  1091. await userEvent.click(await screen.findByText('Save'));
  1092. expect(mockPut).toHaveBeenCalledWith(
  1093. '/organizations/org-slug/dashboards/1/',
  1094. expect.objectContaining({
  1095. data: expect.objectContaining({
  1096. period: '7d',
  1097. filters: {release: ['sentry-android-shop@1.2.0']},
  1098. }),
  1099. })
  1100. );
  1101. });
  1102. it('can clear dashboard filters in compact select', async () => {
  1103. MockApiClient.addMockResponse({
  1104. url: '/organizations/org-slug/dashboards/1/',
  1105. body: DashboardFixture(widgets, {
  1106. id: '1',
  1107. title: 'Custom Errors',
  1108. filters: {release: ['sentry-android-shop@1.2.0']},
  1109. }),
  1110. });
  1111. MockApiClient.addMockResponse({
  1112. url: '/organizations/org-slug/releases/',
  1113. body: [
  1114. ReleaseFixture({
  1115. shortVersion: 'sentry-android-shop@1.2.0',
  1116. version: 'sentry-android-shop@1.2.0',
  1117. }),
  1118. ],
  1119. });
  1120. const testData = initializeOrg({
  1121. organization: OrganizationFixture({
  1122. features: [
  1123. 'global-views',
  1124. 'dashboards-basic',
  1125. 'dashboards-edit',
  1126. 'discover-query',
  1127. ],
  1128. }),
  1129. router: {
  1130. location: {
  1131. ...LocationFixture(),
  1132. query: {
  1133. statsPeriod: '7d',
  1134. },
  1135. },
  1136. },
  1137. });
  1138. render(
  1139. <ViewEditDashboard
  1140. {...RouteComponentPropsFixture()}
  1141. organization={testData.organization}
  1142. params={{orgId: 'org-slug', dashboardId: '1'}}
  1143. router={testData.router}
  1144. location={testData.router.location}
  1145. >
  1146. {null}
  1147. </ViewEditDashboard>,
  1148. {router: testData.router, organization: testData.organization}
  1149. );
  1150. await screen.findByText('7D');
  1151. await userEvent.click(await screen.findByText('sentry-android-shop@1.2.0'));
  1152. await userEvent.click(screen.getAllByText('Clear')[0]!);
  1153. screen.getByText('All Releases');
  1154. await userEvent.click(document.body);
  1155. await waitFor(() => {
  1156. expect(testData.router.push).toHaveBeenCalledWith(
  1157. expect.objectContaining({
  1158. query: expect.objectContaining({
  1159. release: '',
  1160. }),
  1161. })
  1162. );
  1163. });
  1164. });
  1165. it('can save absolute time range in existing dashboard', async () => {
  1166. const testData = initializeOrg({
  1167. organization: OrganizationFixture({
  1168. features: [
  1169. 'global-views',
  1170. 'dashboards-basic',
  1171. 'dashboards-edit',
  1172. 'discover-query',
  1173. ],
  1174. }),
  1175. router: {
  1176. location: {
  1177. ...LocationFixture(),
  1178. query: {
  1179. start: '2022-07-14T07:00:00',
  1180. end: '2022-07-19T23:59:59',
  1181. utc: 'true',
  1182. },
  1183. },
  1184. },
  1185. });
  1186. render(
  1187. <ViewEditDashboard
  1188. {...RouteComponentPropsFixture()}
  1189. organization={testData.organization}
  1190. params={{orgId: 'org-slug', dashboardId: '1'}}
  1191. router={testData.router}
  1192. location={testData.router.location}
  1193. >
  1194. {null}
  1195. </ViewEditDashboard>,
  1196. {router: testData.router, organization: testData.organization}
  1197. );
  1198. await userEvent.click(await screen.findByText('Save'));
  1199. expect(mockPut).toHaveBeenCalledWith(
  1200. '/organizations/org-slug/dashboards/1/',
  1201. expect.objectContaining({
  1202. data: expect.objectContaining({
  1203. start: '2022-07-14T07:00:00.000',
  1204. end: '2022-07-19T23:59:59.000',
  1205. utc: true,
  1206. }),
  1207. })
  1208. );
  1209. });
  1210. it('can clear dashboard filters in existing dashboard', async () => {
  1211. MockApiClient.addMockResponse({
  1212. url: '/organizations/org-slug/releases/',
  1213. body: [
  1214. ReleaseFixture({
  1215. shortVersion: 'sentry-android-shop@1.2.0',
  1216. version: 'sentry-android-shop@1.2.0',
  1217. }),
  1218. ],
  1219. });
  1220. const testData = initializeOrg({
  1221. organization: OrganizationFixture({
  1222. features: [
  1223. 'global-views',
  1224. 'dashboards-basic',
  1225. 'dashboards-edit',
  1226. 'discover-query',
  1227. ],
  1228. }),
  1229. router: {
  1230. location: {
  1231. ...LocationFixture(),
  1232. query: {
  1233. statsPeriod: '7d',
  1234. environment: ['alpha', 'beta'],
  1235. },
  1236. },
  1237. },
  1238. });
  1239. render(
  1240. <ViewEditDashboard
  1241. {...RouteComponentPropsFixture()}
  1242. organization={testData.organization}
  1243. params={{orgId: 'org-slug', dashboardId: '1'}}
  1244. router={testData.router}
  1245. location={testData.router.location}
  1246. >
  1247. {null}
  1248. </ViewEditDashboard>,
  1249. {router: testData.router, organization: testData.organization}
  1250. );
  1251. await screen.findByText('7D');
  1252. await userEvent.click(await screen.findByText('All Releases'));
  1253. await userEvent.click(screen.getByText('sentry-android-shop@1.2.0'));
  1254. await userEvent.keyboard('{Escape}');
  1255. await userEvent.click(screen.getByText('Cancel'));
  1256. screen.getByText('All Releases');
  1257. expect(testData.router.replace).toHaveBeenCalledWith(
  1258. expect.objectContaining({
  1259. query: expect.objectContaining({
  1260. project: undefined,
  1261. statsPeriod: undefined,
  1262. environment: undefined,
  1263. }),
  1264. })
  1265. );
  1266. });
  1267. it('disables the Edit Dashboard button when there are unsaved filters', async () => {
  1268. MockApiClient.addMockResponse({
  1269. url: '/organizations/org-slug/releases/',
  1270. body: [
  1271. ReleaseFixture({
  1272. shortVersion: 'sentry-android-shop@1.2.0',
  1273. version: 'sentry-android-shop@1.2.0',
  1274. }),
  1275. ],
  1276. });
  1277. const testData = initializeOrg({
  1278. organization: OrganizationFixture({
  1279. features: [
  1280. 'global-views',
  1281. 'dashboards-basic',
  1282. 'dashboards-edit',
  1283. 'discover-basic',
  1284. 'discover-query',
  1285. ],
  1286. }),
  1287. router: {
  1288. location: {
  1289. ...LocationFixture(),
  1290. query: {
  1291. statsPeriod: '7d',
  1292. environment: ['alpha', 'beta'],
  1293. },
  1294. },
  1295. },
  1296. });
  1297. render(
  1298. <ViewEditDashboard
  1299. {...RouteComponentPropsFixture()}
  1300. organization={testData.organization}
  1301. params={{orgId: 'org-slug', dashboardId: '1'}}
  1302. router={testData.router}
  1303. location={testData.router.location}
  1304. >
  1305. {null}
  1306. </ViewEditDashboard>,
  1307. {router: testData.router, organization: testData.organization}
  1308. );
  1309. expect(await screen.findByText('Save')).toBeInTheDocument();
  1310. expect(screen.getByText('Cancel')).toBeInTheDocument();
  1311. expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
  1312. });
  1313. it('ignores the order of selection of page filters to render unsaved filters', async () => {
  1314. const testProjects = [
  1315. ProjectFixture({id: '1', name: 'first', environments: ['alpha', 'beta']}),
  1316. ProjectFixture({id: '2', name: 'second', environments: ['alpha', 'beta']}),
  1317. ];
  1318. act(() => ProjectsStore.loadInitialData(testProjects));
  1319. MockApiClient.addMockResponse({
  1320. url: '/organizations/org-slug/projects/',
  1321. body: testProjects,
  1322. });
  1323. MockApiClient.addMockResponse({
  1324. url: '/organizations/org-slug/dashboards/1/',
  1325. body: DashboardFixture(widgets, {
  1326. id: '1',
  1327. title: 'Custom Errors',
  1328. filters: {},
  1329. environment: ['alpha', 'beta'],
  1330. }),
  1331. });
  1332. const testData = initializeOrg({
  1333. organization: OrganizationFixture({
  1334. features: [
  1335. 'global-views',
  1336. 'dashboards-basic',
  1337. 'dashboards-edit',
  1338. 'discover-query',
  1339. ],
  1340. }),
  1341. router: {
  1342. location: {
  1343. ...LocationFixture(),
  1344. query: {
  1345. environment: ['beta', 'alpha'], // Reversed order from saved dashboard
  1346. },
  1347. },
  1348. },
  1349. });
  1350. render(
  1351. <ViewEditDashboard
  1352. {...RouteComponentPropsFixture()}
  1353. organization={testData.organization}
  1354. params={{orgId: 'org-slug', dashboardId: '1'}}
  1355. router={testData.router}
  1356. location={testData.router.location}
  1357. >
  1358. {null}
  1359. </ViewEditDashboard>,
  1360. {router: testData.router, organization: testData.organization}
  1361. );
  1362. await waitFor(() => expect(screen.queryAllByText('Loading\u2026')).toEqual([]));
  1363. await userEvent.click(screen.getByRole('button', {name: 'All Envs'}));
  1364. expect(screen.getByRole('row', {name: 'alpha'})).toHaveAttribute(
  1365. 'aria-selected',
  1366. 'true'
  1367. );
  1368. expect(screen.getByRole('row', {name: 'beta'})).toHaveAttribute(
  1369. 'aria-selected',
  1370. 'true'
  1371. );
  1372. // Save and Cancel should not appear because alpha, beta is the same as beta, alpha
  1373. expect(screen.queryByText('Save')).not.toBeInTheDocument();
  1374. expect(screen.queryByText('Cancel')).not.toBeInTheDocument();
  1375. });
  1376. it('uses releases from the URL query params', async function () {
  1377. const testData = initializeOrg({
  1378. organization: OrganizationFixture({
  1379. features: [
  1380. 'global-views',
  1381. 'dashboards-basic',
  1382. 'dashboards-edit',
  1383. 'discover-query',
  1384. ],
  1385. }),
  1386. router: {
  1387. location: {
  1388. ...LocationFixture(),
  1389. query: {
  1390. release: ['not-selected-1'],
  1391. },
  1392. },
  1393. },
  1394. });
  1395. render(
  1396. <ViewEditDashboard
  1397. {...RouteComponentPropsFixture()}
  1398. organization={testData.organization}
  1399. params={{orgId: 'org-slug', dashboardId: '1'}}
  1400. router={testData.router}
  1401. location={testData.router.location}
  1402. >
  1403. {null}
  1404. </ViewEditDashboard>,
  1405. {router: testData.router, organization: testData.organization}
  1406. );
  1407. await screen.findByText(/not-selected-1/);
  1408. screen.getByText('Save');
  1409. screen.getByText('Cancel');
  1410. });
  1411. it('resets release in URL params', async function () {
  1412. MockApiClient.addMockResponse({
  1413. url: '/organizations/org-slug/dashboards/1/',
  1414. body: DashboardFixture(widgets, {
  1415. id: '1',
  1416. title: 'Custom Errors',
  1417. filters: {
  1418. release: ['abc'],
  1419. },
  1420. }),
  1421. });
  1422. const testData = initializeOrg({
  1423. organization: OrganizationFixture({
  1424. features: [
  1425. 'global-views',
  1426. 'dashboards-basic',
  1427. 'dashboards-edit',
  1428. 'discover-query',
  1429. ],
  1430. }),
  1431. router: {
  1432. location: {
  1433. ...LocationFixture(),
  1434. query: {
  1435. release: ['not-selected-1'],
  1436. },
  1437. },
  1438. },
  1439. });
  1440. render(
  1441. <ViewEditDashboard
  1442. {...RouteComponentPropsFixture()}
  1443. organization={testData.organization}
  1444. params={{orgId: 'org-slug', dashboardId: '1'}}
  1445. router={testData.router}
  1446. location={testData.router.location}
  1447. >
  1448. {null}
  1449. </ViewEditDashboard>,
  1450. {router: testData.router, organization: testData.organization}
  1451. );
  1452. await screen.findByText(/not-selected-1/);
  1453. await userEvent.click(screen.getByText('Cancel'));
  1454. // release isn't used in the redirect
  1455. expect(testData.router.replace).toHaveBeenCalledWith(
  1456. expect.objectContaining({
  1457. query: {
  1458. end: undefined,
  1459. environment: undefined,
  1460. project: undefined,
  1461. start: undefined,
  1462. statsPeriod: undefined,
  1463. utc: undefined,
  1464. },
  1465. })
  1466. );
  1467. });
  1468. it('reflects selections in the release filter in the query params', async function () {
  1469. MockApiClient.addMockResponse({
  1470. url: '/organizations/org-slug/releases/',
  1471. body: [
  1472. ReleaseFixture({
  1473. shortVersion: 'sentry-android-shop@1.2.0',
  1474. version: 'sentry-android-shop@1.2.0',
  1475. }),
  1476. ],
  1477. });
  1478. const testData = initializeOrg({
  1479. organization: OrganizationFixture({
  1480. features: [
  1481. 'global-views',
  1482. 'dashboards-basic',
  1483. 'dashboards-edit',
  1484. 'discover-query',
  1485. ],
  1486. }),
  1487. router: {
  1488. location: LocationFixture(),
  1489. },
  1490. });
  1491. render(
  1492. <ViewEditDashboard
  1493. {...RouteComponentPropsFixture()}
  1494. organization={testData.organization}
  1495. params={{orgId: 'org-slug', dashboardId: '1'}}
  1496. router={testData.router}
  1497. location={testData.router.location}
  1498. >
  1499. {null}
  1500. </ViewEditDashboard>,
  1501. {router: testData.router, organization: testData.organization}
  1502. );
  1503. await userEvent.click(await screen.findByText('All Releases'));
  1504. await userEvent.click(screen.getByText('sentry-android-shop@1.2.0'));
  1505. await userEvent.click(document.body);
  1506. await waitFor(() => {
  1507. expect(testData.router.push).toHaveBeenCalledWith(
  1508. expect.objectContaining({
  1509. query: expect.objectContaining({
  1510. release: ['sentry-android-shop@1.2.0'],
  1511. }),
  1512. })
  1513. );
  1514. });
  1515. });
  1516. it('persists release selections made during search requests that do not appear in default query', async function () {
  1517. // Default response
  1518. MockApiClient.addMockResponse({
  1519. url: '/organizations/org-slug/releases/',
  1520. body: [
  1521. ReleaseFixture({
  1522. shortVersion: 'sentry-android-shop@1.2.0',
  1523. version: 'sentry-android-shop@1.2.0',
  1524. }),
  1525. ],
  1526. });
  1527. // Mocked search results
  1528. MockApiClient.addMockResponse({
  1529. url: '/organizations/org-slug/releases/',
  1530. body: [
  1531. ReleaseFixture({
  1532. id: '9',
  1533. shortVersion: 'search-result',
  1534. version: 'search-result',
  1535. }),
  1536. ],
  1537. match: [MockApiClient.matchData({query: 's'})],
  1538. });
  1539. const testData = initializeOrg({
  1540. organization: OrganizationFixture({
  1541. features: [
  1542. 'global-views',
  1543. 'dashboards-basic',
  1544. 'dashboards-edit',
  1545. 'discover-basic',
  1546. 'discover-query',
  1547. ],
  1548. }),
  1549. router: {
  1550. location: LocationFixture(),
  1551. },
  1552. });
  1553. render(
  1554. <ViewEditDashboard
  1555. {...RouteComponentPropsFixture()}
  1556. organization={testData.organization}
  1557. params={{orgId: 'org-slug', dashboardId: '1'}}
  1558. router={testData.router}
  1559. location={testData.router.location}
  1560. >
  1561. {null}
  1562. </ViewEditDashboard>,
  1563. {router: testData.router, organization: testData.organization}
  1564. );
  1565. await userEvent.click(await screen.findByText('All Releases'));
  1566. await userEvent.type(screen.getAllByPlaceholderText('Search\u2026')[2]!, 's');
  1567. await userEvent.click(await screen.findByRole('option', {name: 'search-result'}));
  1568. // Validate that after search is cleared, search result still appears
  1569. expect(await screen.findByText('Latest Release(s)')).toBeInTheDocument();
  1570. expect(screen.getByRole('option', {name: 'search-result'})).toBeInTheDocument();
  1571. });
  1572. it('renders edit access selector', async function () {
  1573. render(
  1574. <EditAccessSelector
  1575. dashboard={DashboardFixture([], {id: '1', title: 'Custom Errors'})}
  1576. onChangeEditAccess={jest.fn()}
  1577. />,
  1578. {
  1579. router: initialData.router,
  1580. organization: {
  1581. ...initialData.organization,
  1582. features: ['dashboards-edit-access'],
  1583. },
  1584. }
  1585. );
  1586. await userEvent.click(await screen.findByText('Edit Access:'));
  1587. expect(screen.getByText('Creator')).toBeInTheDocument();
  1588. expect(screen.getByText('All users')).toBeInTheDocument();
  1589. });
  1590. it('creates and updates new permissions for dashboard with no edit perms initialized', async function () {
  1591. const mockPUT = MockApiClient.addMockResponse({
  1592. url: '/organizations/org-slug/dashboards/1/',
  1593. method: 'PUT',
  1594. body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
  1595. });
  1596. render(
  1597. <ViewEditDashboard
  1598. {...RouteComponentPropsFixture()}
  1599. organization={{
  1600. ...initialData.organization,
  1601. features: ['dashboards-edit-access', ...initialData.organization.features],
  1602. }}
  1603. params={{orgId: 'org-slug', dashboardId: '1'}}
  1604. router={initialData.router}
  1605. location={initialData.router.location}
  1606. >
  1607. {null}
  1608. </ViewEditDashboard>,
  1609. {
  1610. router: initialData.router,
  1611. organization: {
  1612. features: ['dashboards-edit-access', ...initialData.organization.features],
  1613. },
  1614. }
  1615. );
  1616. await userEvent.click(await screen.findByText('Edit Access:'));
  1617. // deselects 'All users' so only creator has edit access
  1618. expect(await screen.findByText('All users')).toBeEnabled();
  1619. expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
  1620. 'aria-selected',
  1621. 'true'
  1622. );
  1623. await userEvent.click(screen.getByRole('option', {name: 'All users'}));
  1624. expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
  1625. 'aria-selected',
  1626. 'false'
  1627. );
  1628. await userEvent.click(await screen.findByText('Save Changes'));
  1629. await waitFor(() => {
  1630. expect(mockPUT).toHaveBeenCalledTimes(1);
  1631. });
  1632. expect(mockPUT).toHaveBeenCalledWith(
  1633. '/organizations/org-slug/dashboards/1/',
  1634. expect.objectContaining({
  1635. data: expect.objectContaining({
  1636. permissions: {isEditableByEveryone: false, teamsWithEditAccess: []},
  1637. }),
  1638. })
  1639. );
  1640. });
  1641. it('creator can update permissions for dashboard', async function () {
  1642. const mockPUT = MockApiClient.addMockResponse({
  1643. url: '/organizations/org-slug/dashboards/1/',
  1644. method: 'PUT',
  1645. body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
  1646. });
  1647. MockApiClient.addMockResponse({
  1648. url: '/organizations/org-slug/dashboards/1/',
  1649. body: DashboardFixture([], {
  1650. id: '1',
  1651. title: 'Custom Errors',
  1652. createdBy: UserFixture({id: '781629'}),
  1653. permissions: {isEditableByEveryone: false},
  1654. }),
  1655. });
  1656. const currentUser = UserFixture({id: '781629'});
  1657. ConfigStore.set('user', currentUser);
  1658. render(
  1659. <ViewEditDashboard
  1660. {...RouteComponentPropsFixture()}
  1661. organization={{
  1662. ...initialData.organization,
  1663. features: ['dashboards-edit-access', ...initialData.organization.features],
  1664. }}
  1665. params={{orgId: 'org-slug', dashboardId: '1'}}
  1666. router={initialData.router}
  1667. location={initialData.router.location}
  1668. >
  1669. {null}
  1670. </ViewEditDashboard>,
  1671. {
  1672. router: initialData.router,
  1673. organization: {
  1674. features: ['dashboards-edit-access', ...initialData.organization.features],
  1675. },
  1676. }
  1677. );
  1678. await userEvent.click(await screen.findByText('Edit Access:'));
  1679. // selects 'All users' so everyone has edit access
  1680. expect(await screen.findByText('All users')).toBeEnabled();
  1681. expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
  1682. 'aria-selected',
  1683. 'false'
  1684. );
  1685. await userEvent.click(screen.getByRole('option', {name: 'All users'}));
  1686. expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
  1687. 'aria-selected',
  1688. 'true'
  1689. );
  1690. await userEvent.click(await screen.findByText('Save Changes'));
  1691. await waitFor(() => {
  1692. expect(mockPUT).toHaveBeenCalledTimes(1);
  1693. });
  1694. expect(mockPUT).toHaveBeenCalledWith(
  1695. '/organizations/org-slug/dashboards/1/',
  1696. expect.objectContaining({
  1697. data: expect.objectContaining({
  1698. permissions: {isEditableByEveryone: true, teamsWithEditAccess: []},
  1699. }),
  1700. })
  1701. );
  1702. });
  1703. it('creator can update permissions with teams for dashboard', async function () {
  1704. const mockPUT = MockApiClient.addMockResponse({
  1705. url: '/organizations/org-slug/dashboards/1/',
  1706. method: 'PUT',
  1707. body: DashboardFixture([], {id: '1', title: 'Custom Errors'}),
  1708. });
  1709. MockApiClient.addMockResponse({
  1710. url: '/organizations/org-slug/dashboards/1/',
  1711. body: DashboardFixture([], {
  1712. id: '1',
  1713. title: 'Custom Errors',
  1714. createdBy: UserFixture({id: '781629'}),
  1715. permissions: {isEditableByEveryone: false},
  1716. }),
  1717. });
  1718. const currentUser = UserFixture({id: '781629'});
  1719. ConfigStore.set('user', currentUser);
  1720. const teamData = [
  1721. {
  1722. id: '1',
  1723. slug: 'team1',
  1724. name: 'Team 1',
  1725. },
  1726. {
  1727. id: '2',
  1728. slug: 'team2',
  1729. name: 'Team 2',
  1730. },
  1731. {
  1732. id: '3',
  1733. slug: 'team3',
  1734. name: 'Team 3',
  1735. },
  1736. ];
  1737. const teams = teamData.map(data => TeamFixture(data));
  1738. TeamStore.loadInitialData(teams);
  1739. render(
  1740. <ViewEditDashboard
  1741. {...RouteComponentPropsFixture()}
  1742. organization={{
  1743. ...initialData.organization,
  1744. features: ['dashboards-edit-access', ...initialData.organization.features],
  1745. }}
  1746. params={{orgId: 'org-slug', dashboardId: '1'}}
  1747. router={initialData.router}
  1748. location={initialData.router.location}
  1749. >
  1750. {null}
  1751. </ViewEditDashboard>,
  1752. {
  1753. router: initialData.router,
  1754. organization: {
  1755. features: ['dashboards-edit-access', ...initialData.organization.features],
  1756. },
  1757. }
  1758. );
  1759. await userEvent.click(await screen.findByText('Edit Access:'));
  1760. expect(await screen.findByText('All users')).toBeEnabled();
  1761. expect(await screen.findByRole('option', {name: 'All users'})).toHaveAttribute(
  1762. 'aria-selected',
  1763. 'false'
  1764. );
  1765. await userEvent.click(screen.getByRole('option', {name: '#team1'}));
  1766. await userEvent.click(screen.getByRole('option', {name: '#team2'}));
  1767. await userEvent.click(await screen.findByText('Save Changes'));
  1768. await waitFor(() => {
  1769. expect(mockPUT).toHaveBeenCalledTimes(1);
  1770. });
  1771. expect(mockPUT).toHaveBeenCalledWith(
  1772. '/organizations/org-slug/dashboards/1/',
  1773. expect.objectContaining({
  1774. data: expect.objectContaining({
  1775. permissions: {isEditableByEveryone: false, teamsWithEditAccess: [1, 2]},
  1776. }),
  1777. })
  1778. );
  1779. });
  1780. it('disables edit dashboard and add widget button if user cannot edit dashboard', async function () {
  1781. MockApiClient.addMockResponse({
  1782. url: '/organizations/org-slug/dashboards/',
  1783. body: [
  1784. DashboardFixture([], {
  1785. id: '1',
  1786. title: 'Custom Errors',
  1787. createdBy: UserFixture({id: '238900'}),
  1788. permissions: {isEditableByEveryone: false},
  1789. }),
  1790. ],
  1791. });
  1792. MockApiClient.addMockResponse({
  1793. url: '/organizations/org-slug/dashboards/1/',
  1794. body: DashboardFixture([], {
  1795. id: '1',
  1796. title: 'Custom Errors',
  1797. createdBy: UserFixture({id: '238900'}),
  1798. permissions: {isEditableByEveryone: false},
  1799. }),
  1800. });
  1801. const currentUser = UserFixture({id: '781629', isSuperuser: false});
  1802. ConfigStore.set('user', currentUser);
  1803. render(
  1804. <ViewEditDashboard
  1805. {...RouteComponentPropsFixture()}
  1806. organization={{
  1807. ...initialData.organization,
  1808. features: ['dashboards-edit-access', ...initialData.organization.features],
  1809. access: ['org:read'],
  1810. }}
  1811. params={{orgId: 'org-slug', dashboardId: '1'}}
  1812. router={initialData.router}
  1813. location={initialData.router.location}
  1814. >
  1815. {null}
  1816. </ViewEditDashboard>,
  1817. {
  1818. router: initialData.router,
  1819. organization: {
  1820. features: ['dashboards-edit-access', ...initialData.organization.features],
  1821. access: ['org:read'],
  1822. },
  1823. }
  1824. );
  1825. await screen.findByText('Edit Access:');
  1826. expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
  1827. expect(screen.getByRole('button', {name: 'Add Widget'})).toBeDisabled();
  1828. });
  1829. it('disables widget edit, duplicate, and delete button when user does not have edit perms', async function () {
  1830. const widget = {
  1831. displayType: types.DisplayType.TABLE,
  1832. interval: '1d',
  1833. queries: [
  1834. {
  1835. name: 'Test Widget',
  1836. fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
  1837. columns: ['project'],
  1838. aggregates: ['count()', 'count_unique(user)', 'epm()'],
  1839. conditions: '',
  1840. orderby: '',
  1841. },
  1842. ],
  1843. title: 'Transactions',
  1844. id: '1',
  1845. widgetType: types.WidgetType.DISCOVER,
  1846. };
  1847. const mockDashboard = DashboardFixture([widget], {
  1848. id: '1',
  1849. title: 'Custom Errors',
  1850. createdBy: UserFixture({id: '238900'}),
  1851. permissions: {isEditableByEveryone: false},
  1852. });
  1853. MockApiClient.addMockResponse({
  1854. url: '/organizations/org-slug/dashboards/',
  1855. body: mockDashboard,
  1856. });
  1857. MockApiClient.addMockResponse({
  1858. url: '/organizations/org-slug/dashboards/1/',
  1859. body: mockDashboard,
  1860. });
  1861. const currentUser = UserFixture({id: '781629'});
  1862. ConfigStore.set('user', currentUser);
  1863. render(
  1864. <ViewEditDashboard
  1865. {...RouteComponentPropsFixture()}
  1866. organization={{
  1867. ...initialData.organization,
  1868. features: ['dashboards-edit-access', ...initialData.organization.features],
  1869. access: ['org:read'],
  1870. }}
  1871. params={{orgId: 'org-slug', dashboardId: '1'}}
  1872. router={initialData.router}
  1873. location={initialData.router.location}
  1874. >
  1875. {null}
  1876. </ViewEditDashboard>,
  1877. {
  1878. router: initialData.router,
  1879. organization: {
  1880. features: ['dashboards-edit-access', ...initialData.organization.features],
  1881. access: ['org:read'],
  1882. },
  1883. }
  1884. );
  1885. await screen.findByText('Edit Access:');
  1886. expect(screen.getByRole('button', {name: 'Edit Dashboard'})).toBeDisabled();
  1887. expect(screen.getByRole('button', {name: 'Add Widget'})).toBeDisabled();
  1888. await userEvent.click(await screen.findByLabelText('Widget actions'));
  1889. expect(
  1890. screen.getByRole('menuitemradio', {name: 'Duplicate Widget'})
  1891. ).toHaveAttribute('aria-disabled', 'true');
  1892. expect(screen.getByRole('menuitemradio', {name: 'Delete Widget'})).toHaveAttribute(
  1893. 'aria-disabled',
  1894. 'true'
  1895. );
  1896. expect(screen.getByRole('menuitemradio', {name: 'Edit Widget'})).toHaveAttribute(
  1897. 'aria-disabled',
  1898. 'true'
  1899. );
  1900. });
  1901. it('renders favorite button in unfavorited state', async function () {
  1902. MockApiClient.addMockResponse({
  1903. url: '/organizations/org-slug/dashboards/1/',
  1904. body: DashboardFixture([], {id: '1', title: 'Custom Errors', isFavorited: false}),
  1905. });
  1906. render(
  1907. <ViewEditDashboard
  1908. {...RouteComponentPropsFixture()}
  1909. organization={initialData.organization}
  1910. params={{orgId: 'org-slug', dashboardId: '1'}}
  1911. router={initialData.router}
  1912. location={initialData.router.location}
  1913. >
  1914. {null}
  1915. </ViewEditDashboard>,
  1916. {
  1917. router: initialData.router,
  1918. organization: {
  1919. features: ['dashboards-favourite', ...initialData.organization.features],
  1920. },
  1921. }
  1922. );
  1923. const favoriteButton = await screen.findByLabelText('dashboards-favourite');
  1924. expect(favoriteButton).toBeInTheDocument();
  1925. expect(await screen.findByLabelText('Favorite')).toBeInTheDocument();
  1926. });
  1927. it('renders favorite button in favorited state', async function () {
  1928. MockApiClient.addMockResponse({
  1929. url: '/organizations/org-slug/dashboards/1/',
  1930. body: DashboardFixture([], {id: '1', title: 'Custom Errors', isFavorited: true}),
  1931. });
  1932. render(
  1933. <ViewEditDashboard
  1934. {...RouteComponentPropsFixture()}
  1935. organization={initialData.organization}
  1936. params={{orgId: 'org-slug', dashboardId: '1'}}
  1937. router={initialData.router}
  1938. location={initialData.router.location}
  1939. >
  1940. {null}
  1941. </ViewEditDashboard>,
  1942. {
  1943. router: initialData.router,
  1944. organization: {
  1945. features: ['dashboards-favourite', ...initialData.organization.features],
  1946. },
  1947. }
  1948. );
  1949. const favoriteButton = await screen.findByLabelText('dashboards-favourite');
  1950. expect(favoriteButton).toBeInTheDocument();
  1951. expect(await screen.findByLabelText('UnFavorite')).toBeInTheDocument();
  1952. });
  1953. it('toggles favorite button', async function () {
  1954. MockApiClient.addMockResponse({
  1955. url: '/organizations/org-slug/dashboards/1/',
  1956. body: DashboardFixture([], {id: '1', title: 'Custom Errors', isFavorited: true}),
  1957. });
  1958. MockApiClient.addMockResponse({
  1959. url: '/organizations/org-slug/dashboards/1/favorite/',
  1960. method: 'PUT',
  1961. body: {isFavorited: false},
  1962. });
  1963. render(
  1964. <ViewEditDashboard
  1965. {...RouteComponentPropsFixture()}
  1966. organization={initialData.organization}
  1967. params={{orgId: 'org-slug', dashboardId: '1'}}
  1968. router={initialData.router}
  1969. location={initialData.router.location}
  1970. >
  1971. {null}
  1972. </ViewEditDashboard>,
  1973. {
  1974. router: initialData.router,
  1975. organization: {
  1976. features: ['dashboards-favourite', ...initialData.organization.features],
  1977. },
  1978. }
  1979. );
  1980. const favoriteButton = await screen.findByLabelText('dashboards-favourite');
  1981. expect(favoriteButton).toBeInTheDocument();
  1982. expect(await screen.findByLabelText('UnFavorite')).toBeInTheDocument();
  1983. await userEvent.click(favoriteButton);
  1984. expect(await screen.findByLabelText('Favorite')).toBeInTheDocument();
  1985. });
  1986. describe('widget builder redesign', function () {
  1987. let mockUpdateDashboard!: jest.SpyInstance;
  1988. beforeEach(function () {
  1989. initialData = initializeOrg({
  1990. organization: OrganizationFixture({
  1991. features: [
  1992. 'global-views',
  1993. 'dashboards-basic',
  1994. 'dashboards-edit',
  1995. 'discover-query',
  1996. 'performance-discover-dataset-selector',
  1997. 'dashboards-widget-builder-redesign',
  1998. ],
  1999. }),
  2000. });
  2001. // Mock just the updateDashboard function
  2002. mockUpdateDashboard = jest
  2003. .spyOn(dashboardActions, 'updateDashboard')
  2004. .mockResolvedValue({
  2005. ...DashboardFixture([WidgetFixture({id: '1', title: 'Custom Widget'})]),
  2006. });
  2007. jest.mocked(useWidgetBuilderState).mockReturnValue({
  2008. dispatch: jest.fn(),
  2009. state: {},
  2010. });
  2011. });
  2012. afterEach(() => {
  2013. mockUpdateDashboard.mockRestore();
  2014. });
  2015. it('opens the widget builder slideout when clicking add widget', async function () {
  2016. render(
  2017. <DashboardDetail
  2018. {...RouteComponentPropsFixture()}
  2019. initialState={DashboardState.VIEW}
  2020. dashboard={DashboardFixture([])}
  2021. dashboards={[]}
  2022. onDashboardUpdate={jest.fn()}
  2023. newWidget={undefined}
  2024. onSetNewWidget={() => {}}
  2025. />,
  2026. {organization: initialData.organization}
  2027. );
  2028. await userEvent.click(await screen.findByRole('button', {name: 'Add Widget'}));
  2029. expect(await screen.findByText('Create Custom Widget')).toBeInTheDocument();
  2030. });
  2031. it('opens the widget builder slideout when clicking add widget in edit mode', async function () {
  2032. render(
  2033. <DashboardDetail
  2034. {...RouteComponentPropsFixture()}
  2035. initialState={DashboardState.EDIT}
  2036. dashboard={DashboardFixture([])}
  2037. dashboards={[]}
  2038. onDashboardUpdate={jest.fn()}
  2039. newWidget={undefined}
  2040. onSetNewWidget={() => {}}
  2041. />,
  2042. {organization: initialData.organization}
  2043. );
  2044. await userEvent.click(await screen.findByTestId('widget-add'));
  2045. expect(await screen.findByText('Create Custom Widget')).toBeInTheDocument();
  2046. });
  2047. it('allows for editing a widget in edit mode', async function () {
  2048. const mockWidget = WidgetFixture({id: '1', title: 'Custom Widget'});
  2049. const mockDashboard = DashboardFixture([mockWidget], {
  2050. id: '1',
  2051. title: 'Custom Errors',
  2052. });
  2053. jest.mocked(useWidgetBuilderState).mockReturnValue({
  2054. dispatch: jest.fn(),
  2055. state: {
  2056. title: 'Updated Widget',
  2057. },
  2058. });
  2059. render(
  2060. <DashboardDetail
  2061. {...RouteComponentPropsFixture()}
  2062. initialState={DashboardState.EDIT}
  2063. dashboard={mockDashboard}
  2064. dashboards={[]}
  2065. onDashboardUpdate={jest.fn()}
  2066. newWidget={undefined}
  2067. onSetNewWidget={() => {}}
  2068. />,
  2069. {
  2070. organization: initialData.organization,
  2071. // Mock the widgetIndex param so it's available when the widget builder opens
  2072. router: {...initialData.router, params: {widgetIndex: '0'}},
  2073. }
  2074. );
  2075. expect(await screen.findByText('Custom Widget')).toBeInTheDocument();
  2076. await userEvent.click(await screen.findByRole('button', {name: 'Edit Widget'}));
  2077. expect(await screen.findByText('Edit Widget')).toBeInTheDocument();
  2078. await userEvent.click(screen.getByText('Update Widget'));
  2079. // The widget builder is closed after the widget is updated
  2080. await waitFor(() => {
  2081. expect(screen.queryByText('Edit Widget')).not.toBeInTheDocument();
  2082. });
  2083. // The widget is updated in the dashboard
  2084. expect(screen.getByText('Updated Widget')).toBeInTheDocument();
  2085. });
  2086. it('allows for creating a widget in edit mode', async function () {
  2087. const mockDashboard = DashboardFixture([], {
  2088. id: '1',
  2089. title: 'Custom Errors',
  2090. });
  2091. jest.mocked(useWidgetBuilderState).mockReturnValue({
  2092. dispatch: jest.fn(),
  2093. state: {
  2094. title: 'Totally new widget',
  2095. },
  2096. });
  2097. render(
  2098. <DashboardDetail
  2099. {...RouteComponentPropsFixture()}
  2100. initialState={DashboardState.EDIT}
  2101. dashboard={mockDashboard}
  2102. dashboards={[]}
  2103. onDashboardUpdate={jest.fn()}
  2104. newWidget={undefined}
  2105. onSetNewWidget={() => {}}
  2106. />,
  2107. {
  2108. organization: initialData.organization,
  2109. }
  2110. );
  2111. await userEvent.click(await screen.findByTestId('widget-add'));
  2112. expect(await screen.findByText('Create Custom Widget')).toBeInTheDocument();
  2113. await userEvent.click(screen.getByText('Add Widget'));
  2114. // The widget builder is closed after the widget is updated
  2115. await waitFor(() => {
  2116. expect(screen.queryByText('Create Custom Widget')).not.toBeInTheDocument();
  2117. });
  2118. // The widget is added in the dashboard
  2119. expect(screen.getByText('Totally new widget')).toBeInTheDocument();
  2120. });
  2121. it('allows for editing a widget in view mode', async function () {
  2122. const mockWidget = WidgetFixture({id: '1', title: 'Custom Widget'});
  2123. const mockDashboard = DashboardFixture([mockWidget], {
  2124. id: '1',
  2125. title: 'Custom Errors',
  2126. });
  2127. jest.mocked(useWidgetBuilderState).mockReturnValue({
  2128. dispatch: jest.fn(),
  2129. state: {
  2130. title: 'Updated Widget Title',
  2131. },
  2132. });
  2133. render(
  2134. <DashboardDetail
  2135. {...RouteComponentPropsFixture()}
  2136. initialState={DashboardState.VIEW}
  2137. dashboard={mockDashboard}
  2138. dashboards={[]}
  2139. onDashboardUpdate={jest.fn()}
  2140. newWidget={undefined}
  2141. onSetNewWidget={() => {}}
  2142. />,
  2143. {
  2144. organization: initialData.organization,
  2145. // Mock the widgetIndex param so it's available when the widget builder opens
  2146. router: {...initialData.router, params: {widgetIndex: '0'}},
  2147. }
  2148. );
  2149. expect(await screen.findByText('Custom Widget')).toBeInTheDocument();
  2150. await userEvent.click(await screen.findByLabelText('Widget actions'));
  2151. await userEvent.click(
  2152. await screen.findByRole('menuitemradio', {name: 'Edit Widget'})
  2153. );
  2154. expect(await screen.findByText('Edit Widget')).toBeInTheDocument();
  2155. await userEvent.click(screen.getByText('Update Widget'));
  2156. // The widget builder is closed after the widget is updated
  2157. await waitFor(() => {
  2158. expect(screen.queryByText('Edit Widget')).not.toBeInTheDocument();
  2159. });
  2160. // The update action is called with the updated widget
  2161. expect(mockUpdateDashboard).toHaveBeenCalledWith(
  2162. expect.anything(),
  2163. expect.anything(),
  2164. expect.objectContaining({
  2165. widgets: [expect.objectContaining({title: 'Updated Widget Title'})],
  2166. })
  2167. );
  2168. });
  2169. it('allows for creating a widget in view mode', async function () {
  2170. const mockDashboard = DashboardFixture([], {
  2171. id: '1',
  2172. title: 'Custom Errors',
  2173. });
  2174. jest.mocked(useWidgetBuilderState).mockReturnValue({
  2175. dispatch: jest.fn(),
  2176. state: {
  2177. title: 'Totally new widget',
  2178. },
  2179. });
  2180. render(
  2181. <DashboardDetail
  2182. {...RouteComponentPropsFixture()}
  2183. initialState={DashboardState.VIEW}
  2184. dashboard={mockDashboard}
  2185. dashboards={[]}
  2186. onDashboardUpdate={jest.fn()}
  2187. newWidget={undefined}
  2188. onSetNewWidget={() => {}}
  2189. />,
  2190. {
  2191. organization: initialData.organization,
  2192. }
  2193. );
  2194. await userEvent.click(await screen.findByRole('button', {name: 'Add Widget'}));
  2195. expect(await screen.findByText('Create Custom Widget')).toBeInTheDocument();
  2196. await userEvent.click(
  2197. await within(screen.getByTestId('widget-slideout')).findByText('Add Widget')
  2198. );
  2199. // The widget builder is closed after the widget is updated
  2200. await waitFor(() => {
  2201. expect(screen.queryByText('Create Custom Widget')).not.toBeInTheDocument();
  2202. });
  2203. // The update action is called with the new widget
  2204. expect(mockUpdateDashboard).toHaveBeenCalledWith(
  2205. expect.anything(),
  2206. expect.anything(),
  2207. expect.objectContaining({
  2208. widgets: [expect.objectContaining({title: 'Totally new widget'})],
  2209. })
  2210. );
  2211. });
  2212. });
  2213. describe('discover split', function () {
  2214. it('calls the dashboard callbacks with the correct widgetType for discover split', function () {
  2215. const widget = {
  2216. displayType: types.DisplayType.TABLE,
  2217. interval: '1d',
  2218. queries: [
  2219. {
  2220. name: 'Test Widget',
  2221. fields: ['count()', 'count_unique(user)', 'epm()', 'project'],
  2222. columns: ['project'],
  2223. aggregates: ['count()', 'count_unique(user)', 'epm()'],
  2224. conditions: '',
  2225. orderby: '',
  2226. },
  2227. ],
  2228. title: 'Transactions',
  2229. id: '1',
  2230. widgetType: types.WidgetType.DISCOVER,
  2231. };
  2232. const mockDashboard = DashboardFixture([widget], {
  2233. id: '1',
  2234. title: 'Custom Errors',
  2235. });
  2236. const mockModifiedDashboard = DashboardFixture([widget], {
  2237. id: '1',
  2238. title: 'Custom Errors',
  2239. });
  2240. const mockOnDashboardUpdate = jest.fn();
  2241. const mockStateSetter = jest
  2242. .fn()
  2243. .mockImplementation(fn => fn({modifiedDashboard: mockModifiedDashboard}));
  2244. handleUpdateDashboardSplit({
  2245. widgetId: '1',
  2246. splitDecision: types.WidgetType.ERRORS,
  2247. dashboard: mockDashboard,
  2248. modifiedDashboard: mockModifiedDashboard,
  2249. onDashboardUpdate: mockOnDashboardUpdate,
  2250. stateSetter: mockStateSetter,
  2251. });
  2252. expect(mockOnDashboardUpdate).toHaveBeenCalledWith({
  2253. ...mockDashboard,
  2254. widgets: [{...widget, widgetType: types.WidgetType.ERRORS}],
  2255. });
  2256. expect(mockStateSetter).toHaveReturnedWith({
  2257. modifiedDashboard: {
  2258. ...mockModifiedDashboard,
  2259. widgets: [{...widget, widgetType: types.WidgetType.ERRORS}],
  2260. },
  2261. });
  2262. });
  2263. });
  2264. });
  2265. });