123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299 |
- import selectEvent from 'react-select-event';
- import {urlEncode} from '@sentry/utils';
- import {MetricsFieldFixture} from 'sentry-fixture/metrics';
- import {SessionsFieldFixture} from 'sentry-fixture/sessions';
- import {TagsFixture} from 'sentry-fixture/tags';
- import {initializeOrg} from 'sentry-test/initializeOrg';
- import {
- render,
- screen,
- userEvent,
- waitFor,
- within,
- } from 'sentry-test/reactTestingLibrary';
- import ProjectsStore from 'sentry/stores/projectsStore';
- import TagStore from 'sentry/stores/tagStore';
- import type {DashboardDetails, Widget} from 'sentry/views/dashboards/types';
- import {
- DashboardWidgetSource,
- DisplayType,
- WidgetType,
- } from 'sentry/views/dashboards/types';
- import type {WidgetBuilderProps} from 'sentry/views/dashboards/widgetBuilder';
- import WidgetBuilder from 'sentry/views/dashboards/widgetBuilder';
- const defaultOrgFeatures = [
- 'performance-view',
- 'dashboards-edit',
- 'global-views',
- 'dashboards-mep',
- 'dashboards-rh-widget',
- ];
- function mockDashboard(dashboard: Partial<DashboardDetails>): DashboardDetails {
- return {
- id: '1',
- title: 'Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- ...dashboard,
- };
- }
- function renderTestComponent({
- dashboard,
- query,
- orgFeatures,
- onSave,
- params,
- }: {
- dashboard?: WidgetBuilderProps['dashboard'];
- onSave?: WidgetBuilderProps['onSave'];
- orgFeatures?: string[];
- params?: Partial<WidgetBuilderProps['params']>;
- query?: Record<string, any>;
- } = {}) {
- const {organization, router, routerContext} = initializeOrg({
- organization: {
- features: orgFeatures ?? defaultOrgFeatures,
- },
- router: {
- location: {
- query: {
- source: DashboardWidgetSource.DASHBOARDS,
- ...query,
- },
- },
- },
- });
- ProjectsStore.loadInitialData(organization.projects);
- render(
- <WidgetBuilder
- route={{}}
- router={router}
- routes={router.routes}
- routeParams={router.params}
- location={router.location}
- dashboard={{
- id: 'new',
- title: 'Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- ...dashboard,
- }}
- onSave={onSave ?? jest.fn()}
- params={{
- orgId: organization.slug,
- dashboardId: dashboard?.id ?? 'new',
- ...params,
- }}
- />,
- {
- context: routerContext,
- organization,
- }
- );
- return {router};
- }
- describe('WidgetBuilder', function () {
- const untitledDashboard: DashboardDetails = {
- id: '1',
- title: 'Untitled Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- };
- const testDashboard: DashboardDetails = {
- id: '2',
- title: 'Test Dashboard',
- createdBy: undefined,
- dateCreated: '2020-01-01T00:00:00.000Z',
- widgets: [],
- projects: [],
- filters: {},
- };
- let eventsMock: jest.Mock | undefined;
- let sessionsDataMock: jest.Mock | undefined;
- let metricsDataMock: jest.Mock | undefined;
- let measurementsMetaMock: jest.Mock | undefined;
- beforeEach(function () {
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/',
- body: [
- {...untitledDashboard, widgetDisplay: [DisplayType.TABLE]},
- {...testDashboard, widgetDisplay: [DisplayType.AREA]},
- ],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/dashboards/widgets/',
- method: 'POST',
- statusCode: 200,
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/eventsv2/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {},
- data: [],
- },
- });
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {fields: {}},
- data: [],
- },
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/projects/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/recent-searches/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/recent-searches/',
- method: 'POST',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/issues/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events-stats/',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/event.type/values/',
- body: [{count: 2, name: 'Nvidia 1080ti'}],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/users/',
- body: [],
- });
- sessionsDataMock = MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/sessions/',
- body: SessionsFieldFixture(`sum(session)`),
- });
- metricsDataMock = MockApiClient.addMockResponse({
- method: 'GET',
- url: '/organizations/org-slug/metrics/data/',
- body: MetricsFieldFixture('session.all'),
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/',
- method: 'GET',
- body: TagsFixture(),
- });
- measurementsMetaMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/measurements-meta/',
- method: 'GET',
- body: {},
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/tags/is/values/',
- method: 'GET',
- body: [],
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/metrics-compatibility/',
- method: 'GET',
- body: {
- incompatible_projects: [],
- compatible_projects: [1],
- },
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/metrics-compatibility-sums/',
- method: 'GET',
- body: {
- sum: {
- metrics: 988803,
- metrics_null: 0,
- metrics_unparam: 132,
- },
- },
- });
- MockApiClient.addMockResponse({
- url: '/organizations/org-slug/releases/',
- body: [],
- });
- TagStore.reset();
- });
- afterEach(function () {
- MockApiClient.clearMockResponses();
- jest.clearAllMocks();
- jest.useRealTimers();
- });
- describe('Release Widgets', function () {
- it('shows the Release Health dataset', async function () {
- renderTestComponent();
- expect(await screen.findByText('Errors and Transactions')).toBeInTheDocument();
- expect(screen.getByText('Releases (Sessions, Crash rates)')).toBeInTheDocument();
- });
- it('maintains the selected dataset when display type is changed', async function () {
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- expect(screen.getByRole('radio', {name: /Releases/i})).not.toBeChecked();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}));
- await waitFor(() =>
- expect(screen.getByRole('radio', {name: /Releases/i})).toBeChecked()
- );
- await userEvent.click(screen.getByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- await waitFor(() =>
- expect(screen.getByRole('radio', {name: /Releases/i})).toBeChecked()
- );
- });
- it('displays releases tags', async function () {
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}));
- expect(screen.getByText('crash_free_rate(…)')).toBeInTheDocument();
- expect(screen.getByText('session')).toBeInTheDocument();
- await userEvent.click(screen.getByText('crash_free_rate(…)'));
- expect(screen.getByText('count_unique(…)')).toBeInTheDocument();
- expect(screen.getByText('release')).toBeInTheDocument();
- expect(screen.getByText('environment')).toBeInTheDocument();
- expect(screen.getByText('session.status')).toBeInTheDocument();
- await userEvent.click(screen.getByText('count_unique(…)'));
- expect(screen.getByText('user')).toBeInTheDocument();
- });
- it('does not display tags as params', async function () {
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}));
- expect(screen.getByText('crash_free_rate(…)')).toBeInTheDocument();
- await selectEvent.select(screen.getByText('crash_free_rate(…)'), 'count_unique(…)');
- await userEvent.click(screen.getByText('user'));
- expect(screen.queryByText('release')).not.toBeInTheDocument();
- expect(screen.queryByText('environment')).not.toBeInTheDocument();
- expect(screen.queryByText('session.status')).not.toBeInTheDocument();
- });
- it('does not allow sort by when session.status is selected', async function () {
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}));
- expect(screen.getByText('High to low')).toBeEnabled();
- expect(screen.getByText('crash_free_rate(session)')).toBeInTheDocument();
- await userEvent.click(screen.getByLabelText('Add a Column'));
- await selectEvent.select(screen.getByText('(Required)'), 'session.status');
- expect(screen.getByRole('textbox', {name: 'Sort direction'})).toBeDisabled();
- expect(screen.getByRole('textbox', {name: 'Sort by'})).toBeDisabled();
- });
- it('does not allow sort on tags except release', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}), {
- delay: null,
- });
- expect(
- within(screen.getByTestId('sort-by-step')).getByText('High to low')
- ).toBeEnabled();
- expect(
- within(screen.getByTestId('sort-by-step')).getByText('crash_free_rate(session)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByLabelText('Add a Column'), {delay: null});
- await selectEvent.select(screen.getByText('(Required)'), 'release');
- await userEvent.click(screen.getByLabelText('Add a Column'), {delay: null});
- await selectEvent.select(screen.getByText('(Required)'), 'environment');
- expect(await screen.findByText('Sort by a column')).toBeInTheDocument();
- // Selector "sortDirection"
- expect(screen.getByText('High to low')).toBeInTheDocument();
- // Selector "sortBy"
- await userEvent.click(screen.getAllByText('crash_free_rate(session)')[1], {
- delay: null,
- });
- // release exists in sort by selector
- expect(screen.getAllByText('release')).toHaveLength(3);
- // environment does not exist in sort by selector
- expect(screen.getAllByText('environment')).toHaveLength(2);
- });
- it('makes the appropriate sessions call', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}), {
- delay: null,
- });
- await userEvent.click(screen.getByText('Table'), {delay: null});
- await userEvent.click(screen.getByText('Line Chart'), {delay: null});
- await waitFor(() =>
- expect(metricsDataMock).toHaveBeenLastCalledWith(
- `/organizations/org-slug/metrics/data/`,
- expect.objectContaining({
- query: expect.objectContaining({
- environment: [],
- field: [`session.crash_free_rate`],
- groupBy: [],
- interval: '5m',
- project: [],
- statsPeriod: '24h',
- }),
- })
- )
- );
- });
- it('calls the session endpoint with the right limit', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}), {
- delay: null,
- });
- await userEvent.click(screen.getByText('Table'), {delay: null});
- await userEvent.click(screen.getByText('Line Chart'), {delay: null});
- await selectEvent.select(await screen.findByText('Select group'), 'project');
- expect(screen.getByText('Limit to 5 results')).toBeInTheDocument();
- await waitFor(() =>
- expect(metricsDataMock).toHaveBeenLastCalledWith(
- `/organizations/org-slug/metrics/data/`,
- expect.objectContaining({
- query: expect.objectContaining({
- environment: [],
- field: ['session.crash_free_rate'],
- groupBy: ['project_id'],
- interval: '5m',
- orderBy: '-session.crash_free_rate',
- per_page: 5,
- project: [],
- statsPeriod: '24h',
- }),
- })
- )
- );
- });
- it('calls sessions api when session.status is selected as a groupby', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}), {
- delay: null,
- });
- await userEvent.click(screen.getByText('Table'), {delay: null});
- await userEvent.click(screen.getByText('Line Chart'), {delay: null});
- await selectEvent.select(await screen.findByText('Select group'), 'session.status');
- expect(screen.getByText('Limit to 5 results')).toBeInTheDocument();
- await waitFor(() =>
- expect(sessionsDataMock).toHaveBeenLastCalledWith(
- `/organizations/org-slug/sessions/`,
- expect.objectContaining({
- query: expect.objectContaining({
- environment: [],
- field: ['crash_free_rate(session)'],
- groupBy: ['session.status'],
- interval: '5m',
- project: [],
- statsPeriod: '24h',
- }),
- })
- )
- );
- });
- it('displays the correct options for area chart', async function () {
- renderTestComponent();
- expect(
- await screen.findByText('Releases (Sessions, Crash rates)')
- ).toBeInTheDocument();
- // change dataset to releases
- await userEvent.click(screen.getByRole('radio', {name: /Releases/i}));
- await userEvent.click(screen.getByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- expect(screen.getByText('crash_free_rate(…)')).toBeInTheDocument();
- expect(screen.getByText(`session`)).toBeInTheDocument();
- await userEvent.click(screen.getByText('crash_free_rate(…)'));
- expect(screen.getByText('count_unique(…)')).toBeInTheDocument();
- await userEvent.click(screen.getByText('count_unique(…)'));
- expect(screen.getByText('user')).toBeInTheDocument();
- });
- it('sets widgetType to release', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- await userEvent.click(await screen.findByText('Releases (Sessions, Crash rates)'), {
- delay: null,
- });
- expect(metricsDataMock).toHaveBeenCalled();
- expect(screen.getByRole('radio', {name: /Releases/i})).toBeChecked();
- });
- it('does not display "add an equation" button', async function () {
- const widget: Widget = {
- title: 'Release Widget',
- displayType: DisplayType.TABLE,
- widgetType: WidgetType.RELEASE,
- queries: [
- {
- name: 'errors',
- conditions: '',
- fields: ['session.crash_free_rate'],
- columns: ['scount_abnormal(session)'],
- aggregates: ['session.crash_free_rate'],
- orderby: '-session.crash_free_rate',
- },
- ],
- interval: '1d',
- id: '1',
- };
- const dashboard = mockDashboard({widgets: [widget]});
- renderTestComponent({
- dashboard,
- params: {
- widgetIndex: '0',
- },
- });
- // Select line chart display
- await userEvent.click(await screen.findByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- await waitFor(() =>
- expect(screen.queryByLabelText('Add an Equation')).not.toBeInTheDocument()
- );
- });
- it('renders with a release search bar', async function () {
- renderTestComponent();
- await userEvent.type(
- await screen.findByPlaceholderText('Search for events, users, tags, and more'),
- 'session.status:'
- );
- await waitFor(() => {
- expect(screen.getByText("The field isn't supported here.")).toBeInTheDocument();
- });
- await userEvent.click(screen.getByText('Releases (Sessions, Crash rates)'));
- await userEvent.click(
- screen.getByPlaceholderText(
- 'Search for release version, session status, and more'
- )
- );
- expect(await screen.findByText('environment')).toBeInTheDocument();
- expect(screen.getByText('project')).toBeInTheDocument();
- expect(screen.getByText('release')).toBeInTheDocument();
- });
- it('adds a function when the only column chosen in a table is a tag', async function () {
- jest.useFakeTimers().setSystemTime(new Date('2022-08-02'));
- renderTestComponent();
- await userEvent.click(await screen.findByText('Releases (Sessions, Crash rates)'), {
- delay: null,
- });
- await selectEvent.select(screen.getByText('crash_free_rate(…)'), 'environment');
- // 1 in the table header, 1 in the column selector, and 1 in the sort by
- expect(screen.getAllByText(/crash_free_rate/)).toHaveLength(3);
- expect(screen.getAllByText('environment')).toHaveLength(2);
- });
- });
- describe('Issue Widgets', function () {
- it('sets widgetType to issues', async function () {
- const handleSave = jest.fn();
- renderTestComponent({onSave: handleSave});
- await userEvent.click(
- await screen.findByText('Issues (States, Assignment, Time, etc.)')
- );
- await userEvent.click(screen.getByLabelText('Add Widget'));
- await waitFor(() => {
- expect(handleSave).toHaveBeenCalledWith([
- expect.objectContaining({
- title: 'Custom Widget',
- displayType: DisplayType.TABLE,
- interval: '5m',
- widgetType: WidgetType.ISSUE,
- queries: [
- {
- conditions: '',
- fields: ['issue', 'assignee', 'title'],
- columns: ['issue', 'assignee', 'title'],
- aggregates: [],
- fieldAliases: [],
- name: '',
- orderby: 'date',
- },
- ],
- }),
- ]);
- });
- expect(handleSave).toHaveBeenCalledTimes(1);
- });
- it('render issues dataset disabled when the display type is not set to table', async function () {
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- },
- });
- await userEvent.click(await screen.findByText('Table'));
- await userEvent.click(screen.getByText('Line Chart'));
- expect(
- screen.getByRole('radio', {
- name: 'Errors and Transactions',
- })
- ).toBeEnabled();
- expect(
- screen.getByRole('radio', {
- name: 'Issues (States, Assignment, Time, etc.)',
- })
- ).toBeDisabled();
- });
- it('disables moving and deleting issue column', async function () {
- renderTestComponent();
- await userEvent.click(
- await screen.findByText('Issues (States, Assignment, Time, etc.)')
- );
- expect(
- within(screen.getByTestId('choose-column-step')).getByText('issue')
- ).toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).getByText('assignee')
- ).toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).getByText('title')
- ).toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).getAllByLabelText(
- 'Remove column'
- )
- ).toHaveLength(2);
- expect(
- within(screen.getByTestId('choose-column-step')).getAllByLabelText(
- 'Drag to reorder'
- )
- ).toHaveLength(3);
- await userEvent.click(screen.getAllByLabelText('Remove column')[1]);
- await userEvent.click(screen.getAllByLabelText('Remove column')[0]);
- expect(
- within(screen.getByTestId('choose-column-step')).getByText('issue')
- ).toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).queryByText('assignee')
- ).not.toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).queryByText('title')
- ).not.toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).queryByLabelText('Remove column')
- ).not.toBeInTheDocument();
- expect(
- within(screen.getByTestId('choose-column-step')).queryByLabelText(
- 'Drag to reorder'
- )
- ).not.toBeInTheDocument();
- });
- it('issue query does not work on default search bar', async function () {
- renderTestComponent();
- const input = (await screen.findByPlaceholderText(
- 'Search for events, users, tags, and more'
- )) as HTMLTextAreaElement;
- await userEvent.type(input, 'bookmarks');
- input.setSelectionRange(9, 9);
- expect(await screen.findByText('No items found')).toBeInTheDocument();
- });
- it('renders with an issues search bar when selected in dataset selection', async function () {
- renderTestComponent();
- await userEvent.click(
- await screen.findByText('Issues (States, Assignment, Time, etc.)')
- );
- const input = (await screen.findByPlaceholderText(
- 'Search for issues, status, assigned, and more'
- )) as HTMLTextAreaElement;
- await userEvent.type(input, 'is:');
- input.setSelectionRange(3, 3);
- expect(await screen.findByText('resolved')).toBeInTheDocument();
- });
- it('Update table header values (field alias)', async function () {
- const handleSave = jest.fn();
- renderTestComponent({
- onSave: handleSave,
- });
- await screen.findByText('Table');
- await userEvent.click(screen.getByText('Issues (States, Assignment, Time, etc.)'));
- await userEvent.type(screen.getAllByPlaceholderText('Alias')[0], 'First Alias');
- await userEvent.click(screen.getByText('Add Widget'));
- await waitFor(() => {
- expect(handleSave).toHaveBeenCalledWith([
- expect.objectContaining({
- queries: [
- expect.objectContaining({
- fieldAliases: ['First Alias', '', ''],
- }),
- ],
- }),
- ]);
- });
- });
- });
- describe('Events Widgets', function () {
- describe('Custom Performance Metrics', function () {
- it('can choose a custom measurement', async function () {
- measurementsMetaMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/measurements-meta/',
- method: 'GET',
- body: {'measurements.custom.measurement': {functions: ['p99']}},
- });
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.total.db.calls)': 'duration'},
- isMetricsData: true,
- },
- data: [{'p99(measurements.total.db.calls)': 10}],
- },
- });
- const {router} = renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: testDashboard,
- orgFeatures: [...defaultOrgFeatures],
- });
- expect(await screen.findByText('Custom Widget')).toBeInTheDocument();
- // 1 in the table header, 1 in the column selector, 1 in the sort field
- const countFields = screen.getAllByText('count()');
- expect(countFields).toHaveLength(3);
- await selectEvent.select(countFields[1], ['p99(…)']);
- await selectEvent.select(screen.getByText('transaction.duration'), [
- 'measurements.custom.measurement',
- ]);
- await userEvent.click(screen.getByText('Add Widget'));
- await waitFor(() => {
- expect(router.push).toHaveBeenCalledWith(
- expect.objectContaining({
- pathname: '/organizations/org-slug/dashboard/2/',
- query: {
- displayType: 'table',
- interval: '5m',
- title: 'Custom Widget',
- queryNames: [''],
- queryConditions: [''],
- queryFields: ['p99(measurements.custom.measurement)'],
- queryOrderby: '-p99(measurements.custom.measurement)',
- start: null,
- end: null,
- statsPeriod: '24h',
- utc: null,
- project: [],
- environment: [],
- },
- })
- );
- });
- });
- it('raises an alert banner but allows saving widget if widget result is not metrics data and widget is using custom measurements', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.custom.measurement)': 'duration'},
- isMetricsData: false,
- },
- data: [{'p99(measurements.custom.measurement)': 10}],
- },
- });
- const defaultWidgetQuery = {
- name: '',
- fields: ['p99(measurements.custom.measurement)'],
- columns: [],
- aggregates: ['p99(measurements.custom.measurement)'],
- conditions: 'user:test.user@sentry.io',
- orderby: '',
- };
- const defaultTableColumns = ['p99(measurements.custom.measurement)'];
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- displayType: DisplayType.TABLE,
- defaultTableColumns,
- },
- orgFeatures: [
- ...defaultOrgFeatures,
- 'dashboards-mep',
- 'dynamic-sampling',
- 'mep-rollout-flag',
- ],
- });
- await waitFor(() => {
- expect(measurementsMetaMock).toHaveBeenCalled();
- });
- await waitFor(() => {
- expect(eventsMock).toHaveBeenCalled();
- });
- screen.getByText('Your selection is only applicable to', {exact: false});
- expect(screen.getByText('Add Widget').closest('button')).toBeEnabled();
- });
- it('raises an alert banner if widget result is not metrics data', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.lcp)': 'duration'},
- isMetricsData: false,
- },
- data: [{'p99(measurements.lcp)': 10}],
- },
- });
- const defaultWidgetQuery = {
- name: '',
- fields: ['p99(measurements.lcp)'],
- columns: [],
- aggregates: ['p99(measurements.lcp)'],
- conditions: 'user:test.user@sentry.io',
- orderby: '',
- };
- const defaultTableColumns = ['p99(measurements.lcp)'];
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- displayType: DisplayType.TABLE,
- defaultTableColumns,
- },
- orgFeatures: [
- ...defaultOrgFeatures,
- 'dashboards-mep',
- 'dynamic-sampling',
- 'mep-rollout-flag',
- ],
- });
- await waitFor(() => {
- expect(measurementsMetaMock).toHaveBeenCalled();
- });
- await waitFor(() => {
- expect(eventsMock).toHaveBeenCalled();
- });
- screen.getByText('Your selection is only applicable to', {exact: false});
- });
- it('does not raise an alert banner if widget result is not metrics data but widget contains error fields', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.lcp)': 'duration'},
- isMetricsData: false,
- },
- data: [{'p99(measurements.lcp)': 10}],
- },
- });
- const defaultWidgetQuery = {
- name: '',
- fields: ['p99(measurements.lcp)'],
- columns: ['error.handled'],
- aggregates: ['p99(measurements.lcp)'],
- conditions: 'user:test.user@sentry.io',
- orderby: '',
- };
- const defaultTableColumns = ['p99(measurements.lcp)'];
- renderTestComponent({
- query: {
- source: DashboardWidgetSource.DISCOVERV2,
- defaultWidgetQuery: urlEncode(defaultWidgetQuery),
- displayType: DisplayType.TABLE,
- defaultTableColumns,
- },
- orgFeatures: [...defaultOrgFeatures, 'dashboards-mep'],
- });
- await waitFor(() => {
- expect(measurementsMetaMock).toHaveBeenCalled();
- });
- await waitFor(() => {
- expect(eventsMock).toHaveBeenCalled();
- });
- expect(
- screen.queryByText('Your selection is only applicable to', {exact: false})
- ).not.toBeInTheDocument();
- });
- it('only displays custom measurements in supported functions', async function () {
- measurementsMetaMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/measurements-meta/',
- method: 'GET',
- body: {
- 'measurements.custom.measurement': {functions: ['p99']},
- 'measurements.another.custom.measurement': {functions: ['p95']},
- },
- });
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: testDashboard,
- orgFeatures: [...defaultOrgFeatures],
- });
- expect(await screen.findByText('Custom Widget')).toBeInTheDocument();
- await selectEvent.select(screen.getAllByText('count()')[1], ['p99(…)']);
- await userEvent.click(screen.getByText('transaction.duration'));
- screen.getByText('measurements.custom.measurement');
- expect(
- screen.queryByText('measurements.another.custom.measurement')
- ).not.toBeInTheDocument();
- await selectEvent.select(screen.getAllByText('p99(…)')[0], ['p95(…)']);
- await userEvent.click(screen.getByText('transaction.duration'));
- screen.getByText('measurements.another.custom.measurement');
- expect(
- screen.queryByText('measurements.custom.measurement')
- ).not.toBeInTheDocument();
- });
- it('renders custom performance metric using duration units from events meta', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.custom.measurement)': 'duration'},
- isMetricsData: true,
- units: {'p99(measurements.custom.measurement)': 'hour'},
- },
- data: [{'p99(measurements.custom.measurement)': 12}],
- },
- });
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: ['p99(measurements.custom.measurement)'],
- columns: [],
- aggregates: ['p99(measurements.custom.measurement)'],
- orderby: '-p99(measurements.custom.measurement)',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- await screen.findByText('12.00hr');
- });
- it('renders custom performance metric using size units from events meta', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.custom.measurement)': 'size'},
- isMetricsData: true,
- units: {'p99(measurements.custom.measurement)': 'kibibyte'},
- },
- data: [{'p99(measurements.custom.measurement)': 12}],
- },
- });
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: ['p99(measurements.custom.measurement)'],
- columns: [],
- aggregates: ['p99(measurements.custom.measurement)'],
- orderby: '-p99(measurements.custom.measurement)',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- await screen.findByText('12.0 KiB');
- });
- it('renders custom performance metric using abyte format size units from events meta', async function () {
- eventsMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/events/',
- method: 'GET',
- statusCode: 200,
- body: {
- meta: {
- fields: {'p99(measurements.custom.measurement)': 'size'},
- isMetricsData: true,
- units: {'p99(measurements.custom.measurement)': 'kilobyte'},
- },
- data: [{'p99(measurements.custom.measurement)': 12000}],
- },
- });
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: ['p99(measurements.custom.measurement)'],
- columns: [],
- aggregates: ['p99(measurements.custom.measurement)'],
- orderby: '-p99(measurements.custom.measurement)',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- await screen.findByText('12 MB');
- });
- it('displays saved custom performance metric in column select', async function () {
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: ['p99(measurements.custom.measurement)'],
- columns: [],
- aggregates: ['p99(measurements.custom.measurement)'],
- orderby: '-p99(measurements.custom.measurement)',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- await screen.findByText('measurements.custom.measurement');
- });
- it('displays custom performance metric in column select dropdown', async function () {
- measurementsMetaMock = MockApiClient.addMockResponse({
- url: '/organizations/org-slug/measurements-meta/',
- method: 'GET',
- body: {'measurements.custom.measurement': {functions: ['p99']}},
- });
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: ['transaction', 'count()'],
- columns: ['transaction'],
- aggregates: ['count()'],
- orderby: '-count()',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- await screen.findByText('transaction');
- await userEvent.click(screen.getAllByText('count()')[1]);
- expect(screen.getByText('measurements.custom.measurement')).toBeInTheDocument();
- });
- it('does not default to sorting by transaction when columns change', async function () {
- renderTestComponent({
- query: {source: DashboardWidgetSource.DISCOVERV2},
- dashboard: {
- ...testDashboard,
- widgets: [
- {
- title: 'Custom Measurement Widget',
- interval: '1d',
- id: '1',
- widgetType: WidgetType.DISCOVER,
- displayType: DisplayType.TABLE,
- queries: [
- {
- conditions: '',
- name: '',
- fields: [
- 'p99(measurements.custom.measurement)',
- 'transaction',
- 'count()',
- ],
- columns: ['transaction'],
- aggregates: ['p99(measurements.custom.measurement)', 'count()'],
- orderby: '-p99(measurements.custom.measurement)',
- },
- ],
- },
- ],
- },
- params: {
- widgetIndex: '0',
- },
- orgFeatures: [...defaultOrgFeatures],
- });
- expect(
- await screen.findByText('p99(measurements.custom.measurement)')
- ).toBeInTheDocument();
- // Delete p99(measurements.custom.measurement) column
- await userEvent.click(screen.getAllByLabelText('Remove column')[0]);
- expect(
- screen.queryByText('p99(measurements.custom.measurement)')
- ).not.toBeInTheDocument();
- expect(
- within(screen.getByTestId('sort-by-step')).queryByText('transaction')
- ).not.toBeInTheDocument();
- expect(
- within(screen.getByTestId('sort-by-step')).getByText('count()')
- ).toBeInTheDocument();
- });
- });
- });
- });
|