organizationMembersList.spec.tsx 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641
  1. import {browserHistory} from 'react-router';
  2. import selectEvent from 'react-select-event';
  3. import {AuthProvider} from 'sentry-fixture/authProvider';
  4. import {
  5. render,
  6. renderGlobalModal,
  7. screen,
  8. userEvent,
  9. waitFor,
  10. within,
  11. } from 'sentry-test/reactTestingLibrary';
  12. import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicator';
  13. import ConfigStore from 'sentry/stores/configStore';
  14. import OrganizationsStore from 'sentry/stores/organizationsStore';
  15. import {trackAnalytics} from 'sentry/utils/analytics';
  16. import OrganizationMembersList from 'sentry/views/settings/organizationMembers/organizationMembersList';
  17. jest.mock('sentry/utils/analytics');
  18. jest.mock('sentry/api');
  19. jest.mock('sentry/actionCreators/indicator');
  20. const roles = [
  21. {
  22. id: 'admin',
  23. name: 'Admin',
  24. desc: 'This is the admin role',
  25. allowed: true,
  26. },
  27. {
  28. id: 'member',
  29. name: 'Member',
  30. desc: 'This is the member role',
  31. allowed: true,
  32. },
  33. {
  34. id: 'owner',
  35. name: 'Owner',
  36. desc: 'This is the owner role',
  37. allowed: true,
  38. },
  39. ];
  40. // const missingMembers = [
  41. // {
  42. // integration: 'github',
  43. // users: TestStubs.MissingMembers(),
  44. // },
  45. // ];
  46. describe('OrganizationMembersList', function () {
  47. const members = TestStubs.Members();
  48. const ownerTeam = TestStubs.Team({slug: 'owner-team', orgRole: 'owner'});
  49. const member = TestStubs.Member({
  50. id: '5',
  51. email: 'member@sentry.io',
  52. teams: [ownerTeam.slug],
  53. teamRoles: [
  54. {
  55. teamSlug: ownerTeam.slug,
  56. role: null,
  57. },
  58. ],
  59. flags: {
  60. 'sso:linked': true,
  61. },
  62. groupOrgRoles: [
  63. {
  64. teamSlug: ownerTeam.slug,
  65. role: {id: 'owner'},
  66. },
  67. ],
  68. });
  69. const currentUser = members[1];
  70. const organization = TestStubs.Organization({
  71. access: ['member:admin', 'org:admin', 'member:write'],
  72. status: {
  73. id: 'active',
  74. },
  75. });
  76. const router = TestStubs.router();
  77. const defaultProps = {
  78. organization,
  79. router,
  80. location: router.location,
  81. routes: router.routes,
  82. route: router.routes[0],
  83. params: router.params,
  84. routeParams: router.params,
  85. };
  86. jest.spyOn(ConfigStore, 'get').mockImplementation(() => currentUser);
  87. afterAll(function () {
  88. (ConfigStore.get as jest.Mock).mockRestore();
  89. });
  90. beforeEach(function () {
  91. MockApiClient.clearMockResponses();
  92. MockApiClient.addMockResponse({
  93. url: '/organizations/org-slug/members/me/',
  94. method: 'GET',
  95. body: {roles},
  96. });
  97. MockApiClient.addMockResponse({
  98. url: '/organizations/org-slug/members/',
  99. method: 'GET',
  100. body: [...TestStubs.Members(), member],
  101. });
  102. MockApiClient.addMockResponse({
  103. url: `/organizations/org-slug/members/${member.id}/`,
  104. body: member,
  105. });
  106. MockApiClient.addMockResponse({
  107. url: '/organizations/org-slug/access-requests/',
  108. method: 'GET',
  109. body: [
  110. {
  111. id: 'pending-id',
  112. member: {
  113. id: 'pending-member-id',
  114. email: '',
  115. name: '',
  116. role: '',
  117. roleName: '',
  118. user: {
  119. id: '',
  120. name: 'sentry@test.com',
  121. },
  122. },
  123. team: TestStubs.Team(),
  124. },
  125. ],
  126. });
  127. MockApiClient.addMockResponse({
  128. url: '/organizations/org-slug/auth-provider/',
  129. method: 'GET',
  130. body: {
  131. ...AuthProvider(),
  132. require_link: true,
  133. },
  134. });
  135. MockApiClient.addMockResponse({
  136. url: '/organizations/org-slug/teams/',
  137. method: 'GET',
  138. body: [TestStubs.Team(), ownerTeam],
  139. });
  140. MockApiClient.addMockResponse({
  141. url: '/organizations/org-slug/invite-requests/',
  142. method: 'GET',
  143. body: [],
  144. });
  145. MockApiClient.addMockResponse({
  146. url: '/organizations/org-slug/missing-members/',
  147. method: 'GET',
  148. body: [],
  149. });
  150. MockApiClient.addMockResponse({
  151. url: '/prompts-activity/',
  152. method: 'GET',
  153. body: {
  154. dismissed_ts: undefined,
  155. snoozed_ts: undefined,
  156. },
  157. });
  158. (browserHistory.push as jest.Mock).mockReset();
  159. OrganizationsStore.load([organization]);
  160. });
  161. it('can remove a member', async function () {
  162. const deleteMock = MockApiClient.addMockResponse({
  163. url: `/organizations/org-slug/members/${members[0].id}/`,
  164. method: 'DELETE',
  165. });
  166. render(<OrganizationMembersList {...defaultProps} />, {
  167. context: TestStubs.routerContext([{organization}]),
  168. });
  169. await userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  170. renderGlobalModal();
  171. await userEvent.click(screen.getByTestId('confirm-button'));
  172. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  173. expect(deleteMock).toHaveBeenCalled();
  174. expect(browserHistory.push).not.toHaveBeenCalled();
  175. expect(OrganizationsStore.getAll()).toEqual([organization]);
  176. });
  177. it('displays error message when failing to remove member', async function () {
  178. const deleteMock = MockApiClient.addMockResponse({
  179. url: `/organizations/org-slug/members/${members[0].id}/`,
  180. method: 'DELETE',
  181. statusCode: 500,
  182. });
  183. render(<OrganizationMembersList {...defaultProps} />, {
  184. context: TestStubs.routerContext([{organization}]),
  185. });
  186. await userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  187. renderGlobalModal();
  188. await userEvent.click(screen.getByTestId('confirm-button'));
  189. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  190. expect(deleteMock).toHaveBeenCalled();
  191. expect(browserHistory.push).not.toHaveBeenCalled();
  192. expect(OrganizationsStore.getAll()).toEqual([organization]);
  193. });
  194. it('can leave org', async function () {
  195. const deleteMock = MockApiClient.addMockResponse({
  196. url: `/organizations/org-slug/members/${members[1].id}/`,
  197. method: 'DELETE',
  198. });
  199. render(<OrganizationMembersList {...defaultProps} />, {
  200. context: TestStubs.routerContext([{organization}]),
  201. });
  202. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  203. renderGlobalModal();
  204. await userEvent.click(screen.getByTestId('confirm-button'));
  205. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  206. expect(deleteMock).toHaveBeenCalled();
  207. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  208. expect(browserHistory.push).toHaveBeenCalledWith('/organizations/new/');
  209. });
  210. it('can redirect to remaining org after leaving', async function () {
  211. const deleteMock = MockApiClient.addMockResponse({
  212. url: `/organizations/org-slug/members/${members[1].id}/`,
  213. method: 'DELETE',
  214. });
  215. const secondOrg = TestStubs.Organization({
  216. slug: 'org-two',
  217. status: {
  218. id: 'active',
  219. },
  220. });
  221. OrganizationsStore.addOrReplace(secondOrg);
  222. render(<OrganizationMembersList {...defaultProps} />, {
  223. context: TestStubs.routerContext([{organization}]),
  224. });
  225. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  226. renderGlobalModal();
  227. await userEvent.click(screen.getByTestId('confirm-button'));
  228. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  229. expect(deleteMock).toHaveBeenCalled();
  230. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  231. expect(browserHistory.push).toHaveBeenCalledWith(
  232. `/organizations/${secondOrg.slug}/issues/`
  233. );
  234. expect(OrganizationsStore.getAll()).toEqual([secondOrg]);
  235. });
  236. it('displays error message when failing to leave org', async function () {
  237. const deleteMock = MockApiClient.addMockResponse({
  238. url: `/organizations/org-slug/members/${members[1].id}/`,
  239. method: 'DELETE',
  240. statusCode: 500,
  241. });
  242. render(<OrganizationMembersList {...defaultProps} />, {
  243. context: TestStubs.routerContext([{organization}]),
  244. });
  245. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  246. renderGlobalModal();
  247. await userEvent.click(screen.getByTestId('confirm-button'));
  248. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  249. expect(deleteMock).toHaveBeenCalled();
  250. expect(browserHistory.push).not.toHaveBeenCalled();
  251. expect(OrganizationsStore.getAll()).toEqual([organization]);
  252. });
  253. it('can re-send SSO link to member', async function () {
  254. const inviteMock = MockApiClient.addMockResponse({
  255. url: `/organizations/org-slug/members/${members[0].id}/`,
  256. method: 'PUT',
  257. body: {
  258. id: '1234',
  259. },
  260. });
  261. render(<OrganizationMembersList {...defaultProps} />, {
  262. context: TestStubs.routerContext([{organization}]),
  263. });
  264. expect(inviteMock).not.toHaveBeenCalled();
  265. await userEvent.click(screen.getByRole('button', {name: 'Resend SSO link'}));
  266. expect(inviteMock).toHaveBeenCalled();
  267. });
  268. it('can re-send invite to member', async function () {
  269. const inviteMock = MockApiClient.addMockResponse({
  270. url: `/organizations/org-slug/members/${members[1].id}/`,
  271. method: 'PUT',
  272. body: {
  273. id: '1234',
  274. },
  275. });
  276. render(<OrganizationMembersList {...defaultProps} />, {
  277. context: TestStubs.routerContext([{organization}]),
  278. });
  279. expect(inviteMock).not.toHaveBeenCalled();
  280. await userEvent.click(screen.getByRole('button', {name: 'Resend invite'}));
  281. expect(inviteMock).toHaveBeenCalled();
  282. });
  283. it('can search organization members', async function () {
  284. const searchMock = MockApiClient.addMockResponse({
  285. url: '/organizations/org-slug/members/',
  286. body: [],
  287. });
  288. const routerContext = TestStubs.routerContext();
  289. render(<OrganizationMembersList {...defaultProps} />, {
  290. context: routerContext,
  291. });
  292. await userEvent.type(screen.getByPlaceholderText('Search Members'), 'member');
  293. expect(searchMock).toHaveBeenLastCalledWith(
  294. '/organizations/org-slug/members/',
  295. expect.objectContaining({
  296. method: 'GET',
  297. query: {
  298. query: 'member',
  299. },
  300. })
  301. );
  302. await userEvent.keyboard('{enter}');
  303. expect(routerContext.context.router.push).toHaveBeenCalledTimes(1);
  304. });
  305. it('can filter members', async function () {
  306. const searchMock = MockApiClient.addMockResponse({
  307. url: '/organizations/org-slug/members/',
  308. body: [],
  309. });
  310. const routerContext = TestStubs.routerContext();
  311. render(<OrganizationMembersList {...defaultProps} />, {
  312. context: routerContext,
  313. });
  314. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  315. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  316. expect(searchMock).toHaveBeenLastCalledWith(
  317. '/organizations/org-slug/members/',
  318. expect.objectContaining({
  319. method: 'GET',
  320. query: {query: 'role:member'},
  321. })
  322. );
  323. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  324. for (const [filter, label] of [
  325. ['isInvited', 'Invited'],
  326. ['has2fa', '2FA'],
  327. ['ssoLinked', 'SSO Linked'],
  328. ]) {
  329. const filterSection = screen.getByRole('listbox', {name: label});
  330. await userEvent.click(
  331. within(filterSection).getByRole('option', {
  332. name: 'True',
  333. })
  334. );
  335. expect(searchMock).toHaveBeenLastCalledWith(
  336. '/organizations/org-slug/members/',
  337. expect.objectContaining({
  338. method: 'GET',
  339. query: {query: `${filter}:true`},
  340. })
  341. );
  342. await userEvent.click(
  343. within(filterSection).getByRole('option', {
  344. name: 'False',
  345. })
  346. );
  347. expect(searchMock).toHaveBeenLastCalledWith(
  348. '/organizations/org-slug/members/',
  349. expect.objectContaining({
  350. method: 'GET',
  351. query: {query: `${filter}:false`},
  352. })
  353. );
  354. await userEvent.click(
  355. within(filterSection).getByRole('option', {
  356. name: 'All',
  357. })
  358. );
  359. }
  360. });
  361. it('can filter members with org roles from team membership', async function () {
  362. const routerContext = TestStubs.routerContext();
  363. render(<OrganizationMembersList {...defaultProps} />, {
  364. context: routerContext,
  365. });
  366. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  367. await userEvent.click(screen.getByRole('option', {name: 'Owner'}));
  368. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  369. const owners = screen.queryAllByText('Owner');
  370. expect(owners).toHaveLength(3);
  371. });
  372. describe('OrganizationInviteRequests', function () {
  373. const inviteRequest = TestStubs.Member({
  374. id: '123',
  375. user: null,
  376. inviteStatus: 'requested_to_be_invited',
  377. inviter: TestStubs.User(),
  378. role: 'member',
  379. teams: [],
  380. });
  381. const joinRequest = TestStubs.Member({
  382. id: '456',
  383. user: null,
  384. email: 'test@gmail.com',
  385. inviteStatus: 'requested_to_join',
  386. role: 'member',
  387. teams: [],
  388. });
  389. it('disable buttons for no access', function () {
  390. const org = TestStubs.Organization({
  391. status: {
  392. id: 'active',
  393. },
  394. });
  395. MockApiClient.addMockResponse({
  396. url: '/organizations/org-slug/invite-requests/',
  397. method: 'GET',
  398. body: [inviteRequest],
  399. });
  400. MockApiClient.addMockResponse({
  401. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  402. method: 'PUT',
  403. });
  404. render(<OrganizationMembersList {...defaultProps} organization={org} />, {
  405. context: TestStubs.routerContext([{organization: org}]),
  406. });
  407. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  408. expect(screen.getByRole('button', {name: 'Approve'})).toBeDisabled();
  409. });
  410. it('can approve invite request and update', async function () {
  411. const org = TestStubs.Organization({
  412. access: ['member:admin', 'org:admin', 'member:write'],
  413. status: {
  414. id: 'active',
  415. },
  416. });
  417. MockApiClient.addMockResponse({
  418. url: '/organizations/org-slug/invite-requests/',
  419. method: 'GET',
  420. body: [inviteRequest],
  421. });
  422. MockApiClient.addMockResponse({
  423. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  424. method: 'PUT',
  425. });
  426. render(<OrganizationMembersList {...defaultProps} />, {
  427. context: TestStubs.routerContext([{organization: org}]),
  428. });
  429. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  430. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  431. renderGlobalModal();
  432. await userEvent.click(screen.getByTestId('confirm-button'));
  433. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  434. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.approved', {
  435. invite_status: inviteRequest.inviteStatus,
  436. member_id: parseInt(inviteRequest.id, 10),
  437. organization: org,
  438. });
  439. });
  440. it('can deny invite request and remove', async function () {
  441. const org = TestStubs.Organization({
  442. access: ['member:admin', 'org:admin', 'member:write'],
  443. status: {
  444. id: 'active',
  445. },
  446. });
  447. MockApiClient.addMockResponse({
  448. url: '/organizations/org-slug/invite-requests/',
  449. method: 'GET',
  450. body: [joinRequest],
  451. });
  452. MockApiClient.addMockResponse({
  453. url: `/organizations/org-slug/invite-requests/${joinRequest.id}/`,
  454. method: 'DELETE',
  455. });
  456. render(<OrganizationMembersList {...defaultProps} />, {
  457. context: TestStubs.routerContext([{organization: org}]),
  458. });
  459. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  460. await userEvent.click(screen.getByRole('button', {name: 'Deny'}));
  461. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  462. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.denied', {
  463. invite_status: joinRequest.inviteStatus,
  464. member_id: parseInt(joinRequest.id, 10),
  465. organization: org,
  466. });
  467. });
  468. it('can update invite requests', async function () {
  469. const org = TestStubs.Organization({
  470. access: ['member:admin', 'org:admin', 'member:write'],
  471. status: {
  472. id: 'active',
  473. },
  474. });
  475. MockApiClient.addMockResponse({
  476. url: '/organizations/org-slug/invite-requests/',
  477. method: 'GET',
  478. body: [inviteRequest],
  479. });
  480. const updateWithApprove = MockApiClient.addMockResponse({
  481. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  482. method: 'PUT',
  483. });
  484. render(<OrganizationMembersList {...defaultProps} />, {
  485. context: TestStubs.routerContext([{organization: org}]),
  486. });
  487. await selectEvent.select(screen.getAllByRole('textbox')[1], ['Admin']);
  488. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  489. renderGlobalModal();
  490. await userEvent.click(screen.getByTestId('confirm-button'));
  491. expect(updateWithApprove).toHaveBeenCalledWith(
  492. `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  493. expect.objectContaining({data: expect.objectContaining({role: 'admin'})})
  494. );
  495. });
  496. });
  497. // TODO(cathy): uncomment
  498. // describe('inviteBanner', function () {
  499. // it('invites member from banner', async function () {
  500. // MockApiClient.addMockResponse({
  501. // url: '/organizations/org-slug/missing-members/',
  502. // method: 'GET',
  503. // body: missingMembers,
  504. // });
  505. // const newMember = TestStubs.Member({
  506. // id: '6',
  507. // email: 'hello@sentry.io',
  508. // teams: [],
  509. // teamRoles: [],
  510. // flags: {
  511. // 'sso:linked': true,
  512. // 'idp:provisioned': false,
  513. // },
  514. // });
  515. // MockApiClient.addMockResponse({
  516. // url: '/organizations/org-slug/members/?referrer=github_nudge_invite',
  517. // method: 'POST',
  518. // body: newMember,
  519. // });
  520. // const org = TestStubs.Organization({
  521. // features: ['integrations-gh-invite'],
  522. // githubNudgeInvite: true,
  523. // });
  524. // render(<OrganizationMembersList {...defaultProps} organization={org} />, {
  525. // context: TestStubs.routerContext([{organization: org}]),
  526. // });
  527. // expect(
  528. // await screen.findByRole('heading', {
  529. // name: 'Bring your full GitHub team on board in Sentry',
  530. // })
  531. // ).toBeInTheDocument();
  532. // expect(screen.queryAllByTestId('invite-missing-member')).toHaveLength(5);
  533. // expect(screen.getByText('See all 5 missing members')).toBeInTheDocument();
  534. // const inviteButton = screen.queryAllByTestId('invite-missing-member')[0];
  535. // await userEvent.click(inviteButton);
  536. // expect(screen.queryAllByTestId('invite-missing-member')).toHaveLength(4);
  537. // expect(screen.getByText('See all 4 missing members')).toBeInTheDocument();
  538. // });
  539. // });
  540. });