organizationMembersList.spec.jsx 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508
  1. import {browserHistory} from 'react-router';
  2. import selectEvent from 'react-select-event';
  3. import {
  4. render,
  5. renderGlobalModal,
  6. screen,
  7. userEvent,
  8. waitFor,
  9. waitForElementToBeRemoved,
  10. } from 'sentry-test/reactTestingLibrary';
  11. import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicator';
  12. import {Client} from 'sentry/api';
  13. import ConfigStore from 'sentry/stores/configStore';
  14. import OrganizationsStore from 'sentry/stores/organizationsStore';
  15. import trackAdvancedAnalyticsEvent from 'sentry/utils/analytics/trackAdvancedAnalyticsEvent';
  16. import OrganizationMembersList from 'sentry/views/settings/organizationMembers/organizationMembersList';
  17. jest.mock('sentry/utils/analytics/trackAdvancedAnalyticsEvent', () => jest.fn());
  18. jest.mock('sentry/api');
  19. jest.mock('sentry/actionCreators/indicator');
  20. const roles = [
  21. {
  22. id: 'admin',
  23. name: 'Admin',
  24. desc: 'This is the admin role',
  25. allowed: true,
  26. },
  27. {
  28. id: 'member',
  29. name: 'Member',
  30. desc: 'This is the member role',
  31. allowed: true,
  32. },
  33. ];
  34. describe('OrganizationMembersList', function () {
  35. const members = TestStubs.Members();
  36. const currentUser = members[1];
  37. const organization = TestStubs.Organization({
  38. access: ['member:admin', 'org:admin', 'member:write'],
  39. status: {
  40. id: 'active',
  41. },
  42. });
  43. const defaultProps = {
  44. organization,
  45. router: {routes: []},
  46. location: {query: {}},
  47. };
  48. jest.spyOn(ConfigStore, 'get').mockImplementation(() => currentUser);
  49. afterAll(function () {
  50. ConfigStore.get.mockRestore();
  51. });
  52. beforeEach(function () {
  53. Client.clearMockResponses();
  54. Client.addMockResponse({
  55. url: '/organizations/org-slug/members/me/',
  56. method: 'GET',
  57. body: {roles},
  58. });
  59. Client.addMockResponse({
  60. url: '/organizations/org-slug/members/',
  61. method: 'GET',
  62. body: TestStubs.Members(),
  63. });
  64. Client.addMockResponse({
  65. url: '/organizations/org-slug/access-requests/',
  66. method: 'GET',
  67. body: [
  68. {
  69. id: 'pending-id',
  70. member: {
  71. id: 'pending-member-id',
  72. email: '',
  73. name: '',
  74. role: '',
  75. roleName: '',
  76. user: {
  77. id: '',
  78. name: 'sentry@test.com',
  79. },
  80. },
  81. team: TestStubs.Team(),
  82. },
  83. ],
  84. });
  85. Client.addMockResponse({
  86. url: '/organizations/org-slug/auth-provider/',
  87. method: 'GET',
  88. body: {
  89. ...TestStubs.AuthProvider(),
  90. require_link: true,
  91. },
  92. });
  93. Client.addMockResponse({
  94. url: '/organizations/org-slug/teams/',
  95. method: 'GET',
  96. body: TestStubs.Team(),
  97. });
  98. Client.addMockResponse({
  99. url: '/organizations/org-slug/invite-requests/',
  100. method: 'GET',
  101. body: [],
  102. });
  103. browserHistory.push.mockReset();
  104. OrganizationsStore.load([organization]);
  105. });
  106. it('can remove a member', async function () {
  107. const deleteMock = MockApiClient.addMockResponse({
  108. url: `/organizations/org-slug/members/${members[0].id}/`,
  109. method: 'DELETE',
  110. });
  111. render(<OrganizationMembersList {...defaultProps} />, {
  112. context: TestStubs.routerContext([{organization}]),
  113. });
  114. userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  115. renderGlobalModal();
  116. userEvent.click(screen.getByTestId('confirm-button'));
  117. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  118. expect(deleteMock).toHaveBeenCalled();
  119. expect(browserHistory.push).not.toHaveBeenCalled();
  120. expect(OrganizationsStore.getAll()).toEqual([organization]);
  121. });
  122. it('displays error message when failing to remove member', async function () {
  123. const deleteMock = MockApiClient.addMockResponse({
  124. url: `/organizations/org-slug/members/${members[0].id}/`,
  125. method: 'DELETE',
  126. statusCode: 500,
  127. });
  128. render(<OrganizationMembersList {...defaultProps} />, {
  129. context: TestStubs.routerContext([{organization}]),
  130. });
  131. userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  132. renderGlobalModal();
  133. userEvent.click(screen.getByTestId('confirm-button'));
  134. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  135. expect(deleteMock).toHaveBeenCalled();
  136. expect(browserHistory.push).not.toHaveBeenCalled();
  137. expect(OrganizationsStore.getAll()).toEqual([organization]);
  138. });
  139. it('can leave org', async function () {
  140. const deleteMock = Client.addMockResponse({
  141. url: `/organizations/org-slug/members/${members[1].id}/`,
  142. method: 'DELETE',
  143. });
  144. render(<OrganizationMembersList {...defaultProps} />, {
  145. context: TestStubs.routerContext([{organization}]),
  146. });
  147. userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  148. renderGlobalModal();
  149. userEvent.click(screen.getByTestId('confirm-button'));
  150. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  151. expect(deleteMock).toHaveBeenCalled();
  152. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  153. expect(browserHistory.push).toHaveBeenCalledWith('/organizations/new/');
  154. });
  155. it('can redirect to remaining org after leaving', async function () {
  156. const deleteMock = Client.addMockResponse({
  157. url: `/organizations/org-slug/members/${members[1].id}/`,
  158. method: 'DELETE',
  159. });
  160. const secondOrg = TestStubs.Organization({
  161. slug: 'org-two',
  162. status: {
  163. id: 'active',
  164. },
  165. });
  166. OrganizationsStore.addOrReplace(secondOrg);
  167. render(<OrganizationMembersList {...defaultProps} />, {
  168. context: TestStubs.routerContext([{organization}]),
  169. });
  170. userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  171. renderGlobalModal();
  172. userEvent.click(screen.getByTestId('confirm-button'));
  173. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  174. expect(deleteMock).toHaveBeenCalled();
  175. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  176. expect(browserHistory.push).toHaveBeenCalledWith(
  177. `/organizations/${secondOrg.slug}/issues/`
  178. );
  179. expect(OrganizationsStore.getAll()).toEqual([secondOrg]);
  180. });
  181. it('displays error message when failing to leave org', async function () {
  182. const deleteMock = Client.addMockResponse({
  183. url: `/organizations/org-slug/members/${members[1].id}/`,
  184. method: 'DELETE',
  185. statusCode: 500,
  186. });
  187. render(<OrganizationMembersList {...defaultProps} />, {
  188. context: TestStubs.routerContext([{organization}]),
  189. });
  190. userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  191. renderGlobalModal();
  192. userEvent.click(screen.getByTestId('confirm-button'));
  193. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  194. expect(deleteMock).toHaveBeenCalled();
  195. expect(browserHistory.push).not.toHaveBeenCalled();
  196. expect(OrganizationsStore.getAll()).toEqual([organization]);
  197. });
  198. it('can re-send SSO link to member', function () {
  199. const inviteMock = MockApiClient.addMockResponse({
  200. url: `/organizations/org-slug/members/${members[0].id}/`,
  201. method: 'PUT',
  202. body: {
  203. id: '1234',
  204. },
  205. });
  206. render(<OrganizationMembersList {...defaultProps} />, {
  207. context: TestStubs.routerContext([{organization}]),
  208. });
  209. expect(inviteMock).not.toHaveBeenCalled();
  210. userEvent.click(screen.getByRole('button', {name: 'Resend SSO link'}));
  211. expect(inviteMock).toHaveBeenCalled();
  212. });
  213. it('can re-send invite to member', function () {
  214. const inviteMock = MockApiClient.addMockResponse({
  215. url: `/organizations/org-slug/members/${members[1].id}/`,
  216. method: 'PUT',
  217. body: {
  218. id: '1234',
  219. },
  220. });
  221. render(<OrganizationMembersList {...defaultProps} />, {
  222. context: TestStubs.routerContext([{organization}]),
  223. });
  224. expect(inviteMock).not.toHaveBeenCalled();
  225. userEvent.click(screen.getByRole('button', {name: 'Resend invite'}));
  226. expect(inviteMock).toHaveBeenCalled();
  227. });
  228. it('can search organization members', function () {
  229. const searchMock = MockApiClient.addMockResponse({
  230. url: '/organizations/org-slug/members/',
  231. body: [],
  232. });
  233. const routerContext = TestStubs.routerContext();
  234. render(<OrganizationMembersList {...defaultProps} />, {
  235. context: routerContext,
  236. });
  237. userEvent.type(screen.getByPlaceholderText('Search Members'), 'member');
  238. expect(searchMock).toHaveBeenLastCalledWith(
  239. '/organizations/org-slug/members/',
  240. expect.objectContaining({
  241. method: 'GET',
  242. query: {
  243. query: 'member',
  244. },
  245. })
  246. );
  247. userEvent.keyboard('{enter}');
  248. expect(routerContext.context.router.push).toHaveBeenCalledTimes(1);
  249. });
  250. it('can filter members', function () {
  251. const searchMock = MockApiClient.addMockResponse({
  252. url: '/organizations/org-slug/members/',
  253. body: [],
  254. });
  255. const routerContext = TestStubs.routerContext();
  256. render(<OrganizationMembersList {...defaultProps} />, {
  257. context: routerContext,
  258. });
  259. userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  260. userEvent.click(screen.getByRole('checkbox', {name: 'Member'}));
  261. expect(searchMock).toHaveBeenLastCalledWith(
  262. '/organizations/org-slug/members/',
  263. expect.objectContaining({
  264. method: 'GET',
  265. query: {query: 'role:member'},
  266. })
  267. );
  268. userEvent.click(screen.getByRole('checkbox', {name: 'Member'}));
  269. for (const [filter, label] of [
  270. ['isInvited', 'Invited'],
  271. ['has2fa', '2FA'],
  272. ['ssoLinked', 'SSO Linked'],
  273. ]) {
  274. userEvent.click(screen.getByRole('checkbox', {name: `Enable ${label} filter`}));
  275. expect(searchMock).toHaveBeenLastCalledWith(
  276. '/organizations/org-slug/members/',
  277. expect.objectContaining({
  278. method: 'GET',
  279. query: {query: `${filter}:true`},
  280. })
  281. );
  282. userEvent.click(screen.getByRole('checkbox', {name: `Toggle ${label}`}));
  283. expect(searchMock).toHaveBeenLastCalledWith(
  284. '/organizations/org-slug/members/',
  285. expect.objectContaining({
  286. method: 'GET',
  287. query: {query: `${filter}:false`},
  288. })
  289. );
  290. userEvent.click(screen.getByRole('checkbox', {name: `Enable ${label} filter`}));
  291. }
  292. });
  293. describe('OrganizationInviteRequests', function () {
  294. const inviteRequest = TestStubs.Member({
  295. id: '123',
  296. user: null,
  297. inviteStatus: 'requested_to_be_invited',
  298. inviter: TestStubs.User(),
  299. role: 'member',
  300. teams: [],
  301. });
  302. const joinRequest = TestStubs.Member({
  303. id: '456',
  304. user: null,
  305. email: 'test@gmail.com',
  306. inviteStatus: 'requested_to_join',
  307. role: 'member',
  308. teams: [],
  309. });
  310. it('disable buttons for no access', function () {
  311. const org = TestStubs.Organization({
  312. status: {
  313. id: 'active',
  314. },
  315. });
  316. MockApiClient.addMockResponse({
  317. url: '/organizations/org-slug/invite-requests/',
  318. method: 'GET',
  319. body: [inviteRequest],
  320. });
  321. MockApiClient.addMockResponse({
  322. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  323. method: 'PUT',
  324. });
  325. render(<OrganizationMembersList {...defaultProps} organization={org} />, {
  326. context: TestStubs.routerContext([{organization: org}]),
  327. });
  328. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  329. expect(screen.getByRole('button', {name: 'Approve'})).toBeDisabled();
  330. });
  331. it('can approve invite request and update', async function () {
  332. const org = TestStubs.Organization({
  333. access: ['member:admin', 'org:admin', 'member:write'],
  334. status: {
  335. id: 'active',
  336. },
  337. });
  338. MockApiClient.addMockResponse({
  339. url: '/organizations/org-slug/invite-requests/',
  340. method: 'GET',
  341. body: [inviteRequest],
  342. });
  343. MockApiClient.addMockResponse({
  344. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  345. method: 'PUT',
  346. });
  347. render(<OrganizationMembersList {...defaultProps} />, {
  348. context: TestStubs.routerContext([{organization: org}]),
  349. });
  350. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  351. userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  352. renderGlobalModal();
  353. userEvent.click(screen.getByTestId('confirm-button'));
  354. await waitForElementToBeRemoved(() => screen.queryByText('Pending Members'));
  355. expect(trackAdvancedAnalyticsEvent).toHaveBeenCalledWith(
  356. 'invite_request.approved',
  357. {
  358. invite_status: inviteRequest.inviteStatus,
  359. member_id: parseInt(inviteRequest.id, 10),
  360. organization: org,
  361. }
  362. );
  363. });
  364. it('can deny invite request and remove', async function () {
  365. const org = TestStubs.Organization({
  366. access: ['member:admin', 'org:admin', 'member:write'],
  367. status: {
  368. id: 'active',
  369. },
  370. });
  371. MockApiClient.addMockResponse({
  372. url: '/organizations/org-slug/invite-requests/',
  373. method: 'GET',
  374. body: [joinRequest],
  375. });
  376. MockApiClient.addMockResponse({
  377. url: `/organizations/org-slug/invite-requests/${joinRequest.id}/`,
  378. method: 'DELETE',
  379. });
  380. render(<OrganizationMembersList {...defaultProps} />, {
  381. context: TestStubs.routerContext([{organization: org}]),
  382. });
  383. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  384. userEvent.click(screen.getByRole('button', {name: 'Deny'}));
  385. await waitForElementToBeRemoved(() => screen.queryByText('Pending Members'));
  386. expect(trackAdvancedAnalyticsEvent).toHaveBeenCalledWith('invite_request.denied', {
  387. invite_status: joinRequest.inviteStatus,
  388. member_id: parseInt(joinRequest.id, 10),
  389. organization: org,
  390. });
  391. });
  392. it('can update invite requests', async function () {
  393. const org = TestStubs.Organization({
  394. access: ['member:admin', 'org:admin', 'member:write'],
  395. status: {
  396. id: 'active',
  397. },
  398. });
  399. MockApiClient.addMockResponse({
  400. url: '/organizations/org-slug/invite-requests/',
  401. method: 'GET',
  402. body: [inviteRequest],
  403. });
  404. const updateWithApprove = MockApiClient.addMockResponse({
  405. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  406. method: 'PUT',
  407. });
  408. render(<OrganizationMembersList {...defaultProps} />, {
  409. context: TestStubs.routerContext([{organization: org}]),
  410. });
  411. await selectEvent.select(screen.getAllByRole('textbox')[1], ['Admin']);
  412. userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  413. renderGlobalModal();
  414. userEvent.click(screen.getByTestId('confirm-button'));
  415. expect(updateWithApprove).toHaveBeenCalledWith(
  416. `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  417. expect.objectContaining({data: expect.objectContaining({role: 'admin'})})
  418. );
  419. });
  420. });
  421. });