organizationMembersList.spec.tsx 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610
  1. import {browserHistory} from 'react-router';
  2. import selectEvent from 'react-select-event';
  3. import {AuthProvider} from 'sentry-fixture/authProvider';
  4. import {Member as MemberFixture} from 'sentry-fixture/member';
  5. import {Members as MembersFixture} from 'sentry-fixture/members';
  6. import {Organization} from 'sentry-fixture/organization';
  7. import RouterContextFixture from 'sentry-fixture/routerContextFixture';
  8. import RouterFixture from 'sentry-fixture/routerFixture';
  9. import {Team} from 'sentry-fixture/team';
  10. import {User} from 'sentry-fixture/user';
  11. import {
  12. render,
  13. renderGlobalModal,
  14. screen,
  15. userEvent,
  16. waitFor,
  17. within,
  18. } from 'sentry-test/reactTestingLibrary';
  19. import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicator';
  20. import ConfigStore from 'sentry/stores/configStore';
  21. import OrganizationsStore from 'sentry/stores/organizationsStore';
  22. import {OrgRoleFixture} from 'sentry/types/role';
  23. import {trackAnalytics} from 'sentry/utils/analytics';
  24. import OrganizationMembersList from 'sentry/views/settings/organizationMembers/organizationMembersList';
  25. jest.mock('sentry/utils/analytics');
  26. jest.mock('sentry/api');
  27. jest.mock('sentry/actionCreators/indicator');
  28. const roles = [
  29. {
  30. id: 'admin',
  31. name: 'Admin',
  32. desc: 'This is the admin role',
  33. allowed: true,
  34. },
  35. {
  36. id: 'member',
  37. name: 'Member',
  38. desc: 'This is the member role',
  39. allowed: true,
  40. },
  41. {
  42. id: 'owner',
  43. name: 'Owner',
  44. desc: 'This is the owner role',
  45. allowed: true,
  46. },
  47. ];
  48. // const missingMembers = [
  49. // {
  50. // integration: 'github',
  51. // users: TestStubs.MissingMembers(),
  52. // },
  53. // ];
  54. describe('OrganizationMembersList', function () {
  55. const members = MembersFixture();
  56. const ownerTeam = Team({slug: 'owner-team', orgRole: 'owner'});
  57. const member = MemberFixture({
  58. id: '5',
  59. email: 'member@sentry.io',
  60. teams: [ownerTeam.slug],
  61. teamRoles: [
  62. {
  63. teamSlug: ownerTeam.slug,
  64. role: null,
  65. },
  66. ],
  67. flags: {
  68. 'sso:linked': true,
  69. 'idp:provisioned': false,
  70. 'idp:role-restricted': false,
  71. 'member-limit:restricted': false,
  72. 'partnership:restricted': false,
  73. 'sso:invalid': false,
  74. },
  75. groupOrgRoles: [
  76. {
  77. teamSlug: ownerTeam.slug,
  78. role: OrgRoleFixture({id: 'owner'}),
  79. },
  80. ],
  81. });
  82. const currentUser = members[1];
  83. currentUser.user = User({...currentUser, flags: {newsletter_consent_prompt: true}});
  84. const organization = Organization({
  85. access: ['member:admin', 'org:admin', 'member:write'],
  86. status: {
  87. id: 'active',
  88. name: 'active',
  89. },
  90. });
  91. const router = RouterFixture();
  92. const defaultProps = {
  93. organization,
  94. router,
  95. location: router.location,
  96. routes: router.routes,
  97. route: router.routes[0],
  98. params: router.params,
  99. routeParams: router.params,
  100. };
  101. jest.spyOn(ConfigStore, 'get').mockImplementation(() => currentUser.user);
  102. afterAll(function () {
  103. (ConfigStore.get as jest.Mock).mockRestore();
  104. });
  105. beforeEach(function () {
  106. MockApiClient.clearMockResponses();
  107. MockApiClient.addMockResponse({
  108. url: '/organizations/org-slug/members/me/',
  109. method: 'GET',
  110. body: {roles},
  111. });
  112. MockApiClient.addMockResponse({
  113. url: '/organizations/org-slug/members/',
  114. method: 'GET',
  115. body: [...MembersFixture(), member],
  116. });
  117. MockApiClient.addMockResponse({
  118. url: `/organizations/org-slug/members/${member.id}/`,
  119. body: member,
  120. });
  121. MockApiClient.addMockResponse({
  122. url: '/organizations/org-slug/access-requests/',
  123. method: 'GET',
  124. body: [
  125. {
  126. id: 'pending-id',
  127. member: {
  128. id: 'pending-member-id',
  129. email: '',
  130. name: '',
  131. role: '',
  132. roleName: '',
  133. user: {
  134. id: '',
  135. name: 'sentry@test.com',
  136. },
  137. },
  138. team: Team(),
  139. },
  140. ],
  141. });
  142. MockApiClient.addMockResponse({
  143. url: '/organizations/org-slug/auth-provider/',
  144. method: 'GET',
  145. body: {
  146. ...AuthProvider(),
  147. require_link: true,
  148. },
  149. });
  150. MockApiClient.addMockResponse({
  151. url: '/organizations/org-slug/teams/',
  152. method: 'GET',
  153. body: [Team(), ownerTeam],
  154. });
  155. MockApiClient.addMockResponse({
  156. url: '/organizations/org-slug/invite-requests/',
  157. method: 'GET',
  158. body: [],
  159. });
  160. MockApiClient.addMockResponse({
  161. url: '/organizations/org-slug/missing-members/',
  162. method: 'GET',
  163. body: [],
  164. });
  165. MockApiClient.addMockResponse({
  166. url: '/prompts-activity/',
  167. method: 'GET',
  168. body: {
  169. dismissed_ts: undefined,
  170. snoozed_ts: undefined,
  171. },
  172. });
  173. (browserHistory.push as jest.Mock).mockReset();
  174. OrganizationsStore.load([organization]);
  175. });
  176. it('can remove a member', async function () {
  177. const deleteMock = MockApiClient.addMockResponse({
  178. url: `/organizations/org-slug/members/${members[0].id}/`,
  179. method: 'DELETE',
  180. });
  181. render(<OrganizationMembersList {...defaultProps} />, {
  182. context: RouterContextFixture([{organization}]),
  183. });
  184. await userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  185. renderGlobalModal();
  186. await userEvent.click(screen.getByTestId('confirm-button'));
  187. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  188. expect(deleteMock).toHaveBeenCalled();
  189. expect(browserHistory.push).not.toHaveBeenCalled();
  190. expect(OrganizationsStore.getAll()).toEqual([organization]);
  191. });
  192. it('displays error message when failing to remove member', async function () {
  193. const deleteMock = MockApiClient.addMockResponse({
  194. url: `/organizations/org-slug/members/${members[0].id}/`,
  195. method: 'DELETE',
  196. statusCode: 500,
  197. });
  198. render(<OrganizationMembersList {...defaultProps} />, {
  199. context: RouterContextFixture([{organization}]),
  200. });
  201. await userEvent.click(screen.getAllByRole('button', {name: 'Remove'})[0]);
  202. renderGlobalModal();
  203. await userEvent.click(screen.getByTestId('confirm-button'));
  204. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  205. expect(deleteMock).toHaveBeenCalled();
  206. expect(browserHistory.push).not.toHaveBeenCalled();
  207. expect(OrganizationsStore.getAll()).toEqual([organization]);
  208. });
  209. it('can leave org', async function () {
  210. const deleteMock = MockApiClient.addMockResponse({
  211. url: `/organizations/org-slug/members/${members[1].id}/`,
  212. method: 'DELETE',
  213. });
  214. render(<OrganizationMembersList {...defaultProps} />, {
  215. context: RouterContextFixture([{organization}]),
  216. });
  217. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  218. renderGlobalModal();
  219. await userEvent.click(screen.getByTestId('confirm-button'));
  220. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  221. expect(deleteMock).toHaveBeenCalled();
  222. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  223. expect(browserHistory.push).toHaveBeenCalledWith('/organizations/new/');
  224. });
  225. it('can redirect to remaining org after leaving', async function () {
  226. const deleteMock = MockApiClient.addMockResponse({
  227. url: `/organizations/org-slug/members/${members[1].id}/`,
  228. method: 'DELETE',
  229. });
  230. const secondOrg = Organization({
  231. slug: 'org-two',
  232. status: {
  233. id: 'active',
  234. name: 'active',
  235. },
  236. });
  237. OrganizationsStore.addOrReplace(secondOrg);
  238. render(<OrganizationMembersList {...defaultProps} />, {
  239. context: RouterContextFixture([{organization}]),
  240. });
  241. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  242. renderGlobalModal();
  243. await userEvent.click(screen.getByTestId('confirm-button'));
  244. await waitFor(() => expect(addSuccessMessage).toHaveBeenCalled());
  245. expect(deleteMock).toHaveBeenCalled();
  246. expect(browserHistory.push).toHaveBeenCalledTimes(1);
  247. expect(browserHistory.push).toHaveBeenCalledWith(
  248. `/organizations/${secondOrg.slug}/issues/`
  249. );
  250. expect(OrganizationsStore.getAll()).toEqual([secondOrg]);
  251. });
  252. it('displays error message when failing to leave org', async function () {
  253. const deleteMock = MockApiClient.addMockResponse({
  254. url: `/organizations/org-slug/members/${members[1].id}/`,
  255. method: 'DELETE',
  256. statusCode: 500,
  257. });
  258. render(<OrganizationMembersList {...defaultProps} />, {
  259. context: RouterContextFixture([{organization}]),
  260. });
  261. await userEvent.click(screen.getAllByRole('button', {name: 'Leave'})[0]);
  262. renderGlobalModal();
  263. await userEvent.click(screen.getByTestId('confirm-button'));
  264. await waitFor(() => expect(addErrorMessage).toHaveBeenCalled());
  265. expect(deleteMock).toHaveBeenCalled();
  266. expect(browserHistory.push).not.toHaveBeenCalled();
  267. expect(OrganizationsStore.getAll()).toEqual([organization]);
  268. });
  269. it('can re-send SSO link to member', async function () {
  270. const inviteMock = MockApiClient.addMockResponse({
  271. url: `/organizations/org-slug/members/${members[0].id}/`,
  272. method: 'PUT',
  273. body: {
  274. id: '1234',
  275. },
  276. });
  277. render(<OrganizationMembersList {...defaultProps} />, {
  278. context: RouterContextFixture([{organization}]),
  279. });
  280. expect(inviteMock).not.toHaveBeenCalled();
  281. await userEvent.click(screen.getByRole('button', {name: 'Resend SSO link'}));
  282. expect(inviteMock).toHaveBeenCalled();
  283. });
  284. it('can re-send invite to member', async function () {
  285. const inviteMock = MockApiClient.addMockResponse({
  286. url: `/organizations/org-slug/members/${members[1].id}/`,
  287. method: 'PUT',
  288. body: {
  289. id: '1234',
  290. },
  291. });
  292. render(<OrganizationMembersList {...defaultProps} />, {
  293. context: RouterContextFixture([{organization}]),
  294. });
  295. expect(inviteMock).not.toHaveBeenCalled();
  296. await userEvent.click(screen.getByRole('button', {name: 'Resend invite'}));
  297. expect(inviteMock).toHaveBeenCalled();
  298. });
  299. it('can search organization members', async function () {
  300. const searchMock = MockApiClient.addMockResponse({
  301. url: '/organizations/org-slug/members/',
  302. body: [],
  303. });
  304. const routerContext = RouterContextFixture();
  305. render(<OrganizationMembersList {...defaultProps} />, {
  306. context: routerContext,
  307. });
  308. await userEvent.type(screen.getByPlaceholderText('Search Members'), 'member');
  309. expect(searchMock).toHaveBeenLastCalledWith(
  310. '/organizations/org-slug/members/',
  311. expect.objectContaining({
  312. method: 'GET',
  313. query: {
  314. query: 'member',
  315. },
  316. })
  317. );
  318. await userEvent.keyboard('{enter}');
  319. expect(routerContext.context.router.push).toHaveBeenCalledTimes(1);
  320. });
  321. it('can filter members', async function () {
  322. const searchMock = MockApiClient.addMockResponse({
  323. url: '/organizations/org-slug/members/',
  324. body: [],
  325. });
  326. const routerContext = RouterContextFixture();
  327. render(<OrganizationMembersList {...defaultProps} />, {
  328. context: routerContext,
  329. });
  330. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  331. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  332. expect(searchMock).toHaveBeenLastCalledWith(
  333. '/organizations/org-slug/members/',
  334. expect.objectContaining({
  335. method: 'GET',
  336. query: {query: 'role:member'},
  337. })
  338. );
  339. await userEvent.click(screen.getByRole('option', {name: 'Member'}));
  340. for (const [filter, label] of [
  341. ['isInvited', 'Invited'],
  342. ['has2fa', '2FA'],
  343. ['ssoLinked', 'SSO Linked'],
  344. ]) {
  345. const filterSection = screen.getByRole('listbox', {name: label});
  346. await userEvent.click(
  347. within(filterSection).getByRole('option', {
  348. name: 'True',
  349. })
  350. );
  351. expect(searchMock).toHaveBeenLastCalledWith(
  352. '/organizations/org-slug/members/',
  353. expect.objectContaining({
  354. method: 'GET',
  355. query: {query: `${filter}:true`},
  356. })
  357. );
  358. await userEvent.click(
  359. within(filterSection).getByRole('option', {
  360. name: 'False',
  361. })
  362. );
  363. expect(searchMock).toHaveBeenLastCalledWith(
  364. '/organizations/org-slug/members/',
  365. expect.objectContaining({
  366. method: 'GET',
  367. query: {query: `${filter}:false`},
  368. })
  369. );
  370. await userEvent.click(
  371. within(filterSection).getByRole('option', {
  372. name: 'All',
  373. })
  374. );
  375. }
  376. });
  377. it('can filter members with org roles from team membership', async function () {
  378. const routerContext = RouterContextFixture();
  379. render(<OrganizationMembersList {...defaultProps} />, {
  380. context: routerContext,
  381. });
  382. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  383. await userEvent.click(screen.getByRole('option', {name: 'Owner'}));
  384. await userEvent.click(screen.getByRole('button', {name: 'Filter'}));
  385. const owners = screen.queryAllByText('Owner');
  386. expect(owners).toHaveLength(3);
  387. });
  388. describe('OrganizationInviteRequests', function () {
  389. const inviteRequest = MemberFixture({
  390. id: '123',
  391. user: null,
  392. inviteStatus: 'requested_to_be_invited',
  393. inviterName: User().name,
  394. role: 'member',
  395. teams: [],
  396. });
  397. const joinRequest = MemberFixture({
  398. id: '456',
  399. user: null,
  400. email: 'test@gmail.com',
  401. inviteStatus: 'requested_to_join',
  402. role: 'member',
  403. teams: [],
  404. });
  405. it('disable buttons for no access', function () {
  406. const org = Organization({
  407. status: {
  408. id: 'active',
  409. name: 'active',
  410. },
  411. });
  412. MockApiClient.addMockResponse({
  413. url: '/organizations/org-slug/invite-requests/',
  414. method: 'GET',
  415. body: [inviteRequest],
  416. });
  417. MockApiClient.addMockResponse({
  418. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  419. method: 'PUT',
  420. });
  421. render(<OrganizationMembersList {...defaultProps} organization={org} />, {
  422. context: RouterContextFixture([{organization: org}]),
  423. });
  424. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  425. expect(screen.getByRole('button', {name: 'Approve'})).toBeDisabled();
  426. });
  427. it('can approve invite request and update', async function () {
  428. const org = Organization({
  429. access: ['member:admin', 'org:admin', 'member:write'],
  430. status: {
  431. id: 'active',
  432. name: 'active',
  433. },
  434. });
  435. MockApiClient.addMockResponse({
  436. url: '/organizations/org-slug/invite-requests/',
  437. method: 'GET',
  438. body: [inviteRequest],
  439. });
  440. MockApiClient.addMockResponse({
  441. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  442. method: 'PUT',
  443. });
  444. render(<OrganizationMembersList {...defaultProps} />, {
  445. context: RouterContextFixture([{organization: org}]),
  446. });
  447. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  448. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  449. renderGlobalModal();
  450. await userEvent.click(screen.getByTestId('confirm-button'));
  451. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  452. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.approved', {
  453. invite_status: inviteRequest.inviteStatus,
  454. member_id: parseInt(inviteRequest.id, 10),
  455. organization: org,
  456. });
  457. });
  458. it('can deny invite request and remove', async function () {
  459. const org = Organization({
  460. access: ['member:admin', 'org:admin', 'member:write'],
  461. status: {
  462. id: 'active',
  463. name: 'active',
  464. },
  465. });
  466. MockApiClient.addMockResponse({
  467. url: '/organizations/org-slug/invite-requests/',
  468. method: 'GET',
  469. body: [joinRequest],
  470. });
  471. MockApiClient.addMockResponse({
  472. url: `/organizations/org-slug/invite-requests/${joinRequest.id}/`,
  473. method: 'DELETE',
  474. });
  475. render(<OrganizationMembersList {...defaultProps} />, {
  476. context: RouterContextFixture([{organization: org}]),
  477. });
  478. expect(screen.getByText('Pending Members')).toBeInTheDocument();
  479. await userEvent.click(screen.getByRole('button', {name: 'Deny'}));
  480. expect(screen.queryByText('Pending Members')).not.toBeInTheDocument();
  481. expect(trackAnalytics).toHaveBeenCalledWith('invite_request.denied', {
  482. invite_status: joinRequest.inviteStatus,
  483. member_id: parseInt(joinRequest.id, 10),
  484. organization: org,
  485. });
  486. });
  487. it('can update invite requests', async function () {
  488. const org = Organization({
  489. access: ['member:admin', 'org:admin', 'member:write'],
  490. status: {
  491. id: 'active',
  492. name: 'active',
  493. },
  494. });
  495. MockApiClient.addMockResponse({
  496. url: '/organizations/org-slug/invite-requests/',
  497. method: 'GET',
  498. body: [inviteRequest],
  499. });
  500. const updateWithApprove = MockApiClient.addMockResponse({
  501. url: `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  502. method: 'PUT',
  503. });
  504. render(<OrganizationMembersList {...defaultProps} />, {
  505. context: RouterContextFixture([{organization: org}]),
  506. });
  507. await selectEvent.select(screen.getAllByRole('textbox')[1], ['Admin']);
  508. await userEvent.click(screen.getByRole('button', {name: 'Approve'}));
  509. renderGlobalModal();
  510. await userEvent.click(screen.getByTestId('confirm-button'));
  511. expect(updateWithApprove).toHaveBeenCalledWith(
  512. `/organizations/org-slug/invite-requests/${inviteRequest.id}/`,
  513. expect.objectContaining({data: expect.objectContaining({role: 'admin'})})
  514. );
  515. });
  516. });
  517. });