Browse Source

ref: fix some various test mypy errors in mypy 1.11 (#74853)

<!-- Describe your PR here. -->
anthony sottile 7 months ago
parent
commit
ffb2e650cc

+ 6 - 10
tests/sentry/api/endpoints/test_organization_stats.py

@@ -1,4 +1,3 @@
-import functools
 import sys
 
 from django.urls import reverse
@@ -82,16 +81,14 @@ class OrganizationStatsTest(APITestCase, OutcomesSnubaTest):
             teams=[self.create_team(organization=org, members=[self.user])]
         )
 
-        make_request = functools.partial(
-            self.client.get, reverse("sentry-api-0-organization-stats", args=[org.slug])
-        )
+        url = reverse("sentry-api-0-organization-stats", args=[org.slug])
 
-        response = make_request({"id": [project.id], "group": "project"})
+        response = self.client.get(url, {"id": str(project.id), "group": "project"})
 
         assert response.status_code == 200, response.content
         assert project.id in response.data
 
-        response = make_request({"id": [sys.maxsize], "group": "project"})
+        response = self.client.get(url, {"id": str(sys.maxsize), "group": "project"})
 
         assert project.id not in response.data
 
@@ -106,12 +103,11 @@ class OrganizationStatsTest(APITestCase, OutcomesSnubaTest):
             teams=[self.create_team(organization=org, members=[self.user])]
         )
 
-        make_request = functools.partial(
-            self.client.get, reverse("sentry-api-0-organization-stats", args=[org.slug])
+        response = self.client.get(
+            reverse("sentry-api-0-organization-stats", args=[org.slug]),
+            {"projectID": str(project.id), "group": "project"},
         )
 
-        response = make_request({"projectID": [project.id], "group": "project"})
-
         assert response.status_code == 200, response.content
         assert project.id in response.data
         assert project2.id not in response.data

+ 11 - 11
tests/snuba/api/endpoints/test_organization_stats_summary.py

@@ -1,5 +1,8 @@
+from __future__ import annotations
+
 import functools
 from datetime import datetime, timedelta, timezone
+from typing import Any
 
 from django.urls import reverse
 
@@ -736,17 +739,14 @@ class OrganizationStatsSummaryTest(APITestCase, OutcomesSnubaTest):
         }
 
     def test_download(self):
-        make_request = functools.partial(
-            self.client.get,
-            reverse("sentry-api-0-organization-stats-summary", args=[self.org.slug]),
-        )
-        response = make_request(
-            {
-                "statsPeriod": "2d",
-                "interval": "1d",
-                "field": ["sum(quantity)", "sum(times_seen)"],
-                "download": True,
-            }
+        req: dict[str, Any] = {
+            "statsPeriod": "2d",
+            "interval": "1d",
+            "field": ["sum(quantity)", "sum(times_seen)"],
+            "download": True,
+        }
+        response = self.client.get(
+            reverse("sentry-api-0-organization-stats-summary", args=[self.org.slug]), req
         )
 
         assert response.headers["Content-Type"] == "text/csv"