Просмотр исходного кода

ref(crons): Remove SENTRY_MONITORS_HIGH_VOLUME_MODE option (#54561)

This is no longer needed after GH-54388
Evan Purkhiser 1 год назад
Родитель
Сommit
feda4c23f3
1 измененных файлов с 0 добавлено и 29 удалено
  1. 0 29
      src/sentry/conf/server.py

+ 0 - 29
src/sentry/conf/server.py

@@ -3660,32 +3660,3 @@ OPTIONS_AUTOMATOR_SLACK_WEBHOOK_URL: Optional[str] = None
 
 
 SENTRY_METRICS_INTERFACE_BACKEND = "sentry.sentry_metrics.client.snuba.SnubaMetricsBackend"
 SENTRY_METRICS_INTERFACE_BACKEND = "sentry.sentry_metrics.client.snuba.SnubaMetricsBackend"
 SENTRY_METRICS_INTERFACE_BACKEND_OPTIONS: dict[str, Any] = {}
 SENTRY_METRICS_INTERFACE_BACKEND_OPTIONS: dict[str, Any] = {}
-
-# This setting configures how the Monitors (Crons) feature will run the tasks
-# responsible for marking monitors as having "Missed" check-ins and having
-# "Timed out" check-ins.
-#
-# These two tasks must be run every minute and should be run as close to the
-# leading minute boundary as possible. By default these tasks will be
-# triggered via a clock pulse that is generated by a celery beat task. The
-# sentry.monitors.consumer service is responsible for detecting this clock
-# pulse and dispatching the tasks.
-#
-# When high volume mode is enabled, a clock pulse will not be generated by
-# celery beat, instead the monitor consumer will use all processed check-in
-# messages as its clock. We track message timestamps (floored to the minute)
-# and any time that timestamp changes over a minute, the tasks will be
-# triggered
-#
-# NOTE: THERE MUST BE A HIGH VOLUME OF CHECK-INS TO USE THIS MODE!! If a
-#       check-in message is not consumed the tasks will not run, and missed
-#       check-ins will not be generated!
-#
-# The advantage of high volume mode is that we will not rely on celery beat to
-# accurately trigger clock pulses. This is important in scenarios where it is
-# not possible to guarantee that the celery beat tasks will run every minute.
-#
-# (For example, when sentry.io deploys, there is a short period where the
-# celery tasks are being restarted, if they are not running during the minute
-# boundary, the task will not run)
-SENTRY_MONITORS_HIGH_VOLUME_MODE = False