Browse Source

Add tooltips to blank vitals cards (#22774)

Adam McKerlie 4 years ago
parent
commit
fe8b1e734e
1 changed files with 17 additions and 2 deletions
  1. 17 2
      src/sentry/static/sentry/app/views/performance/vitalsCards.tsx

+ 17 - 2
src/sentry/static/sentry/app/views/performance/vitalsCards.tsx

@@ -211,14 +211,26 @@ export function VitalsCard(props: CardProps) {
   const measurement = vitalMap[vitalName];
 
   if (isLoading || !tableData || !tableData.data || !tableData.data[0]) {
-    return <BlankCard noBorder={noBorder} measurement={measurement} />;
+    return (
+      <BlankCard
+        noBorder={noBorder}
+        measurement={measurement}
+        titleDescription={vitalName ? vitalDescription[vitalName] || '' : ''}
+      />
+    );
   }
 
   const result = tableData.data[0];
   const base = result[getAggregateAlias(vitalsBaseFields[vitalName])];
 
   if (!base) {
-    return <BlankCard noBorder={noBorder} measurement={measurement} />;
+    return (
+      <BlankCard
+        noBorder={noBorder}
+        measurement={measurement}
+        titleDescription={vitalName ? vitalDescription[vitalName] || '' : ''}
+      />
+    );
   }
 
   const percents = getPercentsFromCounts(getCounts(result, vitalName));
@@ -341,15 +353,18 @@ function VitalsCardContent(props: CardContentProps) {
 type BlankCardProps = {
   noBorder?: boolean;
   measurement?: string;
+  titleDescription?: string;
 };
 
 const BlankCard = (props: BlankCardProps) => {
   const Container = props.noBorder ? NonPanel : VitalCard;
+
   return (
     <Container interactive>
       {props.noBorder || (
         <HeaderTitle>
           <OverflowEllipsis>{t(`${props.measurement}`)}</OverflowEllipsis>
+          <QuestionTooltip size="sm" position="top" title={props.titleDescription} />
         </HeaderTitle>
       )}
       <CardValue>{'\u2014'}</CardValue>