Просмотр исходного кода

fix(web-vitals): Remove ms unit for CLS tooltip (#27666)

CLS is an unitless quantity, so we should not be using ms in the tooltip
for it.
Abhijeet Prasad 3 лет назад
Родитель
Сommit
fd7e21ab7a
1 измененных файлов с 5 добавлено и 4 удалено
  1. 5 4
      static/app/views/performance/vitalDetail/vitalPercents.tsx

+ 5 - 4
static/app/views/performance/vitalDetail/vitalPercents.tsx

@@ -19,20 +19,21 @@ type Props = {
   showVitalPercentNames?: boolean;
 };
 
-function getVitalStateText(vital, vitalState) {
+function getVitalStateText(vital: WebVital | WebVital[], vitalState) {
+  const unit = !Array.isArray(vital) && vital !== WebVital.CLS ? 'ms' : '';
   switch (vitalState) {
     case VitalState.POOR:
       return Array.isArray(vital)
         ? t('Poor')
-        : tct('Poor: >[threshold]ms', {threshold: webVitalPoor[vital]});
+        : tct('Poor: >[threshold][unit]', {threshold: webVitalPoor[vital], unit});
     case VitalState.MEH:
       return Array.isArray(vital)
         ? t('Meh')
-        : tct('Meh: >[threshold]ms', {threshold: webVitalMeh[vital]});
+        : tct('Meh: >[threshold][unit]', {threshold: webVitalMeh[vital], unit});
     case VitalState.GOOD:
       return Array.isArray(vital)
         ? t('Good')
-        : tct('Good: <[threshold]ms', {threshold: webVitalMeh[vital]});
+        : tct('Good: <[threshold][unit]', {threshold: webVitalMeh[vital], unit});
     default:
       return null;
   }