Просмотр исходного кода

feat(hybridcloud) Backfill organization member mapping records (#49051)

Backfill all the member mapping records from before we started creating
member mappings. This will allow us to leverage member mappings when
breaking foreign keys.

TODO

- [x] verify that all new memberships are created with membermappings.
Mark Story 1 год назад
Родитель
Сommit
fca285e1f2

+ 1 - 1
migrations_lockfile.txt

@@ -6,5 +6,5 @@ To resolve this, rebase against latest master and regenerate your migration. Thi
 will then be regenerated, and you should be able to merge without conflicts.
 
 nodestore: 0002_nodestore_no_dictfield
-sentry: 0468_pickle_to_json_sentry_rawevent
+sentry: 0469_backfill_orgmembermapping
 social_auth: 0001_initial

+ 55 - 0
src/sentry/migrations/0469_backfill_orgmembermapping.py

@@ -0,0 +1,55 @@
+# Generated by Django 2.2.28 on 2023-05-12 19:45
+
+from django.db import migrations
+
+from sentry.new_migrations.migrations import CheckedMigration
+from sentry.utils.query import RangeQuerySetWrapperWithProgressBar
+
+
+def backfill_org_membermapping(apps, schema_editor):
+    OrganizationMember = apps.get_model("sentry", "OrganizationMember")
+    OrganizationMemberMapping = apps.get_model("sentry", "OrganizationMemberMapping")
+
+    for member in RangeQuerySetWrapperWithProgressBar(OrganizationMember.objects.all()):
+        mapping = OrganizationMemberMapping.objects.filter(
+            organization_id=member.organization_id, organizationmember_id=member.id
+        ).first()
+        # Record already exists, we assume it is synced.
+        if mapping:
+            continue
+
+        OrganizationMemberMapping.objects.create(
+            organization_id=member.organization_id,
+            organizationmember_id=member.id,
+            role=member.role,
+            user_id=member.user_id,
+            email=member.email,
+            inviter_id=member.inviter_id,
+            invite_status=member.invite_status,
+        )
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production. For
+    # the most part, this should only be used for operations where it's safe to run the migration
+    # after your code has deployed. So this should not be used for most operations that alter the
+    # schema of a table.
+    # Here are some things that make sense to mark as dangerous:
+    # - Large data migrations. Typically we want these to be run manually by ops so that they can
+    #   be monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   have ops run this and not block the deploy. Note that while adding an index is a schema
+    #   change, it's completely safe to run the operation after the code has deployed.
+    is_dangerous = True
+
+    dependencies = [
+        ("sentry", "0468_pickle_to_json_sentry_rawevent"),
+    ]
+
+    operations = [
+        migrations.RunPython(
+            backfill_org_membermapping,
+            reverse_code=migrations.RunPython.noop,
+            hints={"tables": ["sentry_organizationmembermapping", "sentry_organizationmember"]},
+        )
+    ]

+ 59 - 0
tests/sentry/migrations/test_0469_backfill_orgmembermapping.py

@@ -0,0 +1,59 @@
+from sentry.models.organizationmember import OrganizationMember
+from sentry.models.organizationmembermapping import OrganizationMemberMapping
+from sentry.testutils.cases import TestMigrations
+
+
+class BackfillNotificationSettingTest(TestMigrations):
+    migrate_from = "0468_pickle_to_json_sentry_rawevent"
+    migrate_to = "0469_backfill_orgmembermapping"
+
+    def setup_initial_state(self):
+        self.owner = self.create_user()
+        self.member = OrganizationMember.objects.create(
+            organization=self.organization,
+            user_id=self.owner.id,
+            role="owner",
+        )
+        self.invite = OrganizationMember.objects.create(
+            organization=self.organization,
+            email="test@example.com",
+            inviter_id=self.user.id,
+            role="member",
+        )
+
+        member_user = self.create_user()
+        self.member_with_mapping = OrganizationMember.objects.create(
+            organization=self.organization,
+            user_id=member_user.id,
+            role="member",
+        )
+        OrganizationMemberMapping.objects.create(
+            organization_id=self.organization.id,
+            organizationmember_id=self.member_with_mapping.id,
+            user_id=member_user.id,
+            role=self.member_with_mapping.role,
+        )
+
+    def test(self):
+        # Generated mapping for invite record.
+        mapping = OrganizationMemberMapping.objects.get(email=self.invite.email)
+        assert mapping.inviter_id == self.invite.inviter_id
+        assert mapping.organizationmember_id == self.invite.id
+        assert mapping.organization_id == self.invite.organization_id
+        assert mapping.user_id is None
+        assert mapping.role == self.invite.role
+
+        # Generated mapping for member record
+        mapping = OrganizationMemberMapping.objects.get(organizationmember_id=self.member.id)
+        assert mapping.organizationmember_id == self.member.id
+        assert mapping.organization_id == self.member.organization_id
+        assert mapping.user_id == self.member.user_id
+        assert mapping.role == self.member.role
+
+        # No duplicates created
+        assert (
+            OrganizationMemberMapping.objects.filter(
+                user_id=self.member_with_mapping.user_id
+            ).count()
+            == 1
+        )