Browse Source

fix(dashboards): fixes open in discover for widget viewer url(#32914)

Open in Discover was giving a different Discover Query in the Widget Viewer compared to the context menu. This updates the the Widget Viewer to match the context menu.
edwardgou-sentry 3 years ago
parent
commit
f989a083d9

+ 1 - 1
static/app/components/modals/widgetViewerModal.tsx

@@ -600,7 +600,7 @@ function WidgetViewerModal(props: Props) {
     default:
       openLabel = t('Open in Discover');
       path = getWidgetDiscoverUrl(
-        {...primaryWidget, queries: tableWidget.queries},
+        {...primaryWidget, queries: [primaryWidget.queries[selectedQueryIndex]]},
         modalSelection,
         organization
       );

+ 2 - 2
tests/js/spec/components/modals/widgetViewerModal.spec.tsx

@@ -174,7 +174,7 @@ describe('Modals -> WidgetViewerModal', function () {
       await renderModal({initialData, widget: mockWidget});
       expect(screen.getByRole('button', {name: 'Open in Discover'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/discover/results/?field=title&field=count%28%29&name=Test%20Widget&query=title%3A%2Forganizations%2F%3AorgId%2Fperformance%2Fsummary%2F&sort=-count&statsPeriod=14d&yAxis=count%28%29'
+        '/organizations/org-slug/discover/results/?field=count%28%29&name=Test%20Widget&query=title%3A%2Forganizations%2F%3AorgId%2Fperformance%2Fsummary%2F&statsPeriod=14d&yAxis=count%28%29'
       );
     });
 
@@ -243,7 +243,7 @@ describe('Modals -> WidgetViewerModal', function () {
       await renderModal({initialData, widget: mockWidget});
       expect(screen.getByRole('button', {name: 'Open in Discover'})).toHaveAttribute(
         'href',
-        '/organizations/org-slug/discover/results/?field=title&field=count%28%29&name=Test%20Widget&query=&sort=-count&statsPeriod=14d&yAxis=count%28%29'
+        '/organizations/org-slug/discover/results/?field=count%28%29&name=Test%20Widget&query=&statsPeriod=14d&yAxis=count%28%29'
       );
     });