Browse Source

:wrench: chore(notifications): fix typing in notifications mixin (#78416)

quick typing fix
Raj Joshi 5 months ago
parent
commit
f9288f464e
2 changed files with 17 additions and 1 deletions
  1. 0 1
      pyproject.toml
  2. 17 0
      src/sentry/integrations/mixins/notifications.py

+ 0 - 1
pyproject.toml

@@ -250,7 +250,6 @@ module = [
     "sentry.integrations.jira_server.client",
     "sentry.integrations.jira_server.integration",
     "sentry.integrations.metric_alerts",
-    "sentry.integrations.mixins.notifications",
     "sentry.integrations.msteams.actions.form",
     "sentry.integrations.msteams.client",
     "sentry.integrations.msteams.integration",

+ 17 - 0
src/sentry/integrations/mixins/notifications.py

@@ -1,5 +1,7 @@
 import logging
 
+from sentry_sdk import capture_message
+
 from sentry.integrations.models.external_actor import ExternalActor
 from sentry.models.team import Team
 
@@ -22,6 +24,21 @@ class NotifyBasicMixin:
         """
         Notify through the integration that an external team has been removed.
         """
+        if not external_team.external_id:
+            logger.info(
+                "notify.external_team_missing_external_id",
+                extra={
+                    "external_team_id": external_team.id,
+                    "team_id": team.id,
+                    "team_slug": team.slug,
+                },
+            )
+            capture_message(
+                f"External team {external_team.id} has no external_id",
+                level="warning",
+            )
+            return
+
         self.send_message(
             channel_id=external_team.external_id,
             message=SUCCESS_UNLINKED_TEAM_MESSAGE.format(team=team.slug),