Просмотр исходного кода

ref(typescript): Convert a few test stubs (#52921)

- TestStubs.Span
- TestStubs.Tags
- TestStubs.Subscriptions
- TestStubs.TagValues
- TestStubs.TeamAlertsTriggered
- TestStubs.IssuesBreakdown
- TestStubs.TeamAlertsTriggered
- TestStubs.Tombstones
George Gritsouk 1 год назад
Родитель
Сommit
f89ccc939d

+ 4 - 1
fixtures/js-stubs/span.js → fixtures/js-stubs/span.ts

@@ -1,4 +1,6 @@
-export function Span(params = {}) {
+import type {RawSpanType} from 'sentry/components/events/interfaces/spans/types';
+
+export function Span(params = {}): RawSpanType {
   return {
     timestamp: 1657201239.51,
     start_timestamp: 1657201239.503,
@@ -6,6 +8,7 @@ export function Span(params = {}) {
     span_id: 'a385d9fd52e0c4bc',
     parent_span_id: 'bdf1a9fae2062311',
     trace_id: '4d5c2e2102234a7d94102b4f1e41c2bb',
+    data: {},
     ...params,
   };
 }

+ 3 - 1
fixtures/js-stubs/subscriptions.js → fixtures/js-stubs/subscriptions.ts

@@ -1,4 +1,6 @@
-export function Subscriptions(params = []) {
+import type {Subscription} from 'sentry/views/settings/account/accountSubscriptions';
+
+export function Subscriptions(params = []): Subscription[] {
   return [
     {
       subscribedDate: '2018-01-08T05:14:59.102Z',

+ 14 - 2
fixtures/js-stubs/tags.js → fixtures/js-stubs/tags.ts

@@ -1,4 +1,6 @@
-export function Tags(params = []) {
+import type {TagWithTopValues} from 'sentry/types';
+
+export function Tags(params = []): TagWithTopValues[] {
   return [
     {
       topValues: [
@@ -60,11 +62,21 @@ export function Tags(params = []) {
       canDelete: true,
     },
     {
-      topValues: [{name: 'prod', value: 'prod', key: 'environment', count: 100}],
+      topValues: [
+        {
+          name: 'prod',
+          value: 'prod',
+          key: 'environment',
+          count: 100,
+          lastSeen: '2018-12-20T23:32:25Z',
+          firstSeen: '2018-05-06T03:48:28.825Z',
+        },
+      ],
       key: 'environment',
       name: 'Environment',
       canDelete: false,
       totalValues: 100,
+      uniqueValues: 1,
     },
     {
       topValues: [

+ 5 - 5
fixtures/js-stubs/tagvalues.js → fixtures/js-stubs/tagvalues.ts

@@ -1,9 +1,9 @@
-export function TagValues(params = []) {
+import type {TagValue} from 'sentry/types';
+
+export function TagValues(params = []): TagValue[] {
   return [
     {
       username: 'david',
-      hash: '172522ec1028ab781d9dfd17eaca4427',
-      dateCreated: '2018-10-03T03:39:51.223Z',
       lastSeen: '2018-12-20T23:32:25Z',
       query: 'user.username:david',
       id: '10799',
@@ -13,10 +13,10 @@ export function TagValues(params = []) {
       avatarUrl:
         'https://secure.gravatar.com/avatar/d66694bbc7619203377bd9c9b7b9f14a?s=32&d=mm',
       value: 'username:david',
-      tagValue: 'username:david',
-      identifier: null,
+      identifier: undefined,
       ipAddress: '128.126.232.84',
       email: 'david@example.com',
+      ip_address: '0.0.0.0',
     },
     ...params,
   ];

+ 3 - 1
fixtures/js-stubs/teamAlertsTriggered.js → fixtures/js-stubs/teamAlertsTriggered.ts

@@ -1,4 +1,6 @@
-export function TeamAlertsTriggered() {
+import type {AlertsTriggered} from 'sentry/views/organizationStats/teamInsights/teamAlertsTriggered';
+
+export function TeamAlertsTriggered(): AlertsTriggered {
   return {
     '2021-08-20T00:00:00Z': 3,
     '2021-08-21T00:00:00Z': 2,

+ 3 - 29
fixtures/js-stubs/teamIssuesBreakdown.js → fixtures/js-stubs/teamIssuesBreakdown.ts

@@ -1,8 +1,9 @@
-export function TeamIssuesBreakdown() {
+import type {IssuesBreakdown} from 'sentry/views/organizationStats/teamInsights/teamIssuesBreakdown';
+
+export function TeamIssuesBreakdown(): IssuesBreakdown {
   return {
     2: {
       '2021-11-19T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -12,7 +13,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-11-20T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -22,7 +22,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-11-21T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -32,7 +31,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-11-22T00:00:00+00:00': {
-        reviewed: 11,
         deleted: 11,
         ignored: 11,
         resolved: 11,
@@ -42,7 +40,6 @@ export function TeamIssuesBreakdown() {
         total: 11,
       },
       '2021-11-23T00:00:00+00:00': {
-        reviewed: 7,
         deleted: 7,
         ignored: 7,
         resolved: 7,
@@ -52,7 +49,6 @@ export function TeamIssuesBreakdown() {
         total: 20,
       },
       '2021-11-24T00:00:00+00:00': {
-        reviewed: 4,
         deleted: 4,
         ignored: 4,
         resolved: 4,
@@ -62,7 +58,6 @@ export function TeamIssuesBreakdown() {
         total: 10,
       },
       '2021-11-25T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -72,7 +67,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-11-26T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -82,7 +76,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-11-27T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -92,7 +85,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-11-28T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -102,7 +94,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-11-29T00:00:00+00:00': {
-        reviewed: 8,
         deleted: 8,
         ignored: 8,
         resolved: 8,
@@ -112,7 +103,6 @@ export function TeamIssuesBreakdown() {
         total: 8,
       },
       '2021-11-30T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -122,7 +112,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-01T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -132,7 +121,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-02T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -142,7 +130,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-03T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -152,7 +139,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-04T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -162,7 +148,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-05T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -172,7 +157,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-06T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -182,7 +166,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-07T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -192,7 +175,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-08T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -202,7 +184,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-09T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -212,7 +193,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-10T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -222,7 +202,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-11T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -232,7 +211,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-12T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -242,7 +220,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-13T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -252,7 +229,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-14T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -262,7 +238,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-15T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,
@@ -272,7 +247,6 @@ export function TeamIssuesBreakdown() {
         total: 0,
       },
       '2021-12-16T00:00:00+00:00': {
-        reviewed: 0,
         deleted: 0,
         ignored: 0,
         resolved: 0,

+ 0 - 60
fixtures/js-stubs/tombstones.js

@@ -1,60 +0,0 @@
-export function Tombstones(params = []) {
-  return [
-    {
-      culprit: 'poll(../../sentry/scripts/views.js)',
-      level: 'error',
-      actor: {
-        username: 'billy@sentry.io',
-        emails: [
-          {is_verified: false, id: '28', email: 'test@test.com'},
-          {is_verified: false, id: '17', email: 'billy36@sentry.io'},
-          {is_verified: false, id: '11', email: 'awerawer@awe.com'},
-          {is_verified: true, id: '10', email: 'billy2@sentry.io'},
-          {is_verified: true, id: '5', email: 'billy@sentry.io'},
-        ],
-        isManaged: false,
-        lastActive: '2018-02-21T01:27:52.255Z',
-        identities: [
-          {
-            name: '79684',
-            dateVerified: '2018-02-21T00:52:40.149Z',
-            provider: {id: 'github', name: 'GitHub'},
-            dateSynced: '2018-02-21T00:52:40.149Z',
-            organization: {slug: 'default', name: 'default'},
-            id: '1',
-          },
-        ],
-        id: '1',
-        isActive: true,
-        has2fa: true,
-        name: 'billy vong',
-        avatarUrl:
-          'https://secure.gravatar.com/avatar/7b544e8eb9d08ed777be5aa82121155a?s=32&d=mm',
-        dateJoined: '2018-01-10T00:19:59Z',
-        options: {
-          timezone: 'America/Los_Angeles',
-          seenReleaseBroadcast: true,
-          stacktraceOrder: -1,
-          language: 'en',
-          clock24Hours: false,
-        },
-        avatar: {
-          avatarUuid: '483ed7478a2248d59211f538c2997e0b',
-          avatarType: 'letter_avatar',
-        },
-        lastLogin: '2018-02-14T07:09:37.536Z',
-        permissions: [],
-        email: 'billy@sentry.io',
-      },
-      message:
-        "This is an example JavaScript exception TypeError Object [object Object] has no method 'updateFrom' poll(../../sentry/scripts/views.js)",
-      type: 'error',
-      id: '1',
-      metadata: {
-        type: 'TypeError',
-        value: "Object [object Object] has no method 'updateFrom'",
-      },
-    },
-    ...params,
-  ];
-}

+ 30 - 0
fixtures/js-stubs/tombstones.ts

@@ -0,0 +1,30 @@
+import {EventOrGroupType, GroupTombstone} from 'sentry/types';
+
+export function Tombstones(params = []): GroupTombstone[] {
+  return [
+    {
+      culprit: 'poll(../../sentry/scripts/views.js)',
+      level: 'error',
+      actor: {
+        username: 'billy@sentry.io',
+        id: '1',
+        name: 'billy vong',
+        avatarUrl:
+          'https://secure.gravatar.com/avatar/7b544e8eb9d08ed777be5aa82121155a?s=32&d=mm',
+        avatar: {
+          avatarUuid: '483ed7478a2248d59211f538c2997e0b',
+          avatarType: 'letter_avatar',
+        },
+        email: 'billy@sentry.io',
+        ip_address: '0.0.0.0',
+      },
+      type: EventOrGroupType.ERROR,
+      id: '1',
+      metadata: {
+        type: 'TypeError',
+        value: "Object [object Object] has no method 'updateFrom'",
+      },
+    },
+    ...params,
+  ];
+}

+ 1 - 1
static/app/views/organizationStats/teamInsights/teamAlertsTriggered.tsx

@@ -23,7 +23,7 @@ import {MetricRule} from 'sentry/views/alerts/rules/metric/types';
 import {ProjectBadge, ProjectBadgeContainer} from './styles';
 import {barAxisLabel, convertDayValueObjectToSeries, sortSeriesByDay} from './utils';
 
-type AlertsTriggered = Record<string, number>;
+export type AlertsTriggered = Record<string, number>;
 
 type AlertsTriggeredRule = MetricRule & {
   totalThisWeek: number;

+ 1 - 1
static/app/views/organizationStats/teamInsights/teamIssuesBreakdown.tsx

@@ -30,7 +30,7 @@ interface StatusCounts {
   unignored?: number;
 }
 
-type IssuesBreakdown = Record<string, Record<string, StatusCounts>>;
+export type IssuesBreakdown = Record<string, Record<string, StatusCounts>>;
 
 type Statuses = keyof Omit<StatusCounts, 'total'>;
 

Некоторые файлы не были показаны из-за большого количества измененных файлов