Browse Source

ref: fix some bytes warnings in tests (#70734)

these tests fail when run with `-b`

<!-- Describe your PR here. -->
anthony sottile 10 months ago
parent
commit
f88583df4f

+ 3 - 3
tests/sentry/api/endpoints/test_project_release_file_details.py

@@ -224,7 +224,7 @@ class ReleaseFileUpdateTest(APITestCase):
         self.login_as(user=self.user)
         self.create_release_archive()
 
-        id = urlsafe_b64encode(b"_~/index.js")
+        id = urlsafe_b64encode(b"_~/index.js").decode()
 
         url = reverse(
             "sentry-api-0-project-release-file-details",
@@ -302,10 +302,10 @@ class ReleaseFileDeleteTest(APITestCase):
         assert response.status_code == 204
         assert self.release.count_artifacts() == 1
 
-        response = self.client.delete(url(urlsafe_b64encode(b"invalid_id")))
+        response = self.client.delete(url(urlsafe_b64encode(b"invalid_id").decode()))
         assert response.status_code == 404
         assert self.release.count_artifacts() == 1
 
-        response = self.client.delete(url(urlsafe_b64encode(b"_~/does_not_exist.js")))
+        response = self.client.delete(url(urlsafe_b64encode(b"_~/does_not_exist.js").decode()))
         assert response.status_code == 404
         assert self.release.count_artifacts() == 1

+ 2 - 2
tests/sentry/integrations/jira/test_sentry_issue_details.py

@@ -106,7 +106,7 @@ class JiraIssueHookTest(APITestCase):
         mock_get_integration_from_request.return_value = self.integration
         response = self.client.get(self.path)
         assert response.status_code == 200
-        resp_content = str(response.content)
+        resp_content = response.content.decode()
         assert self.group.title in resp_content
         assert self.group.get_absolute_url() in resp_content
         assert self.first_seen.strftime("%b. %d, %Y") in resp_content
@@ -137,7 +137,7 @@ class JiraIssueHookTest(APITestCase):
         response = self.client.get(self.path)
 
         assert response.status_code == 200
-        resp_content = str(response.content)
+        resp_content = response.content.decode()
         group_url = self.group.get_absolute_url()
         new_group_url = new_group.get_absolute_url()
 

+ 1 - 1
tests/sentry/integrations/test_pipeline.py

@@ -476,4 +476,4 @@ class GitlabFinishPipelineTest(IntegrationTestCase):
         }
         resp = self.pipeline.finish_pipeline()
         assert not OrganizationIntegration.objects.filter(integration_id=integration.id)
-        assert "account is linked to a different Sentry user" in str(resp.content)
+        assert "account is linked to a different Sentry user" in resp.content.decode()