chore(dashboards): remove manage dashboards utils file (#80335)

I previously put a TODO in the manage dashboards `utils.tsx` file to get
rid of it and move its functions to `index.tsx`. Contributes to having
less utils files and more descriptive file names

static/app/views/dashboards/manage/dashboardList.tsx

@@ -26,7 +26,7 @@ import withApi from 'sentry/utils/withApi';
 import {
   DASHBOARD_CARD_GRID_PADDING,
   MINIMUM_DASHBOARD_CARD_WIDTH,
-} from 'sentry/views/dashboards/manage/utils';
+} from 'sentry/views/dashboards/manage/settings';
 import type {DashboardListItem} from 'sentry/views/dashboards/types';
 
 import {cloneDashboard} from '../utils';

static/app/views/dashboards/manage/index.tsx

@@ -26,6 +26,7 @@ import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
 import type {SelectValue} from 'sentry/types/core';
 import {trackAnalytics} from 'sentry/utils/analytics';
+import localStorage from 'sentry/utils/localStorage';
 import parseLinkHeader from 'sentry/utils/parseLinkHeader';
 import {useApiQuery} from 'sentry/utils/queryClient';
 import {decodeScalar} from 'sentry/utils/queryString';
@@ -44,16 +45,14 @@ import {assignDefaultLayout, getInitialColumnDepths} from '../layoutUtils';
 import type {DashboardDetails, DashboardListItem} from '../types';
 
 import DashboardList from './dashboardList';
-import TemplateCard from './templateCard';
 import {
   DASHBOARD_CARD_GRID_PADDING,
   DASHBOARD_GRID_DEFAULT_NUM_CARDS,
   DASHBOARD_GRID_DEFAULT_NUM_COLUMNS,
   DASHBOARD_GRID_DEFAULT_NUM_ROWS,
   MINIMUM_DASHBOARD_CARD_WIDTH,
-  shouldShowTemplates,
-  SHOW_TEMPLATES_KEY,
-} from './utils';
+} from './settings';
+import TemplateCard from './templateCard';
 
 const SORT_OPTIONS: SelectValue<string>[] = [
   {label: t('My Dashboards'), value: 'mydashboards'},
@@ -64,6 +63,13 @@ const SORT_OPTIONS: SelectValue<string>[] = [
   {label: t('Recently Viewed'), value: 'recentlyViewed'},
 ];
 
+const SHOW_TEMPLATES_KEY = 'dashboards-show-templates';
+
+function shouldShowTemplates(): boolean {
+  const shouldShow = localStorage.getItem(SHOW_TEMPLATES_KEY);
+  return shouldShow === 'true' || shouldShow === null;
+}
+
 function ManageDashboards() {
   const organization = useOrganization();
   const navigate = useNavigate();

static/app/views/dashboards/manage/settings.tsx

@@ -0,0 +1,7 @@
+import {space} from 'sentry/styles/space';
+
+export const MINIMUM_DASHBOARD_CARD_WIDTH = 300;
+export const DASHBOARD_CARD_GRID_PADDING = Number(space(2).replace('px', ''));
+export const DASHBOARD_GRID_DEFAULT_NUM_ROWS = 3;
+export const DASHBOARD_GRID_DEFAULT_NUM_COLUMNS = 3;
+export const DASHBOARD_GRID_DEFAULT_NUM_CARDS = 8;

static/app/views/dashboards/manage/utils.tsx

@@ -1,19 +0,0 @@
-import {space} from 'sentry/styles/space';
-import localStorage from 'sentry/utils/localStorage';
-
-// TODO(nikkikapadia): delete this file and move contents to index.tsx
-export const SHOW_TEMPLATES_KEY = 'dashboards-show-templates';
-
-export const MINIMUM_DASHBOARD_CARD_WIDTH = 300;
-export const DASHBOARD_CARD_GRID_PADDING = Number(space(2).replace('px', ''));
-export const DASHBOARD_GRID_DEFAULT_NUM_ROWS = 3;
-export const DASHBOARD_GRID_DEFAULT_NUM_COLUMNS = 3;
-export const DASHBOARD_GRID_DEFAULT_NUM_CARDS = 8;
-
-export function shouldShowTemplates(): boolean {
-  const shouldShow = localStorage.getItem(SHOW_TEMPLATES_KEY);
-  return shouldShow === 'true' || shouldShow === null;
-}
-export function setShowTemplates(value: boolean) {
-  localStorage.setItem(SHOW_TEMPLATES_KEY, value ? 'true' : 'false');
-}