Browse Source

fix(ui): Consistent PanelHeader button sizing (#55164)

Fixes various places where buttons are too big for headers
Evan Purkhiser 1 year ago
parent
commit
f7de14bdee

+ 1 - 1
static/app/components/pluginConfig.tsx

@@ -132,7 +132,7 @@ class PluginConfig extends Component<Props, State> {
                 </Button>
               )}
               <Button
-                size="sm"
+                size="xs"
                 onClick={this.handleDisablePlugin}
                 disabled={!hasWriteAccess}
               >

+ 1 - 1
static/app/views/settings/components/teamSelect/teamSelectForMember.tsx

@@ -111,7 +111,7 @@ function TeamSelect({
 
   return (
     <Panel>
-      <TeamPanelHeader>
+      <TeamPanelHeader hasButtons>
         <div>{t('Team')}</div>
         <div />
         <div>

+ 1 - 6
static/app/views/settings/components/teamSelect/utils.tsx

@@ -100,12 +100,7 @@ export function DropdownAddTeam({
       alignMenu="right"
     >
       {({isOpen}) => (
-        <DropdownButton
-          aria-label={t('Add Team')}
-          isOpen={isOpen}
-          size="xs"
-          disabled={disabled}
-        >
+        <DropdownButton isOpen={isOpen} size="xs" disabled={disabled}>
           {t('Add Team')}
         </DropdownButton>
       )}

+ 1 - 0
static/app/views/settings/project/loaderScript.tsx

@@ -115,6 +115,7 @@ function LoaderItem({
         {tct('Client Key: [name]', {name: projectKey.name})}
 
         <LinkButton
+          size="xs"
           to={`/settings/${organization.slug}/projects/${project.slug}/keys/${projectKey.id}/`}
         >
           {t('View Key Details')}

+ 3 - 3
static/app/views/settings/project/projectKeys/list/keyRow.tsx

@@ -58,7 +58,7 @@ function KeyRow({
           )}
         </Title>
         <Controls>
-          <Button to={editUrl} size="sm">
+          <Button to={editUrl} size="xs">
             {t('Configure')}
           </Button>
           <Confirm
@@ -71,7 +71,7 @@ function KeyRow({
                 : t('Are you sure you want to enable this key?')
             }
           >
-            <Button size="sm">{data.isActive ? t('Disable') : t('Enable')}</Button>
+            <Button size="xs">{data.isActive ? t('Disable') : t('Enable')}</Button>
           </Confirm>
           <Confirm
             disabled={!hasWriteAccess}
@@ -82,7 +82,7 @@ function KeyRow({
               'Are you sure you want to remove this key? This action is irreversible.'
             )}
           >
-            <Button size="sm" icon={<IconDelete />} aria-label={t('Delete')} />
+            <Button size="xs" icon={<IconDelete size="xs" />} aria-label={t('Delete')} />
           </Confirm>
         </Controls>
       </PanelHeader>

+ 1 - 2
static/app/views/settings/projectDebugFiles/sources/customRepositories/index.tsx

@@ -235,8 +235,7 @@ function CustomRepositories({
                         <DropdownButton
                           isOpen={isOpen}
                           disabled={addRepositoryButtonDisabled}
-                          size="sm"
-                          aria-label={t('Add Repository')}
+                          size="xs"
                         >
                           {t('Add Repository')}
                         </DropdownButton>