Browse Source

Revert "ref(performance): Remove unsupported transaction summary features" (#71022)

Reverts getsentry/sentry#67731

We no longer need to hide these elements for the time being
Ash 9 months ago
parent
commit
f525785a95

+ 1 - 6
static/app/components/discover/transactionsList.tsx

@@ -287,11 +287,6 @@ class _TransactionsList extends Component<Props> {
     const cursorOffset = parseCursor(cursor)?.offset ?? 0;
     numSamples = numSamples ?? null;
     const totalNumSamples = numSamples === null ? null : numSamples + cursorOffset;
-
-    const hasTransactionSummaryCleanupFlag = organization.features.includes(
-      'performance-transaction-summary-cleanup'
-    );
-
     return (
       <Fragment>
         <div>
@@ -302,7 +297,7 @@ class _TransactionsList extends Component<Props> {
             onChange={opt => handleDropdownChange(opt.value)}
           />
         </div>
-        {supportsInvestigationRule && !hasTransactionSummaryCleanupFlag && (
+        {supportsInvestigationRule && (
           <InvestigationRuleWrapper>
             <InvestigationRuleCreation
               buttonProps={{size: 'xs'}}

+ 1 - 8
static/app/views/performance/transactionSummary/header.tsx

@@ -114,10 +114,6 @@ function TransactionHeader({
   });
   const replaysCount = getReplayCountForTransaction(transactionName);
 
-  const hasTransactionSummaryCleanupFlag = organization.features.includes(
-    'performance-transaction-summary-cleanup'
-  );
-
   return (
     <Layout.Header>
       <Layout.HeaderContent>
@@ -200,10 +196,7 @@ function TransactionHeader({
               <TabList.Item key={Tab.TRANSACTION_SUMMARY}>{t('Overview')}</TabList.Item>
               <TabList.Item key={Tab.EVENTS}>{t('Sampled Events')}</TabList.Item>
               <TabList.Item key={Tab.TAGS}>{t('Tags')}</TabList.Item>
-              <TabList.Item key={Tab.SPANS} hidden={hasTransactionSummaryCleanupFlag}>
-                {t('Spans')}
-              </TabList.Item>
-
+              <TabList.Item key={Tab.SPANS}>{t('Spans')}</TabList.Item>
               <TabList.Item
                 key={Tab.ANOMALIES}
                 textValue={t('Anomalies')}

+ 20 - 35
static/app/views/performance/transactionSummary/transactionOverview/content.tsx

@@ -330,24 +330,15 @@ function SummaryContent({
     handleOpenAllEventsClick: handleAllEventsViewClick,
   };
 
-  const hasTransactionSummaryCleanupFlag = organization.features.includes(
-    'performance-transaction-summary-cleanup'
-  );
-
   return (
     <Fragment>
       <Layout.Main>
-        <FilterActions
-          hasTransactionSummaryCleanupFlag={hasTransactionSummaryCleanupFlag}
-        >
-          {!hasTransactionSummaryCleanupFlag && (
-            <Filter
-              organization={organization}
-              currentFilter={spanOperationBreakdownFilter}
-              onChangeFilter={onChangeFilter}
-            />
-          )}
-
+        <FilterActions>
+          <Filter
+            organization={organization}
+            currentFilter={spanOperationBreakdownFilter}
+            onChangeFilter={onChangeFilter}
+          />
           <PageFilterBar condensed>
             <EnvironmentPageFilter />
             <DatePageFilter />
@@ -408,21 +399,18 @@ function SummaryContent({
           />
         </PerformanceAtScaleContextProvider>
 
-        {!hasTransactionSummaryCleanupFlag && (
-          <SuspectSpans
-            location={location}
-            organization={organization}
-            eventView={eventView}
-            totals={
-              defined(totalValues?.['count()'])
-                ? {'count()': totalValues!['count()']}
-                : null
-            }
-            projectId={projectId}
-            transactionName={transactionName}
-          />
-        )}
-
+        <SuspectSpans
+          location={location}
+          organization={organization}
+          eventView={eventView}
+          totals={
+            defined(totalValues?.['count()'])
+              ? {'count()': totalValues!['count()']}
+              : null
+          }
+          projectId={projectId}
+          transactionName={transactionName}
+        />
         <TagExplorer
           eventView={eventView}
           organization={organization}
@@ -560,7 +548,7 @@ function getTransactionsListSort(
   return {selected: selectedSort, options: sortOptions};
 }
 
-const FilterActions = styled('div')<{hasTransactionSummaryCleanupFlag: boolean}>`
+const FilterActions = styled('div')`
   display: grid;
   gap: ${space(2)};
   margin-bottom: ${space(2)};
@@ -570,10 +558,7 @@ const FilterActions = styled('div')<{hasTransactionSummaryCleanupFlag: boolean}>
   }
 
   @media (min-width: ${p => p.theme.breakpoints.xlarge}) {
-    ${p =>
-      p.hasTransactionSummaryCleanupFlag
-        ? `grid-template-columns: auto 1fr;`
-        : `grid-template-columns: auto auto 1fr;`}
+    grid-template-columns: auto auto 1fr;
   }
 `;