Browse Source

ref(profiling): Propagate any exception other than `RetrySymbolication` (#41216)

Propagate any exception other than `RetrySymbolication` occurring in
`_symbolicate`
Francesco Vigliaturo 2 years ago
parent
commit
f4ac410334
1 changed files with 1 additions and 4 deletions
  1. 1 4
      src/sentry/profiles/task.py

+ 1 - 4
src/sentry/profiles/task.py

@@ -82,6 +82,7 @@ def process_profile(
             _process_symbolicator_results(profile=profile, modules=modules, stacktraces=stacktraces)
     except Exception as e:
         sentry_sdk.capture_exception(e)
+        metrics.incr("process_profile.symbolicate.error", sample_rate=1.0)
         _track_outcome(
             profile=profile,
             project=project,
@@ -239,10 +240,6 @@ def _symbolicate(
                 )
                 sleep(sleep_time)
                 continue
-        except Exception as e:
-            sentry_sdk.capture_exception(e)
-            metrics.incr("process_profile.symbolicate.error", sample_rate=1.0)
-            break
 
     # returns the unsymbolicated data to avoid errors later
     return (modules, stacktraces)