Browse Source

ref(externalissue): Extend key field (#33331)

Colleen O'Rourke 2 years ago
parent
commit
f052f5b7f1

+ 1 - 1
migrations_lockfile.txt

@@ -6,5 +6,5 @@ To resolve this, rebase against latest master and regenerate your migration. Thi
 will then be regenerated, and you should be able to merge without conflicts.
 
 nodestore: 0002_nodestore_no_dictfield
-sentry: 0282_add_field_aliases_dashboard_widget_query
+sentry: 0283_extend_externalissue_key
 social_auth: 0001_initial

+ 36 - 0
src/sentry/migrations/0283_extend_externalissue_key.py

@@ -0,0 +1,36 @@
+# Generated by Django 2.2.27 on 2022-04-05 22:18
+
+from django.db import migrations, models
+
+from sentry.new_migrations.migrations import CheckedMigration
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production. For
+    # the most part, this should only be used for operations where it's safe to run the migration
+    # after your code has deployed. So this should not be used for most operations that alter the
+    # schema of a table.
+    # Here are some things that make sense to mark as dangerous:
+    # - Large data migrations. Typically we want these to be run manually by ops so that they can
+    #   be monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   have ops run this and not block the deploy. Note that while adding an index is a schema
+    #   change, it's completely safe to run the operation after the code has deployed.
+    is_dangerous = False
+
+    # This flag is used to decide whether to run this migration in a transaction or not. Generally
+    # we don't want to run in a transaction here, since for long running operations like data
+    # back-fills this results in us locking an increasing number of rows until we finally commit.
+    atomic = False
+
+    dependencies = [
+        ("sentry", "0282_add_field_aliases_dashboard_widget_query"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="externalissue",
+            name="key",
+            field=models.CharField(max_length=256),
+        ),
+    ]

+ 1 - 1
src/sentry/models/integrations/external_issue.py

@@ -55,7 +55,7 @@ class ExternalIssue(Model):
     # The foreign key here is an `int`, not `bigint`.
     integration = FlexibleForeignKey("sentry.Integration", db_constraint=False)
 
-    key = models.CharField(max_length=128)  # example APP-123 in jira
+    key = models.CharField(max_length=256)  # example APP-123 in jira
     date_added = models.DateTimeField(default=timezone.now)
     title = models.TextField(null=True)
     description = models.TextField(null=True)