Browse Source

fix: Fix some null references and missing tag trimming (#11848)

Markus Unterwaditzer 6 years ago
parent
commit
ecfaf13976
2 changed files with 4 additions and 4 deletions
  1. 3 3
      src/sentry/event_manager.py
  2. 1 1
      src/sentry/utils/contexts_normalization.py

+ 3 - 3
src/sentry/event_manager.py

@@ -90,7 +90,7 @@ def pop_tag(data, key):
 
 def set_tag(data, key, value):
     pop_tag(data, key)
-    data['tags'].append((key, value))
+    data['tags'].append((key, trim(value, MAX_TAG_VALUE_LENGTH)))
 
 
 def get_tag(data, key):
@@ -923,9 +923,9 @@ class EventManager(object):
         if logger_name:
             set_tag(data, 'logger', logger_name)
         if environment:
-            set_tag(data, 'environment', trim(environment, MAX_TAG_VALUE_LENGTH))
+            set_tag(data, 'environment', environment)
         if transaction_name:
-            set_tag(data, 'transaction', trim(transaction_name, MAX_TAG_VALUE_LENGTH))
+            set_tag(data, 'transaction', transaction_name)
 
         if release:
             # dont allow a conflicting 'release' tag

+ 1 - 1
src/sentry/utils/contexts_normalization.py

@@ -53,7 +53,7 @@ def normalize_runtime(data):
     # RuntimeInformation.FrameworkDescription doesn't return a very useful value.
     # example: .NET Framework 4.7.3056.0
     # Release key dug from registry and sent as #build
-    if data.get('name').startswith('.NET Framework'):
+    if (data.get('name') or "").startswith('.NET Framework'):
         build = data.get('build')
 
         if build is not None: