Просмотр исходного кода

tests(acceptance): Remove waiting for assistant cue (#11975)

This has been causing travis failures, it's better to deal with percy than waiting 20 minutes to re-run a test.
Billy Vong 6 лет назад
Родитель
Сommit
e704dc42f0
1 измененных файлов с 7 добавлено и 8 удалено
  1. 7 8
      tests/acceptance/test_issue_details.py

+ 7 - 8
tests/acceptance/test_issue_details.py

@@ -138,7 +138,7 @@ class IssueDetailsTest(AcceptanceTestCase):
         self.browser.get(
             u'/{}/{}/issues/{}/'.format(self.org.slug, self.project.slug, event.group.id)
         )
-        self.wait_until_loaded(skip_assistant=True)
+        self.wait_until_loaded()
         self.browser.snapshot('issue details empty exception')
 
     def test_empty_stacktrace(self):
@@ -149,7 +149,7 @@ class IssueDetailsTest(AcceptanceTestCase):
         self.browser.get(
             u'/{}/{}/issues/{}/'.format(self.org.slug, self.project.slug, event.group.id)
         )
-        self.wait_until_loaded(skip_assistant=True)
+        self.wait_until_loaded()
         self.browser.snapshot('issue details empty stacktrace')
 
     def test_invalid_interfaces(self):
@@ -160,7 +160,7 @@ class IssueDetailsTest(AcceptanceTestCase):
         self.browser.get(
             u'/{}/{}/issues/{}/'.format(self.org.slug, self.project.slug, event.group.id)
         )
-        self.wait_until_loaded(skip_assistant=True)
+        self.wait_until_loaded()
         self.browser.click('.errors-toggle')
         self.browser.wait_until('.entries > .errors ul')
         self.browser.snapshot('issue details invalid interfaces')
@@ -171,15 +171,14 @@ class IssueDetailsTest(AcceptanceTestCase):
         )
 
         self.browser.get(
-            u'/{}/{}/issues/{}/activity'.format(self.org.slug, self.project.slug, event.group.id)
+            u'/{}/{}/issues/{}/activity/'.format(
+                self.org.slug, self.project.slug, event.group.id)
         )
         self.browser.wait_until('.activity-item')
         self.browser.snapshot('issue activity python')
 
-    def wait_until_loaded(self, skip_assistant=None):
-        self.browser.wait_until('.entries')
+    def wait_until_loaded(self):
         self.browser.wait_until_not('.loading-indicator')
+        self.browser.wait_until('.entries')
         self.browser.wait_until('[data-test-id="linked-issues"]')
         self.browser.wait_until('[data-test-id="loaded-device-name"]')
-        if skip_assistant is None:
-            self.browser.wait_until('[data-test-id="assistant-cue"]', timeout=6)