Browse Source

feat(consecutive-http): Add other options to UI (#48473)

Adds more threshold fields as options for tweaking.
Nar Saynorath 1 year ago
parent
commit
e3dd8e889f
2 changed files with 26 additions and 0 deletions
  1. 4 0
      static/app/views/admin/adminSettings.tsx
  2. 22 0
      static/app/views/admin/options.tsx

+ 4 - 0
static/app/views/admin/adminSettings.tsx

@@ -49,6 +49,8 @@ const optionsAvailable = [
   'performance.issues.m_n_plus_one_db.ga-rollout',
   'performance.issues.consecutive_http.lcp_ratio_threshold',
   'performance.issues.consecutive_http.max_duration_between_spans',
+  'performance.issues.consecutive_http.consecutive_count_threshold',
+  'performance.issues.consecutive_http.span_duration_threshold',
   'profile.issues.blocked_main_thread-ingest.la-rollout',
   'profile.issues.blocked_main_thread-ingest.ea-rollout',
   'profile.issues.blocked_main_thread-ingest.ga-rollout',
@@ -193,6 +195,8 @@ export default class AdminSettings extends AsyncView<{}, State> {
               </PanelHeader>
               {fields['performance.issues.consecutive_http.lcp_ratio_threshold']}
               {fields['performance.issues.consecutive_http.max_duration_between_spans']}
+              {fields['performance.issues.consecutive_http.consecutive_count_threshold']}
+              {fields['performance.issues.consecutive_http.span_duration_threshold']}
             </Panel>
             <Panel>
               <PanelHeader>

+ 22 - 0
static/app/views/admin/options.tsx

@@ -392,6 +392,28 @@ const performanceOptionDefinitions: Field[] = [
     max: Number.MAX_SAFE_INTEGER,
     step: 1,
   },
+  {
+    key: 'performance.issues.consecutive_http.consecutive_count_threshold',
+    label: t('Consecutive Count Threshold'),
+    help: t('The minimum number of offending spans that must occur consecutively.'),
+    defaultValue: () => '3',
+    component: NumberField,
+    min: 1,
+    max: Number.MAX_SAFE_INTEGER,
+    step: 1,
+  },
+  {
+    key: 'performance.issues.consecutive_http.span_duration_threshold',
+    label: t('Span Duration Threshold'),
+    help: t(
+      'The duration, in ms, that a span must exceed for it to be considered an offending span.'
+    ),
+    defaultValue: () => '1000',
+    component: NumberField,
+    min: 0,
+    max: Number.MAX_SAFE_INTEGER,
+    step: 1,
+  },
   {
     key: 'profile.issues.blocked_main_thread-ingest.la-rollout',
     label: t('Limited Availability Detection Rate'),