Browse Source

fix(ddm): Enable `p90` in alerts (#61921)

Riccardo Busetti 1 year ago
parent
commit
e06063cdf1

+ 8 - 0
src/sentry/search/events/fields.py

@@ -1531,6 +1531,14 @@ FUNCTIONS = {
             default_result_type="duration",
             redundant_grouping=True,
         ),
+        DiscoverFunction(
+            "p90",
+            optional_args=[with_default("transaction.duration", NumericColumn("column"))],
+            aggregate=["quantile(0.90)", ArgValue("column"), None],
+            result_type_fn=reflective_result_type(),
+            default_result_type="duration",
+            redundant_grouping=True,
+        ),
         DiscoverFunction(
             "p95",
             optional_args=[with_default("transaction.duration", NumericColumn("column"))],

+ 7 - 1
tests/sentry/incidents/endpoints/test_organization_alert_rule_index.py

@@ -778,7 +778,13 @@ class AlertRuleCreateEndpointTest(AlertRuleIndexBase):
                 "organizations:use-metrics-layer-in-alerts",
             ]
         ):
-            for mri in ("apdex()", "failure_rate()"):
+            for mri in (
+                "count()",
+                "avg(transaction.duration)",
+                "apdex()",
+                "failure_rate()",
+                "p90(transaction.duration)",
+            ):
                 test_params = {
                     **self.alert_rule_dict,
                     "aggregate": mri,