Browse Source

ref: Update symbolicator snapshots in preparation for new SymCache (#30362)

The new SymCache does not save explicit function ends *in the middle* of the executable range, but only at *the end* of it.
This changes the fixture/snapshot in such a way that we have a known but truncated function entry in that range, so the test should work with both the old and new SymCache format.
Arpad Borsos 3 years ago
parent
commit
df453b5687

+ 3 - 1
tests/fixtures/native/unreal_crash.sym

@@ -3160,9 +3160,11 @@ FUNC 500c8 126 0 OAPIPELINE::GetOptimalMatrixMixFunction(OAPIPELINE::EAudioForma
 501e4 2 289 1582
 501e6 7 303 1582
 501ed 1 310 1582
+PUBLIC 501ee 0 <truncated> # Original file was truncated. The following record here fills the gap between 501ef-703390, as the new SymCache does not allow gaps in the middle of the file.
+PUBLIC 501ef 0 <truncated>
 PUBLIC 703390 0 AActor::IsPendingKillPending()
 PUBLIC 7036a0 0 AOnlineBeacon::IsRelevancyOwnerFor(AActor const *,AActor const *,AActor const *)
 PUBLIC 7036b0 0 FVoicePacketImpl::IsReliable()
 PUBLIC 7036c0 0 FOnlineVoiceImpl::IsRemotePlayerTalking(FUniqueNetId const &)
 PUBLIC 703700 0 FVoiceEngineImpl::IsRemotePlayerTalking(FUniqueNetId const &)
-FUNC 703800 1 0 <EOF>  # Original file was truncated. Added to prevent the last PUBLIC record covering the remainder of the file.
+FUNC 703800 1 0 <EOF> # Original file was truncated. Added to prevent the last PUBLIC record covering the remainder of the file.

+ 161 - 1
tests/symbolicator/snapshots/SymbolicatorUnrealIntegrationTest/test_unreal_crash_with_attachments.pysnap

@@ -1,5 +1,5 @@
 ---
-created: '2021-01-05T09:42:55.087777Z'
+created: '2021-12-02T13:53:08.216475Z'
 creator: sentry
 source: tests/symbolicator/test_unreal_full.py
 ---
@@ -167,6 +167,26 @@ threads:
   - id: 248
     stacktrace:
       frames:
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff7548229e5'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff754814ea9'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -181,6 +201,26 @@ threads:
         instruction_addr: '0x7ffe100fed3d'
         package: C:\Windows\System32\ntdll.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff754814ea9'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff754814ea9'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -1310,6 +1350,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff75482017a'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -1359,6 +1409,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff75482017a'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -1408,6 +1468,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff75482017a'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -1653,6 +1723,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff754b6efc5'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -2297,6 +2377,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff7549e3f3c'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -2346,6 +2436,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff7549e3f3c'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -2395,6 +2495,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff7549e3f3c'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -2444,6 +2554,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff7549e3f3c'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -2493,6 +2613,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff7549e3f3c'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -2542,6 +2672,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff7549e3f3c'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -2591,6 +2731,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff7549e3f3c'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing
@@ -2640,6 +2790,16 @@ threads:
         instruction_addr: '0x7ffe0fd53034'
         package: C:\Windows\System32\kernel32.dll
         trust: scan
+      - data:
+          orig_in_app: -1
+          symbolicator_status: symbolicated
+        function: truncated
+        in_app: false
+        instruction_addr: '0x7ff7549e3f3c'
+        package: \\Mac\Home\Desktop\WindowsNoEditor\YetAnother\Binaries\Win64\YetAnother.exe
+        raw_function: <truncated>
+        symbol: <truncated>
+        trust: scan
       - data:
           orig_in_app: -1
           symbolicator_status: missing

+ 2 - 0
tests/symbolicator/test_unreal_full.py

@@ -27,6 +27,8 @@ def get_unreal_crash_apple_file():
 class SymbolicatorUnrealIntegrationTest(RelayStoreHelper, TransactionTestCase):
     # For these tests to run, write `symbolicator.enabled: true` into your
     # `~/.sentry/config.yml` and run `sentry devservices up`
+    # Also running locally, it might be necessary to set the
+    # `system.internal-url-prefix` option instead of `system.url-prefix`.
 
     @pytest.fixture(autouse=True)
     def initialize(self, live_server):