Browse Source

fix(analytics): fix hook deps (#36568)

Jonas 2 years ago
parent
commit
ded886d5a1

+ 1 - 1
static/app/components/globalSdkUpdateAlert.tsx

@@ -44,7 +44,7 @@ function InnerGlobalSdkUpdateAlert(
   const handleReviewUpdatesClick = useCallback(() => {
     SidebarPanelStore.activatePanel(SidebarPanelKey.Broadcasts);
     trackAdvancedAnalyticsEvent('sdk_updates.clicked', {organization});
-  }, []);
+  }, [organization]);
 
   useEffect(() => {
     trackAdvancedAnalyticsEvent('sdk_updates.seen', {organization});

+ 2 - 2
static/app/views/onboarding/welcome.tsx

@@ -46,14 +46,14 @@ function InnerAction({title, subText, cta, src}: TextWrapperProps) {
   );
 }
 
+const source = 'targeted_onboarding';
 function TargetedOnboardingWelcome({organization, ...props}: StepProps) {
-  const source = 'targeted_onboarding';
   useEffect(() => {
     trackAdvancedAnalyticsEvent('growth.onboarding_start_onboarding', {
       organization,
       source,
     });
-  }, []);
+  }, [organization]);
 
   const onComplete = () => {
     trackAdvancedAnalyticsEvent('growth.onboarding_clicked_instrument_app', {

+ 1 - 1
static/app/views/organizationStats/teamInsights/health.tsx

@@ -47,7 +47,7 @@ function TeamStatsHealth({location, router}: Props) {
     trackAdvancedAnalyticsEvent('team_insights.viewed', {
       organization,
     });
-  }, []);
+  }, [organization]);
 
   const {period, start, end, utc} = dataDatetime(query);
 

+ 1 - 1
static/app/views/organizationStats/teamInsights/issues.tsx

@@ -48,7 +48,7 @@ function TeamStatsIssues({location, router}: Props) {
     trackAdvancedAnalyticsEvent('team_insights.viewed', {
       organization,
     });
-  }, []);
+  }, [organization]);
 
   const {period, start, end, utc} = dataDatetime(query);