Browse Source

ref: trim overly broad DeprecationWarning filters intended for escape sequences (#34242)

* ref: trim overly broad DeprecationWarning filters intended for escape sequences

* ref: fix a typo to trigger tests
asottile-sentry 2 years ago
parent
commit
dd3cbcfdb7
2 changed files with 1 additions and 10 deletions
  1. 0 9
      pyproject.toml
  2. 1 1
      tests/sentry/search/events/test_builder.py

+ 0 - 9
pyproject.toml

@@ -34,15 +34,6 @@ filterwarnings = [
 
     "ignore::django.utils.deprecation.RemovedInDjango30Warning",
 
-    # DeprecationWarnings from Python 3.6's sre_parse are just so painful,
-    # and I haven't found a way to ignore it specifically from a module.
-    # This one in particular is from the "cookies" packages as depended
-    # on by an outdated version of responses, and shows up all over tests.
-    # TODO(joshuarli): Upgrade responses, then revisit this.
-    #                  It'll probably show up in other dependencies.
-    "ignore::DeprecationWarning",
-    "error:Using or importing the ABCs from 'collections':DeprecationWarning",
-
     # At writing, the Google Bigtable Emulator relies on deprecated behavior
     # internally, this can be removed once a version containing this fix is
     # released: https://github.com/googleapis/python-bigtable/pull/246

+ 1 - 1
tests/sentry/search/events/test_builder.py

@@ -1983,7 +1983,7 @@ class TimeseriesMetricQueryBuilderTest(MetricBuilderBaseTest):
         )
 
     def test_run_query_with_hour_interval(self):
-        # See comment on resolve_time_column for explaination of this test
+        # See comment on resolve_time_column for explanation of this test
         self.start = datetime.datetime.now(timezone.utc).replace(
             hour=15, minute=30, second=0, microsecond=0
         )