Browse Source

ref(reflux): Remove SettingsBreadcrumbActions (#33394)

Evan Purkhiser 2 years ago
parent
commit
db08e30b6c

+ 0 - 5
static/app/actions/settingsBreadcrumbActions.tsx

@@ -1,5 +0,0 @@
-import {createActions} from 'reflux';
-
-const SettingsBreadcrumbActions = createActions(['mapTitle', 'trimMappings']);
-
-export default SettingsBreadcrumbActions;

+ 4 - 11
static/app/stores/settingsBreadcrumbStore.tsx

@@ -1,7 +1,6 @@
 import {PlainRoute} from 'react-router';
 import {createStore, StoreDefinition} from 'reflux';
 
-import SettingsBreadcrumbActions from 'sentry/actions/settingsBreadcrumbActions';
 import getRouteStringFromRoutes from 'sentry/utils/getRouteStringFromRoutes';
 import {makeSafeRefluxStore} from 'sentry/utils/makeSafeRefluxStore';
 
@@ -13,9 +12,9 @@ type UpdateData = {
 interface SettingsBreadcrumbStoreDefinition extends StoreDefinition {
   getPathMap(): Internals['pathMap'];
   init(): void;
-  onTrimMappings(routes: PlainRoute<any>[]): void;
-  onUpdateRouteMap(update: UpdateData): void;
   reset(): void;
+  trimMappings(routes: PlainRoute<any>[]): void;
+  updateRouteMap(update: UpdateData): void;
 }
 
 type Internals = {
@@ -28,12 +27,6 @@ const storeConfig: SettingsBreadcrumbStoreDefinition = {
 
   init() {
     this.reset();
-    this.unsubscribeListeners.push(
-      this.listenTo(SettingsBreadcrumbActions.mapTitle, this.onUpdateRouteMap)
-    );
-    this.unsubscribeListeners.push(
-      this.listenTo(SettingsBreadcrumbActions.trimMappings, this.onTrimMappings)
-    );
   },
 
   reset() {
@@ -44,12 +37,12 @@ const storeConfig: SettingsBreadcrumbStoreDefinition = {
     return this.pathMap;
   },
 
-  onUpdateRouteMap({routes, title}) {
+  updateRouteMap({routes, title}) {
     this.pathMap[getRouteStringFromRoutes(routes)] = title;
     this.trigger(this.pathMap);
   },
 
-  onTrimMappings(routes) {
+  trimMappings(routes) {
     const routePath = getRouteStringFromRoutes(routes);
     for (const fullPath in this.pathMap) {
       if (!routePath.startsWith(fullPath)) {

+ 2 - 2
static/app/views/settings/components/settingsBreadcrumb/breadcrumbTitle.tsx

@@ -1,7 +1,7 @@
 import {Component} from 'react';
 import {PlainRoute} from 'react-router';
 
-import SettingsBreadcrumbActions from 'sentry/actions/settingsBreadcrumbActions';
+import SettingsBreadcrumbStore from 'sentry/stores/settingsBreadcrumbStore';
 
 type Props = {
   routes: Array<PlainRoute>;
@@ -10,7 +10,7 @@ type Props = {
 
 class BreadcrumbTitle extends Component<Props> {
   componentDidMount() {
-    SettingsBreadcrumbActions.mapTitle(this.props);
+    SettingsBreadcrumbStore.updateRouteMap(this.props);
   }
 
   render() {

+ 1 - 2
static/app/views/settings/components/settingsBreadcrumb/index.tsx

@@ -1,7 +1,6 @@
 import {Component} from 'react';
 import styled from '@emotion/styled';
 
-import SettingsBreadcrumbActions from 'sentry/actions/settingsBreadcrumbActions';
 import Link from 'sentry/components/links/link';
 import SettingsBreadcrumbStore from 'sentry/stores/settingsBreadcrumbStore';
 import getRouteStringFromRoutes from 'sentry/utils/getRouteStringFromRoutes';
@@ -37,7 +36,7 @@ class SettingsBreadcrumb extends Component<Props> {
     if (this.props.routes === prevProps.routes) {
       return;
     }
-    SettingsBreadcrumbActions.trimMappings(this.props.routes);
+    SettingsBreadcrumbStore.trimMappings(this.props.routes);
   }
 
   render() {