Browse Source

fix(issues): Inbox reason details can be null (#49568)

Scott Cooper 1 year ago
parent
commit
da44f0608a

+ 13 - 0
static/app/components/group/inboxBadges/inboxReason.spec.tsx

@@ -52,4 +52,17 @@ describe('InboxReason', () => {
 
     expect(await screen.findByText('Affected 10 user(s)')).toBeInTheDocument();
   });
+
+  it('renders unignored with null reason details', () => {
+    render(
+      <InboxReason
+        inbox={{
+          ...inbox,
+          reason: GroupInboxReason.UNIGNORED,
+          reason_details: null,
+        }}
+      />
+    );
+    expect(screen.getByText('Unignored')).toBeInTheDocument();
+  });
 });

+ 1 - 1
static/app/components/group/inboxBadges/inboxReason.tsx

@@ -41,7 +41,7 @@ function InboxReason({inbox, fontSize = 'sm', showDateAdded}: Props) {
       window,
       user_count: userCount,
       user_window: userWindow,
-    } = reasonDetails;
+    } = reasonDetails ?? {};
     if (until) {
       // Was ignored until `until` has passed.
       // `until` format: "2021-01-20T03:59:03+00:00"

+ 1 - 1
static/app/types/group.tsx

@@ -202,9 +202,9 @@ export const enum GroupInboxReason {
 }
 
 export type InboxDetails = {
-  reason_details: InboxReasonDetails;
   date_added?: string;
   reason?: GroupInboxReason;
+  reason_details?: InboxReasonDetails | null;
 };
 
 export type SuggestedOwnerReason =