Browse Source

fix(workflow): Remove last step from for review onboarding (#24943)

Scott Cooper 3 years ago
parent
commit
d98485e423

+ 1 - 10
src/sentry/static/sentry/app/components/assistant/getGuidesContent.tsx

@@ -140,7 +140,7 @@ export default function getGuidesContent(orgSlug: string | null): GuidesContent
         {
           target: 'inbox_guide_review',
           description: t(
-            `Mark Reviewed removes the issue from this list and also removes the label.`
+            `Marking an issue reviewed, resolving it, or ignoring it removes it from this list and removes the label.`
           ),
           nextText: t(`When does this end?`),
           cantDismiss: true,
@@ -148,15 +148,6 @@ export default function getGuidesContent(orgSlug: string | null): GuidesContent
         {
           target: 'inbox_guide_ignore',
           description: t(`Resolving or ignoring an issue also marks it reviewed.`),
-          nextText: t(`Seriously, there's more?`),
-          cantDismiss: true,
-        },
-        {
-          target: 'for_review_guide_tab',
-          description: t(
-            `Everything is automatically reviewed after seven days, preventing
-            issues from piling up and you from losing your damn mind.`
-          ),
           nextText: t(`Make It Stop Already`),
         },
       ],

+ 5 - 7
src/sentry/static/sentry/app/components/eventOrGroupExtraDetails.tsx

@@ -60,13 +60,11 @@ function EventOrGroupExtraDetails({
 
   return (
     <GroupExtra hasInbox={hasInbox}>
-      {hasInbox &&
-        inbox &&
-        (hasGuideAnchor ? (
-          <GuideAnchor target="inbox_guide_reason">{inboxReason}</GuideAnchor>
-        ) : (
-          inboxReason
-        ))}
+      {hasInbox && inbox && (
+        <GuideAnchor target="inbox_guide_reason" disabled={!hasGuideAnchor}>
+          {inboxReason}
+        </GuideAnchor>
+      )}
       {shortId &&
         (hasInbox ? (
           <InboxShortId