Browse Source

stop sending message-only events

Katie Byers 3 days ago
parent
commit
d62eb51773
1 changed files with 5 additions and 7 deletions
  1. 5 7
      src/sentry/seer/similarity/utils.py

+ 5 - 7
src/sentry/seer/similarity/utils.py

@@ -1,7 +1,6 @@
 import logging
 from typing import Any
 
-from sentry.constants import PLACEHOLDER_EVENT_TITLES
 from sentry.eventstore.models import Event
 from sentry.utils.safe import get_path
 
@@ -84,12 +83,11 @@ def event_content_is_seer_eligible(event: Event) -> bool:
     """
     # TODO: Determine if we want to filter out non-sourcemapped events
 
-    # If an event has no stacktrace, and only one of our placeholder titles ("<untitled>",
-    # "<unknown>", etc.), there's no data for Seer to analyze, so no point in making the API call.
-    if (
-        event.title in PLACEHOLDER_EVENT_TITLES
-        and not get_path(event.data, "exception", "values", -1, "stacktrace", "frames")
-        and not get_path(event.data, "threads", "values", -1, "stacktrace", "frames")
+    # If an event has no stacktrace, there's no data for Seer to analyze, so no point in making the
+    # API call. If we ever start analyzing message-only events, we'll need to add `event.title in
+    # PLACEHOLDER_EVENT_TITLES` to this check.
+    if not get_path(event.data, "exception", "values", -1, "stacktrace", "frames") and not get_path(
+        event.data, "threads", "values", -1, "stacktrace", "frames"
     ):
         return False