Browse Source

fix(perf-issues) remove source span from span evidence (#39151)

Source span was decided to be potentially confusing and inaccurate, we
are removing it for now

<img width="911" alt="image"
src="https://user-images.githubusercontent.com/44422760/191785272-b905c875-ac45-4cc2-97a3-feea15e6f20a.png">
Dominik Buszowiecki 2 years ago
parent
commit
d2e9d21a8b
1 changed files with 2 additions and 12 deletions
  1. 2 12
      static/app/components/events/interfaces/performance/spanEvidence.tsx

+ 2 - 12
static/app/components/events/interfaces/performance/spanEvidence.tsx

@@ -41,7 +41,6 @@ export function SpanEvidenceSection({event, organization}: Props) {
   const spansById = keyBy(spans, 'span_id');
 
   const parentSpan = spansById[event.perfProblem.parentSpanIds[0]];
-  const sourceSpan = spansById[event.perfProblem.causeSpanIds[0]];
   const repeatingSpan = spansById[event.perfProblem.offenderSpanIds[0]];
 
   const data: KeyValueListData = [
@@ -57,27 +56,18 @@ export function SpanEvidenceSection({event, organization}: Props) {
     },
     {
       key: '2',
-      subject: t('Source Span'),
-      value: getSpanEvidenceValue(sourceSpan),
-    },
-    {
-      key: '3',
       subject: t('Repeating Span'),
       value: getSpanEvidenceValue(repeatingSpan),
     },
   ];
 
-  const affectedSpanIds = [
-    parentSpan.span_id,
-    sourceSpan.span_id,
-    ...event.perfProblem.offenderSpanIds,
-  ];
+  const affectedSpanIds = [parentSpan.span_id, ...event.perfProblem.offenderSpanIds];
 
   return (
     <DataSection
       title={t('Span Evidence')}
       description={t(
-        'Span Evidence identifies the parent span where the N+1 occurs, the source span that occurs immediately before the repeating spans, and the repeating span itself.'
+        'Span Evidence identifies the parent span where the N+1 occurs, and the repeating spans.'
       )}
     >
       <KeyValueList data={data} />