ref(sourcemaps): Add migration to backfill None date_uploaded fields (#46176)

migrations_lockfile.txt

@@ -6,5 +6,5 @@ To resolve this, rebase against latest master and regenerate your migration. Thi
 will then be regenerated, and you should be able to merge without conflicts.
 
 nodestore: 0002_nodestore_no_dictfield
-sentry: 0393_create_groupforecast_table
+sentry: 0394_set_none_date_uploaded_to_date_added
 social_auth: 0001_initial

src/sentry/migrations/0394_set_none_date_uploaded_to_date_added.py

@@ -0,0 +1,60 @@
+# Generated by Django 2.2.28 on 2023-03-22 07:55
+
+import django.utils.timezone
+from django.db import migrations, models
+
+from sentry.new_migrations.migrations import CheckedMigration
+from sentry.utils.query import RangeQuerySetWrapperWithProgressBar
+
+
+def copy_date_added_to_date_uploaded(apps, schema_editor):
+    ArtifactBundle = apps.get_model("sentry", "ArtifactBundle")
+
+    for bundle in RangeQuerySetWrapperWithProgressBar(
+        ArtifactBundle.objects.filter(date_uploaded__isnull=True)
+    ):
+        bundle.date_uploaded = bundle.date_added
+        bundle.save(update_fields=["date_uploaded"])
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production. For
+    # the most part, this should only be used for operations where it's safe to run the migration
+    # after your code has deployed. So this should not be used for most operations that alter the
+    # schema of a table.
+    # Here are some things that make sense to mark as dangerous:
+    # - Large data migrations. Typically we want these to be run manually by ops so that they can
+    #   be monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   have ops run this and not block the deploy. Note that while adding an index is a schema
+    #   change, it's completely safe to run the operation after the code has deployed.
+    is_dangerous = False
+    checked = False
+
+    dependencies = [
+        ("sentry", "0393_create_groupforecast_table"),
+    ]
+
+    operations = [
+        migrations.SeparateDatabaseAndState(
+            database_operations=[
+                migrations.RunPython(
+                    copy_date_added_to_date_uploaded,
+                    migrations.RunPython.noop,
+                    hints={"tables": ["sentry_artifactbundle"]},
+                ),
+                migrations.AlterField(
+                    model_name="artifactbundle",
+                    name="date_uploaded",
+                    field=models.DateTimeField(),
+                ),
+            ],
+            state_operations=[
+                migrations.AlterField(
+                    model_name="artifactbundle",
+                    name="date_uploaded",
+                    field=models.DateTimeField(default=django.utils.timezone.now),
+                ),
+            ],
+        ),
+    ]

src/sentry/models/artifactbundle.py

@@ -53,7 +53,7 @@ class ArtifactBundle(Model):
     artifact_count = BoundedPositiveIntegerField()
     date_added = models.DateTimeField(default=timezone.now)
     # This field represents the date of the upload that we show in the UI.
-    date_uploaded = models.DateTimeField(default=timezone.now, null=True)
+    date_uploaded = models.DateTimeField(default=timezone.now)
 
     class Meta:
         app_label = "sentry"

tests/sentry/migrations/test_0394_set_none_date_uploaded_to_date_added.py

@@ -0,0 +1,35 @@
+from uuid import uuid4
+
+from django.utils import timezone
+
+from sentry.models import ArtifactBundle, File
+from sentry.testutils.cases import TestMigrations
+
+DEFAULT_ENVIRONMENT_NAME = "production"
+
+
+class SetNoneDateUploadedToDateAddedTest(TestMigrations):
+    migrate_from = "0393_create_groupforecast_table"
+    migrate_to = "0394_set_none_date_uploaded_to_date_added"
+
+    def setup_before_migration(self, apps):
+        time_1 = timezone.now()
+
+        self.artifact_bundles = []
+        for with_date_uploaded in (False, True):
+            for i in range(0, 5):
+                file = File.objects.create(name="file", type="application/json")
+                artifact_bundle = ArtifactBundle.objects.create(
+                    organization_id=self.organization.id,
+                    bundle_id=uuid4(),
+                    file=file,
+                    artifact_count=i,
+                    date_added=time_1,
+                    date_uploaded=time_1 if with_date_uploaded else None,
+                )
+                self.artifact_bundles.append(artifact_bundle)
+
+    def test(self):
+        for artifact_bundle in self.artifact_bundles:
+            artifact_bundle.refresh_from_db()
+            assert artifact_bundle.date_added == artifact_bundle.date_uploaded