Browse Source

feat(workflow): Remove date created from alert list (#35416)

Scott Cooper 2 years ago
parent
commit
d11b752927

+ 1 - 22
static/app/views/alerts/list/rules/index.tsx

@@ -211,27 +211,6 @@ class AlertRulesList extends AsyncComponent<Props, State & AsyncComponent['state
 
                   t('Project'),
                   t('Team'),
-                  <StyledSortLink
-                    key="dateAdded"
-                    role="columnheader"
-                    aria-sort={
-                      sort.field !== 'date_added'
-                        ? 'none'
-                        : sort.asc
-                        ? 'ascending'
-                        : 'descending'
-                    }
-                    to={{
-                      pathname: location.pathname,
-                      query: {
-                        ...currentQuery,
-                        asc: sort.field === 'date_added' && !sort.asc ? '1' : undefined,
-                        sort: 'date_added',
-                      },
-                    }}
-                  >
-                    {t('Created')} {sort.field === 'date_added' && sortArrow}
-                  </StyledSortLink>,
                   t('Actions'),
                 ]}
                 isLoading={loading || !loadedTeams}
@@ -354,7 +333,7 @@ const StyledPanelTable = styled(PanelTable)`
     overflow: initial;
   }
 
-  grid-template-columns: 4fr auto 140px 60px 110px auto;
+  grid-template-columns: 4fr auto 140px 60px auto;
   white-space: nowrap;
   font-size: ${p => p.theme.fontSizeMedium};
 `;

+ 0 - 17
static/app/views/alerts/list/rules/row.tsx

@@ -7,7 +7,6 @@ import AlertBadge from 'sentry/components/alertBadge';
 import ActorAvatar from 'sentry/components/avatar/actorAvatar';
 import TeamAvatar from 'sentry/components/avatar/teamAvatar';
 import {openConfirmModal} from 'sentry/components/confirm';
-import DateTime from 'sentry/components/dateTime';
 import DropdownAutoComplete from 'sentry/components/dropdownAutoComplete';
 import DropdownBubble from 'sentry/components/dropdownBubble';
 import DropdownMenuControlV2 from 'sentry/components/dropdownMenuControlV2';
@@ -25,7 +24,6 @@ import {t, tct} from 'sentry/locale';
 import overflowEllipsis from 'sentry/styles/overflowEllipsis';
 import space from 'sentry/styles/space';
 import {Actor, Project} from 'sentry/types';
-import getDynamicText from 'sentry/utils/getDynamicText';
 import type {Color} from 'sentry/utils/theme';
 import {
   AlertRuleThresholdType,
@@ -384,16 +382,6 @@ function RuleListRow({
           </AssigneeWrapper>
         )}
       </FlexCenter>
-
-      <FlexCenter>
-        <StyledDateTime
-          date={getDynamicText({
-            value: rule.dateCreated,
-            fixed: new Date('2021-04-20'),
-          })}
-          format="ll"
-        />
-      </FlexCenter>
       <ActionsRow>
         <Access access={['alerts:write']}>
           {({hasAccess}) => (
@@ -463,11 +451,6 @@ const ProjectBadge = styled(IdBadge)`
   flex-shrink: 0;
 `;
 
-const StyledDateTime = styled(DateTime)`
-  font-variant-numeric: tabular-nums;
-  color: ${p => p.theme.gray300};
-`;
-
 const TriggerText = styled('div')`
   margin-left: ${space(1)};
   white-space: nowrap;

+ 0 - 28
tests/js/spec/views/alerts/rules/index.spec.jsx

@@ -195,34 +195,6 @@ describe('AlertRulesList', () => {
     });
   });
 
-  it('sorts by date created', async () => {
-    const {rerender} = createWrapper();
-
-    // The created column is not used for sorting
-    expect(await screen.findByText('Created')).toHaveAttribute('aria-sort', 'none');
-
-    // Sort by created (date_added)
-    rerender(
-      getComponent({
-        location: {
-          query: {asc: '1', sort: 'date_added'},
-          search: '?asc=1&sort=date_added`',
-        },
-      })
-    );
-
-    expect(await screen.findByText('Created')).toHaveAttribute('aria-sort', 'ascending');
-
-    expect(rulesMock).toHaveBeenCalledTimes(2);
-
-    expect(rulesMock).toHaveBeenCalledWith(
-      '/organizations/org-slug/combined-rules/',
-      expect.objectContaining({
-        query: expect.objectContaining({asc: '1'}),
-      })
-    );
-  });
-
   it('sorts by name', async () => {
     const {rerender} = createWrapper();