Browse Source

ref: Move lastOfArray so it can be found and reused more often (#71832)

Related to "Audit/move functions out of global utils.tsx"
https://github.com/getsentry/frontend-tsc/issues/13
Ryan Albrecht 9 months ago
parent
commit
d06cdb49f1

+ 0 - 6
static/app/utils.tsx

@@ -75,12 +75,6 @@ export function intcomma(x: number): string {
   return x.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ',');
   return x.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ',');
 }
 }
 
 
-export function lastOfArray<T extends Array<unknown> | ReadonlyArray<unknown>>(
-  t: T
-): T[number] {
-  return t[t.length - 1];
-}
-
 export function sortArray<T>(arr: Array<T>, score_fn: (entry: T) => string): Array<T> {
 export function sortArray<T>(arr: Array<T>, score_fn: (entry: T) => string): Array<T> {
   arr.sort((a, b) => {
   arr.sort((a, b) => {
     const a_score = score_fn(a),
     const a_score = score_fn(a),

+ 5 - 0
static/app/utils/array/lastOfArray.tsx

@@ -0,0 +1,5 @@
+export function lastOfArray<T extends Array<unknown> | ReadonlyArray<unknown>>(
+  t: T
+): T[number] {
+  return t[t.length - 1];
+}

+ 1 - 1
static/app/utils/profiling/profile/eventedProfile.tsx

@@ -1,4 +1,4 @@
-import {lastOfArray} from 'sentry/utils';
+import {lastOfArray} from 'sentry/utils/array/lastOfArray';
 import {CallTreeNode} from 'sentry/utils/profiling/callTreeNode';
 import {CallTreeNode} from 'sentry/utils/profiling/callTreeNode';
 import type {Frame} from 'sentry/utils/profiling/frame';
 import type {Frame} from 'sentry/utils/profiling/frame';
 import {formatTo} from 'sentry/utils/profiling/units/units';
 import {formatTo} from 'sentry/utils/profiling/units/units';

+ 1 - 1
static/app/utils/profiling/profile/jsSelfProfile.tsx

@@ -1,4 +1,4 @@
-import {lastOfArray} from 'sentry/utils';
+import {lastOfArray} from 'sentry/utils/array/lastOfArray';
 import {CallTreeNode} from 'sentry/utils/profiling/callTreeNode';
 import {CallTreeNode} from 'sentry/utils/profiling/callTreeNode';
 import {Frame} from 'sentry/utils/profiling/frame';
 import {Frame} from 'sentry/utils/profiling/frame';
 
 

+ 2 - 1
static/app/utils/profiling/profile/sentrySampledProfile.tsx

@@ -1,6 +1,7 @@
 import moment from 'moment';
 import moment from 'moment';
 
 
-import {defined, lastOfArray} from 'sentry/utils';
+import {defined} from 'sentry/utils';
+import {lastOfArray} from 'sentry/utils/array/lastOfArray';
 import {CallTreeNode} from 'sentry/utils/profiling/callTreeNode';
 import {CallTreeNode} from 'sentry/utils/profiling/callTreeNode';
 
 
 import type {Frame} from './../frame';
 import type {Frame} from './../frame';