Browse Source

build(gha): more granular devservices, default to no snuba (#21447)

josh 4 years ago
parent
commit
d04055f222

+ 5 - 2
.github/actions/setup-sentry/action.yml

@@ -8,7 +8,7 @@ inputs:
   snuba:
     description: 'Is snuba required?'
     required: false
-    default: 'true'
+    default: 'false'
   kafka:
     description: 'Is kafka required?'
     required: false
@@ -110,6 +110,9 @@ runs:
       run: |
         sentry init
 
+        # redis, postgres are needed for almost every code path.
+        sentry devservices up redis postgres
+
         # TODO: Use devservices kafka. See https://github.com/getsentry/sentry/pull/20986#issuecomment-704510570
         if [ "$NEED_KAFKA" = "true" ]; then
           docker run \
@@ -131,7 +134,7 @@ runs:
         fi
 
         if [ "$NEED_SNUBA" = "true" ]; then
-          sentry devservices up postgres redis clickhouse snuba
+          sentry devservices up clickhouse snuba
         fi
 
         docker ps -a

+ 2 - 0
.github/workflows/acceptance.yml

@@ -93,6 +93,7 @@ jobs:
         id: setup
         with:
           python: 2
+          snuba: true
 
       - uses: actions/cache@v2
         id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
@@ -171,6 +172,7 @@ jobs:
         id: setup
         with:
           python: 3
+          snuba: true
 
       - name: yarn cache
         uses: actions/cache@v2

+ 1 - 0
.github/workflows/apidocstest.yml

@@ -58,6 +58,7 @@ jobs:
         id: setup
         with:
           python: 3
+          snuba: true
 
       - name: yarn cache
         uses: actions/cache@v2

+ 1 - 0
.github/workflows/backend-test-py3.6.yml

@@ -67,6 +67,7 @@ jobs:
         id: setup
         with:
           python: 3
+          snuba: true
 
       - name: Run backend test [py3.6] (${{ steps.setup.outputs.matrix-instance-number }} of ${{ strategy.job-total }})
         if: steps.changes.outputs.backend == 'true'

+ 1 - 0
.github/workflows/snuba-integration-test-py3.6.yml

@@ -69,6 +69,7 @@ jobs:
         id: setup
         with:
           python: 3
+          snuba: true
           kafka: true
 
       - name: Run snuba test [py3.6] (${{ steps.setup.outputs.matrix-instance-number }} of ${{ strategy.job-total }})