Browse Source

fix(dashboard): Use modified dashboard state when available (#30932)

Use modified dashboard state when adding widgets.
If dashboard prop is used then only the latest
widget changes are reflected in edit mode.
Shruthi 3 years ago
parent
commit
cebd82dd7f
1 changed files with 4 additions and 1 deletions
  1. 4 1
      static/app/views/dashboardsV2/detail.tsx

+ 4 - 1
static/app/views/dashboardsV2/detail.tsx

@@ -302,11 +302,14 @@ class DashboardDetail extends Component<Props, State> {
   };
   };
 
 
   handleAddCustomWidget = (widget: Widget) => {
   handleAddCustomWidget = (widget: Widget) => {
+    const {dashboard} = this.props;
+    const {modifiedDashboard} = this.state;
+    const newModifiedDashboard = modifiedDashboard || dashboard;
     let newWidget = widget;
     let newWidget = widget;
     if (this.props.organization.features.includes('dashboard-grid-layout')) {
     if (this.props.organization.features.includes('dashboard-grid-layout')) {
       newWidget = assignTempId(widget);
       newWidget = assignTempId(widget);
     }
     }
-    this.onUpdateWidget([...this.props.dashboard.widgets, newWidget]);
+    this.onUpdateWidget([...newModifiedDashboard.widgets, newWidget]);
   };
   };
 
 
   onAddWidget = () => {
   onAddWidget = () => {