Просмотр исходного кода

ref(rule): Set owner to null if deleted (#47261)

If a rule's owner is deleted, currently we'd also cascade delete the
rule - this will set the owner value to null instead.
Colleen O'Rourke 1 год назад
Родитель
Сommit
ceba28bf6d

+ 1 - 1
migrations_lockfile.txt

@@ -6,5 +6,5 @@ To resolve this, rebase against latest master and regenerate your migration. Thi
 will then be regenerated, and you should be able to merge without conflicts.
 
 nodestore: 0002_nodestore_no_dictfield
-sentry: 0420_backfill_groupedmessage_ignored_substatus
+sentry: 0421_rule_set_null_owner_deleted
 social_auth: 0001_initial

+ 35 - 0
src/sentry/migrations/0421_rule_set_null_owner_deleted.py

@@ -0,0 +1,35 @@
+# Generated by Django 2.2.28 on 2023-04-12 18:09
+
+import django.db.models.deletion
+from django.db import migrations
+
+import sentry.db.models.fields.foreignkey
+from sentry.new_migrations.migrations import CheckedMigration
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production. For
+    # the most part, this should only be used for operations where it's safe to run the migration
+    # after your code has deployed. So this should not be used for most operations that alter the
+    # schema of a table.
+    # Here are some things that make sense to mark as dangerous:
+    # - Large data migrations. Typically we want these to be run manually by ops so that they can
+    #   be monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   have ops run this and not block the deploy. Note that while adding an index is a schema
+    #   change, it's completely safe to run the operation after the code has deployed.
+    is_dangerous = False
+
+    dependencies = [
+        ("sentry", "0420_backfill_groupedmessage_ignored_substatus"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="rule",
+            name="owner",
+            field=sentry.db.models.fields.foreignkey.FlexibleForeignKey(
+                null=True, on_delete=django.db.models.deletion.SET_NULL, to="sentry.Actor"
+            ),
+        ),
+    ]

+ 1 - 1
src/sentry/models/rule.py

@@ -41,7 +41,7 @@ class Rule(Model):
         choices=((RuleStatus.ACTIVE, "Active"), (RuleStatus.INACTIVE, "Inactive")),
         db_index=True,
     )
-    owner = FlexibleForeignKey("sentry.Actor", null=True)
+    owner = FlexibleForeignKey("sentry.Actor", null=True, on_delete=models.SET_NULL)
 
     date_added = models.DateTimeField(default=timezone.now)