Просмотр исходного кода

feat(profiling): add p95 support to profiling hovercard (#43569)

### Summary
Sorts and displays the profiling hovercard suspect functions by `-p95`
by default.

~~Blocked by: https://github.com/getsentry/vroom/pull/116~~
Elias Hussary 2 лет назад
Родитель
Сommit
ca8a04db96

+ 3 - 3
static/app/components/profiling/functionsMiniGrid.tsx

@@ -37,12 +37,12 @@ export function FunctionsMiniGrid(props: FunctionsMiniGridProps) {
   return (
     <FunctionsMiniGridContainer>
       <FunctionsMiniGridHeader>{t('Slowest app functions')}</FunctionsMiniGridHeader>
-      <FunctionsMiniGridHeader align="right">{t('P99')}</FunctionsMiniGridHeader>
+      <FunctionsMiniGridHeader align="right">{t('P95')}</FunctionsMiniGridHeader>
       <FunctionsMiniGridHeader align="right">{t('Count')}</FunctionsMiniGridHeader>
 
       {functions &&
         functions.map((f, idx) => {
-          const [exampleProfileIdRaw] = f.examples;
+          const exampleProfileIdRaw = f.worst;
           const exampleProfileId = exampleProfileIdRaw.replaceAll('-', '');
           return (
             <Fragment key={idx}>
@@ -57,7 +57,7 @@ export function FunctionsMiniGrid(props: FunctionsMiniGridProps) {
                 </FunctionNameTextTruncate>
               </FunctionsMiniGridCell>
               <FunctionsMiniGridCell align="right">
-                <PerformanceDuration nanoseconds={f.p99} abbreviation />
+                <PerformanceDuration nanoseconds={f.p95} abbreviation />
               </FunctionsMiniGridCell>
               <FunctionsMiniGridCell align="right">
                 <NumberContainer>{f.count}</NumberContainer>

+ 1 - 1
static/app/components/profiling/functionsTable.tsx

@@ -196,7 +196,7 @@ const COLUMN_ORDER: TableColumnKey[] = [
   'examples',
 ];
 
-const COLUMNS: Record<TableColumnKey, TableColumn> = {
+const COLUMNS: Record<Exclude<TableColumnKey, 'p95'>, TableColumn> = {
   name: {
     key: 'name',
     name: t('Name'),

+ 1 - 0
static/app/types/profiling/core.tsx

@@ -48,6 +48,7 @@ export type SuspectFunction = {
   fingerprint: number;
   name: string;
   p75: number;
+  p95: number;
   p99: number;
   package: string;
   path: string;

+ 1 - 1
static/app/utils/profiling/hooks/useProfilingTransactionQuickSummary.tsx

@@ -63,7 +63,7 @@ export function useProfilingTransactionQuickSummary(
     query: '',
     selection,
     transaction,
-    sort: '-p99',
+    sort: '-p95',
     functionType: 'application',
     enabled: !skipFunctions,
   });