Browse Source

ref(py3): Fix two more list casting issues (#20450)

Evan Purkhiser 4 years ago
parent
commit
c9d3798378

+ 2 - 2
src/sentry/integrations/jira_server/integration.py

@@ -318,8 +318,8 @@ class JiraServerIntegrationProvider(IntegrationProvider):
                 extra={"error": six.text_type(err), "external_id": external_id},
             )
             try:
-                details = err.json["messages"][0].values().pop()
-            except Exception:
+                details = next(x for x in err.json["messages"][0].values())
+            except (KeyError, TypeError, StopIteration):
                 details = ""
             message = u"Could not create issue webhook in Jira. {}".format(details)
             raise IntegrationError(message)

+ 1 - 1
tests/sentry/api/endpoints/test_organization_plugins_configs.py

@@ -101,7 +101,7 @@ class OrganizationPluginsTest(APITestCase):
         self.projectA.status = 1
         self.projectA.save()
         response = self.client.get(self.url)
-        assert filter(lambda x: x["slug"] == "trello", response.data)[0]["projectList"] == []
+        assert list(filter(lambda x: x["slug"] == "trello", response.data))[0]["projectList"] == []
 
     def test_configured_multiple_projects(self):
         plugins.get("trello").set_option("key", "some_value", self.projectA)