mypy: type more replays files (#54483)

type a few more replays files

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Co-authored-by: anthony sottile <103459774+asottile-sentry@users.noreply.github.com>

pyproject.toml

@@ -650,8 +650,6 @@ module = [
     "sentry.release_health.sessions",
     "sentry.release_health.tasks",
     "sentry.replays.endpoints.project_replay_clicks_index",
-    "sentry.replays.endpoints.project_replay_recording_segment_details",
-    "sentry.replays.endpoints.project_replay_recording_segment_index",
     "sentry.replays.lib.query",
     "sentry.replays.query",
     "sentry.reprocessing2",

src/sentry/replays/endpoints/project_replay_recording_segment_details.py

@@ -1,9 +1,11 @@
+from __future__ import annotations
+
 from io import BytesIO
 
 import sentry_sdk
 from django.http import StreamingHttpResponse
+from django.http.response import HttpResponseBase
 from rest_framework.request import Request
-from rest_framework.response import Response
 
 from sentry import features
 from sentry.api.base import region_silo_endpoint
@@ -14,7 +16,7 @@ from sentry.replays.usecases.reader import download_segment, fetch_segment_metad
 
 @region_silo_endpoint
 class ProjectReplayRecordingSegmentDetailsEndpoint(ProjectEndpoint):
-    def get(self, request: Request, project, replay_id, segment_id) -> Response:
+    def get(self, request: Request, project, replay_id, segment_id) -> HttpResponseBase:
         if not features.has(
             "organizations:session-replay", project.organization, actor=request.user
         ):
@@ -33,7 +35,9 @@ class ProjectReplayRecordingSegmentDetailsEndpoint(ProjectEndpoint):
                         "replayId": segment.replay_id,
                         "segmentId": segment.segment_id,
                         "projectId": str(segment.project_id),
-                        "dateAdded": segment.date_added.replace(microsecond=0).isoformat(),
+                        "dateAdded": segment.date_added.replace(microsecond=0).isoformat()
+                        if segment.date_added
+                        else None,
                     }
                 }
             )
@@ -46,6 +50,9 @@ class ProjectReplayRecordingSegmentDetailsEndpoint(ProjectEndpoint):
         segment_bytes = download_segment(
             segment, transaction=transaction, current_hub=sentry_sdk.Hub.current
         )
+        if segment_bytes is None:
+            segment_bytes = b"[]"
+
         segment_reader = BytesIO(segment_bytes)
 
         response = StreamingHttpResponse(

src/sentry/replays/endpoints/project_replay_recording_segment_index.py

@@ -8,7 +8,8 @@ from sentry import features
 from sentry.api.base import region_silo_endpoint
 from sentry.api.bases.project import ProjectEndpoint
 from sentry.api.paginator import GenericOffsetPaginator
-from sentry.replays.usecases.reader import download_segments, fetch_segments_metadata, storage
+from sentry.replays.lib.storage import storage
+from sentry.replays.usecases.reader import download_segments, fetch_segments_metadata
 
 
 @region_silo_endpoint