Browse Source

ref(analytics): convert another discover analytics (#47177)

Stephen Cefali 1 year ago
parent
commit
c8c906fe5f

+ 6 - 0
static/app/utils/analytics/discoverAnalyticsEvents.tsx

@@ -25,6 +25,11 @@ export type SaveQueryEventParameters = {
 };
 
 export type DiscoverEventParameters = SaveQueryEventParameters & {
+  'discover_search.failed': {
+    error: string;
+    search_source: string;
+    search_type: string;
+  };
   'discover_v2.add_equation': {};
   'discover_v2.build_new_query': {};
   'discover_v2.change_sort': {sort: string};
@@ -117,4 +122,5 @@ export const discoverEventMap: Record<DiscoverEventKey, string | null> = {
   'discover_v2.results.cellaction': 'Discoverv2: Cell Action Clicked',
   'discover_v2.results.drilldown': 'Discoverv2: Click aggregate drilldown',
   'discover_v2.update_columns': 'Discoverv2: Update columns',
+  'discover_search.failed': 'Discover Search: Failed',
 };

+ 4 - 7
static/app/views/discover/table/index.tsx

@@ -7,7 +7,8 @@ import {Client} from 'sentry/api';
 import Pagination, {CursorHandler} from 'sentry/components/pagination';
 import {t} from 'sentry/locale';
 import {Organization} from 'sentry/types';
-import {metric, trackAnalyticsEvent} from 'sentry/utils/analytics';
+import {metric} from 'sentry/utils/analytics';
+import trackAdvancedAnalyticsEvent from 'sentry/utils/analytics/trackAdvancedAnalyticsEvent';
 import {CustomMeasurementsContext} from 'sentry/utils/customMeasurements/customMeasurementsContext';
 import {TableData} from 'sentry/utils/discover/discoverQuery';
 import EventView, {
@@ -186,16 +187,12 @@ class Table extends PureComponent<TableProps, TableState> {
           pageLinks: null,
           tableData: null,
         });
-
-        trackAnalyticsEvent({
-          eventKey: 'discover_search.failed',
-          eventName: 'Discover Search: Failed',
-          organization_id: this.props.organization.id,
+        trackAdvancedAnalyticsEvent('discover_search.failed', {
+          organization: this.props.organization,
           search_type: 'events',
           search_source: 'discover_search',
           error: message,
         });
-
         setError(message, err.status);
       });
   };