Browse Source

fix(widget-builder): Use field form for orderby in templates/library (#34390)

Nar Saynorath 2 years ago
parent
commit
c6aee27cc2

+ 20 - 20
static/app/views/dashboardsV2/data.tsx

@@ -203,7 +203,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['transaction'],
             conditions: '!event.type:error',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -227,7 +227,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['browser.name'],
             conditions: '!event.type:transaction has:browser.name',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -299,7 +299,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['transaction'],
             conditions: '!event.type:error',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -347,7 +347,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['user_misery(300)'],
             columns: ['transaction'],
             conditions: '',
-            orderby: '-user_misery_300',
+            orderby: '-user_misery(300)',
           },
         ],
       },
@@ -371,7 +371,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['browser.name'],
             conditions: 'event.type:error has:browser.name',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -404,7 +404,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count_unique(user)'],
             columns: ['issue'],
             conditions: '',
-            orderby: '-count_unique_user',
+            orderby: '-count_unique(user)',
           },
         ],
       },
@@ -484,7 +484,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count_unique(user)'],
             columns: ['issue', 'title'],
             conditions: '',
-            orderby: '-count_unique_user',
+            orderby: '-count_unique(user)',
           },
         ],
       },
@@ -508,7 +508,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count_unique(user)'],
             columns: ['http.url', 'issue'],
             conditions: 'event.type:error',
-            orderby: '-count_unique_user',
+            orderby: '-count_unique(user)',
           },
         ],
       },
@@ -532,7 +532,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['transaction'],
             conditions: 'transaction.status:not_found',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -626,7 +626,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['transaction'],
             conditions: 'transaction.op:pageload p75(measurements.lcp):>4s',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -674,7 +674,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['transaction'],
             conditions: 'transaction.duration:>2s',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -779,7 +779,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count_unique(user)'],
             columns: ['issue'],
             conditions: '',
-            orderby: '-count_unique_user',
+            orderby: '-count_unique(user)',
           },
         ],
       },
@@ -803,7 +803,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['transaction'],
             conditions: 'transaction.status:internal_error',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -860,7 +860,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count_unique(user)'],
             columns: ['issue', 'title'],
             conditions: '',
-            orderby: '-count_unique_user',
+            orderby: '-count_unique(user)',
           },
         ],
       },
@@ -884,7 +884,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['transaction'],
             conditions: 'transaction.status:internal_error',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -988,7 +988,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['transaction'],
             conditions: 'apdex():<0.5 transaction.op:*task*',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -1013,7 +1013,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             columns: ['http.method', 'http.status_code', 'transaction'],
             conditions:
               'apdex():<0.5 transaction.op:*http* has:http.method has:http.status_code',
-            orderby: '-epm',
+            orderby: '-epm()',
           },
         ],
       },
@@ -1238,7 +1238,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()', 'count_unique(user)'],
             columns: ['issue'],
             conditions: 'error.handled:false',
-            orderby: '-count_unique_user',
+            orderby: '-count_unique(user)',
           },
         ],
       },
@@ -1286,7 +1286,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['count()'],
             columns: ['os'],
             conditions: 'has:os error.handled:false',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
       },
@@ -1478,7 +1478,7 @@ export const DASHBOARDS_TEMPLATES: DashboardTemplate[] = [
             aggregates: ['p75(measurements.frames_frozen_rate)'],
             columns: ['transaction'],
             conditions: 'has:measurements.frames_frozen_rate',
-            orderby: '-p75_measurements_frames_frozen_rate',
+            orderby: '-p75(measurements.frames_frozen_rate)',
           },
         ],
       },

+ 2 - 2
static/app/views/dashboardsV2/widgetLibrary/data.tsx

@@ -47,7 +47,7 @@ export const DEFAULT_WIDGETS: Readonly<Array<WidgetTemplate>> = [
         fields: ['transaction', 'count()'],
         aggregates: ['count()'],
         columns: ['transaction'],
-        orderby: '-count',
+        orderby: '-count()',
       },
     ],
   },
@@ -143,7 +143,7 @@ export const DEFAULT_WIDGETS: Readonly<Array<WidgetTemplate>> = [
         fields: ['error.type', 'count()'],
         aggregates: ['count()'],
         columns: ['error.type'],
-        orderby: '-count',
+        orderby: '-count()',
       },
     ],
   },

+ 1 - 1
tests/js/spec/components/modals/dashboardWidgetLibraryModal.spec.jsx

@@ -132,7 +132,7 @@ describe('Modals -> DashboardWidgetLibraryModal', function () {
             aggregates: ['count()'],
             columns: ['transaction'],
             name: '',
-            orderby: '-count',
+            orderby: '-count()',
           },
         ],
         title: 'High Throughput Transactions',