Просмотр исходного кода

ref(search): normalize parsed values (#69198)

Normalize parsed values. Durations to ms, sizes to bytes, numbers to
spoiler alert (numbers), dates to dates and bools to "duh" bools

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Jonas 10 месяцев назад
Родитель
Сommit
c418650ab5

+ 1 - 1
fixtures/search-syntax/aggregate_duration_filter.json

@@ -31,7 +31,7 @@
           "type": "valueDuration",
           "value": "500",
           "unit": "s",
-          "parsed": {"value": 500, "unit": "s"}
+          "parsed": {"value": 500000}
         }
       },
       {"type": "spaces", "value": ""}

+ 1 - 1
fixtures/search-syntax/aggregate_duration_filter_overrides_numeric_shorthand.json

@@ -32,7 +32,7 @@
           "type": "valueDuration",
           "value": "2",
           "unit": "m",
-          "parsed": {"value": 2, "unit": "m"}
+          "parsed": {"value": 120000}
         }
       },
       {"type": "spaces", "value": ""}

+ 0 - 4
fixtures/search-syntax/aggregate_rel_time_filter.json

@@ -21,8 +21,6 @@
           "sign": "+",
           "unit": "d",
           "parsed": {
-            "sign": "+",
-            "unit": "d",
             "value": "2017-10-24T02:41:20.000Z"
           }
         }
@@ -52,8 +50,6 @@
           "sign": "-",
           "unit": "w",
           "parsed": {
-            "sign": "-",
-            "unit": "w",
             "value": "2017-10-03T02:41:20.000Z"
           }
         }

+ 1 - 1
fixtures/search-syntax/boolean_filter_passthrough.json

@@ -13,7 +13,7 @@
           "type": "valueNumber",
           "value": "1",
           "unit": null,
-          "parsed": {"value": 1, "unit": null}
+          "parsed": {"value": 1}
         }
       },
       {"type": "spaces", "value": ""}

+ 3 - 3
fixtures/search-syntax/duration_aggregate_measurements_filter.json

@@ -35,7 +35,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}
@@ -77,7 +77,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}
@@ -119,7 +119,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}

+ 3 - 3
fixtures/search-syntax/duration_aggregate_op_breakdowns_filter.json

@@ -35,7 +35,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}
@@ -77,7 +77,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}
@@ -119,7 +119,7 @@
           "type": "valueDuration",
           "value": "3.3",
           "unit": "s",
-          "parsed": {"value": 3.3, "unit": "s"}
+          "parsed": {"value": 3300}
         }
       },
       {"type": "spaces", "value": ""}

+ 2 - 2
fixtures/search-syntax/duration_filter.json

@@ -13,7 +13,7 @@
           "type": "valueDuration",
           "value": "500",
           "unit": "s",
-          "parsed": {"value": 500, "unit": "s"}
+          "parsed": {"value": 500000}
         }
       },
       {"type": "spaces", "value": ""}
@@ -33,7 +33,7 @@
           "type": "valueDuration",
           "value": "500",
           "unit": "s",
-          "parsed": {"value": 500, "unit": "s"}
+          "parsed": {"value": 500000}
         }
       },
       {"type": "spaces", "value": ""}

+ 1 - 1
fixtures/search-syntax/duration_filter_overrides_numeric_shorthand.json

@@ -14,7 +14,7 @@
           "type": "valueDuration",
           "value": "2",
           "unit": "m",
-          "parsed": {"value": 2, "unit": "m"}
+          "parsed": {"value": 120000}
         }
       },
       {"type": "spaces", "value": ""}

+ 3 - 3
fixtures/search-syntax/duration_measurements_filter.json

@@ -13,7 +13,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}
@@ -33,7 +33,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}
@@ -53,7 +53,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}

+ 3 - 3
fixtures/search-syntax/duration_op_breakdowns_filter.json

@@ -13,7 +13,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}
@@ -33,7 +33,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}
@@ -53,7 +53,7 @@
           "type": "valueDuration",
           "value": "1.5",
           "unit": "s",
-          "parsed": {"value": 1.5, "unit": "s"}
+          "parsed": {"value": 1500}
         }
       },
       {"type": "spaces", "value": ""}

Некоторые файлы не были показаны из-за большого количества измененных файлов