Browse Source

fix(onboarding-analytics) Do not fire `project_creation.data_removal_modal_dismissed` on modal confirm (#77630)

`onClose` is being called whenever a modal is closed - even on modal
confirm.

There is a callback `onCancel` which can be used to track
`project_creation.data_removal_modal_dismissed` events. `onCancel` is
called only when the modal is dismissed.

Part of https://github.com/getsentry/sentry/issues/77391

Signed-off-by: Vjeran Grozdanic <vjeran.grozdanic@sentry.io>
Vjeran Grozdanić 5 months ago
parent
commit
c2c9f01b7d
1 changed files with 1 additions and 1 deletions
  1. 1 1
      static/app/views/projectInstall/platformDocHeader.tsx

+ 1 - 1
static/app/views/projectInstall/platformDocHeader.tsx

@@ -104,7 +104,7 @@ export function PlatformDocHeader({platform, projectSlug, title}: Props) {
           priority="danger"
           confirmText={t("Yes I'm sure")}
           onConfirm={handleGoBack}
-          onClose={() => {
+          onCancel={() => {
             if (!recentCreatedProject) {
               return;
             }