Browse Source

chore(github-growth): more FE analytics (#56507)

Cathy Teng 1 year ago
parent
commit
c2959db774

+ 1 - 0
static/app/components/modals/inviteMissingMembersModal/index.tsx

@@ -292,6 +292,7 @@ export function InviteMissingMembersModal({
             analyticsEventKey="github_invite_modal.invite"
             analyticsParams={{
               invited_all: memberInvites.length === selectedCount,
+              invited_count: selectedCount,
             }}
           >
             {inviteButtonLabel()}

+ 1 - 1
static/app/utils/analytics/growthAnalyticsEvents.tsx

@@ -63,7 +63,7 @@ export type GrowthEventParameters = {
     guide: string;
   };
   'github_invite_banner.snoozed': {};
-  'github_invite_banner.viewed': {};
+  'github_invite_banner.viewed': {members_shown: number};
   'growth.clicked_enter_sandbox': {
     scenario: string;
     source?: string;

+ 4 - 1
static/app/views/settings/organizationMembers/inviteBanner.tsx

@@ -22,6 +22,8 @@ import useApi from 'sentry/utils/useApi';
 import {useLocation} from 'sentry/utils/useLocation';
 import withOrganization from 'sentry/utils/withOrganization';
 
+const MAX_MEMBERS_TO_SHOW = 5;
+
 type Props = {
   allowedRoles: OrgRole[];
   missingMembers: {integration: string; users: MissingMember[]};
@@ -96,6 +98,7 @@ export function InviteBanner({
   if (isEligibleForBanner && showBanner) {
     trackAnalytics('github_invite_banner.viewed', {
       organization,
+      members_shown: missingMembers.users.slice(0, MAX_MEMBERS_TO_SHOW).length,
     });
   }
   if (!isEligibleForBanner || !showBanner) {
@@ -127,7 +130,7 @@ export function InviteBanner({
 
   const users = missingMembers.users;
 
-  const cards = users.slice(0, 5).map(member => {
+  const cards = users.slice(0, MAX_MEMBERS_TO_SHOW).map(member => {
     const username = member.externalId.split(':').pop();
     return (
       <MemberCard