Browse Source

fix(crons): Clean up test monitor decorators (#67262)

These were being used to debug why some monitors were failing
Evan Purkhiser 11 months ago
parent
commit
c1551141c7

+ 0 - 3
src/sentry/dynamic_sampling/tasks/boost_low_volume_projects.py

@@ -4,7 +4,6 @@ from collections.abc import Mapping, Sequence
 from datetime import datetime, timedelta
 
 import sentry_sdk
-from sentry_sdk.crons.decorator import monitor
 from snuba_sdk import (
     Column,
     Condition,
@@ -83,8 +82,6 @@ PROJECTS_WITH_METRICS = {1, 11276}  # sentry  # javascript
     time_limit=2 * 60 * 60 + 5,
     silo_mode=SiloMode.REGION,
 )
-# TODO(rjo100): dual write check-ins for debugging
-@monitor(monitor_slug="dynamic-sampling-boost-low-volume-transactions-test")
 @dynamic_sampling_task_with_context(max_task_execution=MAX_TASK_SECONDS)
 def boost_low_volume_projects(context: TaskContext) -> None:
     for orgs in TimedIterator(context, GetActiveOrgs(max_projects=MAX_PROJECTS_PER_QUERY)):

+ 0 - 5
src/sentry/tasks/deletion/hybrid_cloud.py

@@ -21,7 +21,6 @@ from django.db import connections, router
 from django.db.models import Max, Min
 from django.db.models.manager import BaseManager
 from django.utils import timezone
-from sentry_sdk.crons.decorator import monitor
 
 from sentry.db.models.fields.hybrid_cloud_foreign_key import HybridCloudForeignKey
 from sentry.models.tombstone import TombstoneBase
@@ -99,8 +98,6 @@ def _chunk_watermark_batch(
     acks_late=True,
     silo_mode=SiloMode.CONTROL,
 )
-# TODO(rjo100): dual write check-ins for debugging
-@monitor(monitor_slug="schedule-hybrid-cloud-foreign-key-jobs-control-test")
 def schedule_hybrid_cloud_foreign_key_jobs_control():
     _schedule_hybrid_cloud_foreign_key(
         SiloMode.CONTROL, process_hybrid_cloud_foreign_key_cascade_batch_control
@@ -113,8 +110,6 @@ def schedule_hybrid_cloud_foreign_key_jobs_control():
     acks_late=True,
     silo_mode=SiloMode.REGION,
 )
-# TODO(rjo100): dual write check-ins for debugging
-@monitor(monitor_slug="schedule-hybrid-cloud-foreign-key-jobs-test")
 def schedule_hybrid_cloud_foreign_key_jobs():
     _schedule_hybrid_cloud_foreign_key(
         SiloMode.REGION, process_hybrid_cloud_foreign_key_cascade_batch

+ 0 - 2
src/sentry/tasks/integrations/github/pr_comment.py

@@ -6,7 +6,6 @@ from typing import Any
 
 import sentry_sdk
 from django.db import connection
-from sentry_sdk.crons.decorator import monitor
 from snuba_sdk import Column, Condition, Direction, Entity, Function, Op, OrderBy, Query
 from snuba_sdk import Request as SnubaRequest
 
@@ -241,7 +240,6 @@ def github_comment_workflow(pullrequest_id: int, project_id: int):
 @instrumented_task(
     name="sentry.tasks.integrations.github_comment_reactions", silo_mode=SiloMode.REGION
 )
-@monitor(monitor_slug="github_comment_reactions_test")
 def github_comment_reactions():
     logger.info("github.pr_comment.reactions_task")